On Wed, Oct 24, 2007 at 09:50:25AM -0600, Jordan Crouse wrote:
On 24/10/07 17:27 +0200, Uwe Hermann wrote:
On Wed, Oct 24, 2007 at 04:56:47PM +0200, svn@openbios.org wrote:
Modified: buildrom-devel/config/platforms/Config.in
--- buildrom-devel/config/platforms/Config.in 2007-10-18 00:10:57 UTC (rev 45) +++ buildrom-devel/config/platforms/Config.in 2007-10-24 14:56:47 UTC (rev 46) @@ -34,5 +34,8 @@ bool "Tyan S2891" select PLATFORM
+config PLATFORM_SERENGETI_CHEETAH
bool "AMD Serengeti_Cheetah"No underscore needed here, I think.
Thats what its called in LinuxBIOS, so we tried to stick with the same names. I agree thats not always the best policy, but the Serengeti-Cheetah name is confusing anyway, so we went with this.
I think this depends where the name is used. In C struct names or as variable names, directory names etc. some adaptations might be necessary. For use in comments or README or other texts we should, in general, use the "official" correct name as per vendor (website etc).
This is not true for all boards, maybe we should make this a requirement only for those boards which actually require it.
This target is only built by those targets that do require it.
OK, that's no problem then.
But thats also why I made find-cool a function - if we find other tools we need, then we should not be afraid to add them.
Yep.
Uwe.