Re: [coreboot] [LinuxBIOS] flashrom on ga 2761gxdk

[Carl-Daniel Hailfinger]

Hi Ron,

can I have an Ack for that patch? It has been sitting in my queue for
quite some time. I'll split the patch in 2 commits because spi.c has
been restructured and it is not advisable to commit patches for 2
different issues in one commit.

Regards,
Carl-Daniel

On 10.01.2008 13:32, Carl-Daniel Hailfinger wrote:
> Btw, the block lock bits are all set, so even if you manage to convince
> the SPI translation to map more than 512 KByte and even if you use
> enable LPC-to-SPI writes, you will still flash nothing. Try this for
> better lock bit printing:
>
> Enable LPC write cycle to SPI write cycle translation for IT8716F.
> Print detailed status register information for SST25VF series flash.
>
> Signed-off-by: Carl-Daniel Hailfinger
> Index: flashrom-ron/spi.c
>
> --- flashrom-ron/spi.c	(Revision 3036)
> +++ flashrom-ron/spi.c	(Arbeitskopie)
> @@ -136,6 +136,11 @@
>    		0xFFF80000, 0xFFFEFFFF, (tmp & 1 << 3) ? "en" : "dis");
>    	printf("LPC write to serial flash %sabled\n",
>    		(tmp & 1 << 4) ? "en" : "dis");
> if (!(tmp & 1 << 4)) {
> 	printf("Force enabling LPC write to serial flash\n");
> 	tmp |= 1 << 4;
> 	regwrite(port, 0x24, tmp);
> }
> printf("serial flash pin %i\n",	(tmp & 1 << 5) ? 87 : 29);
> /* LDN 0x7, reg 0x64/0x65 */
> regwrite(port, 0x07, 0x7);
>
> @@ -323,7 +328,8 @@
>    switch (flash->manufacture_id) {
>    case ST_ID:
>    case MX_ID:
> if ((flash->model_id & 0xff00) == 0x2000)
> if (((flash->model_id & 0xff00) == 0x2000) ||
>     ((flash->model_id & 0xff00) == 0x2500))
> generic_spi_prettyprint_status_register_st_m25p(status);
> break;
> }