Re: [coreboot] [PATCH] add PC87382 to superiotool

[Uwe Hermann]

Hi,

On Tue, Feb 01, 2011 at 11:58:04AM +0100, Sven Schnelle wrote:
> this patch adds the NSC PC87382 to superiotool. It is a rather small
> 'superio' device, containing one Serial Port, one Infrared Port, GPIO
> and a Docking LPC switch. It is used in various Thinkpads.
>
> It adds 0x164e/0x16ef to the list of probed port for NSC chipsets, as
> Thinkpads are using this address pair.
>
> Signed-off-by: Sven Schnelle

Thanks, committed as r6327 with minor whitespace and consistency
changes.
> {0xf4, "PC87382", {
> { NOLDN, NULL,
> 	{ 0x20, 0x21, 0x22, 0x26, 0x27, 0x29, EOT },
> 	{ 0xf2, 0x11, 0x63, 0x00, 0x00, 0x00, EOT }},

I also changed the 0xf2 value for register 0x20 (chip ID) to 0xf4, that
was probably a typo.

Uwe.