Re: [coreboot] update to latest filo rev, remove manual sata spinup patch

[Jordan Crouse]

On 20/03/08 16:09 -0400, Ward Vandewege wrote:
>
> This patch updates buildrom to use the latest filo revision, which includes the
> SLOW_SATA option. It also modifies the m57sli filo config file to set that
> flag, and removes the filo sata patch we were applying to achieve the same
> thing.
>
> Tested on real hardware.
>
> Signed-off-by: Ward Vandewege

Acked-by: Jordan Crouse
> Index: packages/filo/filo.mk
>
> --- packages/filo/filo.mk	(revision 139)
> +++ packages/filo/filo.mk	(working copy)
> @@ -1,5 +1,5 @@
>  FILO_URL=svn://coreboot.org/filo/trunk/filo-0.5
> -FILO_TAG=42
> +FILO_TAG=44
>
> FILO_DIR=$(BUILD_DIR)/filo
>  FILO_SRC_DIR=$(FILO_DIR)/svn
> @@ -8,11 +8,6 @@
>
> FILO_PATCHES=$(PACKAGE_DIR)/filo/patches/make.patch
>
> -ifeq ($(CONFIG_PLATFORM_GA_M57SLI_S4),y)
> FILO_PATCHES += $(PACKAGE_DIR)/filo/patches/sata-spinup-delay.patch
>
> -endif
>
> ifeq ($(CONFIG_VERBOSE),y)
>  FILO_FETCH_LOG=/dev/stdout
>  FILO_BUILD_LOG=/dev/stdout
> Index: packages/filo/conf/m57sli-Config
> ===================================================================
> --- packages/filo/conf/m57sli-Config	(revision 139)
> +++ packages/filo/conf/m57sli-Config	(working copy)
> @@ -7,6 +7,8 @@
>  # Add a short delay when polling status registers
>  # (required on some broken SATA controllers)
>  IDE_DISK_POLL_DELAY = 1
> +# Wait 5 seconds to allow the sata disks to spin up
> +SLOW_SATA = 1
>  # Driver for USB Storage
>  USB_DISK = 1
>  # VGA text console
> Index: packages/filo/patches/sata-spinup-delay.patch
> ===================================================================
> --- packages/filo/patches/sata-spinup-delay.patch	(revision 139)
> +++ packages/filo/patches/sata-spinup-delay.patch	(working copy)
> @@ -1,12 +0,0 @@
> -Index: main/filo.c
>
> ---- svn/main/filo.c (revision 34)
> -+++ svn/main/filo.c (working copy)
> -@@ -60,6 +60,7 @@
> /* Initialize */
> init();
>
> -+    delay (5);
> grub_main();
> return 0;   
> }
>