Re: [coreboot] [PATCH 6/6] Separate CMOS layout from lbtable handling.

[Stefan Reinauer]

* Patrick Georgi  [110127 15:07]:
> Signed-off-by: Patrick Georgi

Mixed use of uint32_t and u32. Otherwise

Acked-by: Stefan Reinauer
> Index: nvramtool/accessors/layout-bin.c
>
> --- /dev/null
> +++ nvramtool/accessors/layout-bin.c
> +void get_layout_from_cbfs_file(void)
> +{
> u32 len;
> cmos_table = cbfs_find_file("cmos_layout.bin", CBFS_COMPONENT_CMOS_LAYOUT, &len);
> process_layout();
>
> +}

...
> +static const struct lb_record *first_cmos_rec(uint32_t tag)
> +{
> const char *p;
> uint32_t bytes_processed, bytes_for_entries;
> const struct lb_record *lbrec;
> p = ((const char *)cmos_table) + cmos_table->header_length;
> bytes_for_entries = cmos_table->size - cmos_table->header_length;
> for (bytes_processed = 0;
>     bytes_processed < bytes_for_entries;
>     bytes_processed += lbrec->size) {
> lbrec = (const struct lb_record *)&p[bytes_processed];
> if (lbrec->tag == tag)
> 	return lbrec;
> }
> return NULL;
>
> +}