Re: [coreboot] [PATCH] CAR on Intel P6 Series - Support for model_6bx

[Joseph Smith]

On Thu, 8 Apr 2010 15:45:50 -0600, Myles Watson  wrote:
> > On Thu, 08 Apr 2010 23:37:59 +0200, Stefan Reinauer
>
> <[e-mail]
> > >
> >
> > wrote:
> > > On 4/8/10 11:32 PM, Joseph Smith wrote:
> > > > > > Index: src/cpu/intel/model_6bx/Kconfig
> > > > > >
> > > > > > --- src/cpu/intel/model_6bx/Kconfig        (revision 0)
> > > > > > +++ src/cpu/intel/model_6bx/Kconfig        (revision 0)
> > > > > > @@ -0,0 +1,3 @@
> > > > > > +config CPU_INTEL_CORE
> > > > > > bool
> > > > > > select SMP
>
> This looks like it was copied directly from cpu/intel/model_6ex/Kconfig.
>
> You are redefining CPU_INTEL_CORE here.  This is probably where you

wanted
> to define CPU_INTEL_MODEL_6BX.

Ah ok thanks Myles.

So there is not actually a:

#define CPU_INTEL_MODEL_6BX blabla

preprocessing directive anywhere. It just needs to be defined in Kconfig.