-----Original Message----- From: Kevin O'Connor [mailto:kevin@koconnor.net] Sent: Saturday, July 04, 2009 11:48 PM To: coreboot@coreboot.org; Jason Zhao Subject: Re: [coreboot] Share my code of running vgabios(in CBFS)
inseabios
when rusume from s3.
On Sat, Jul 04, 2009 at 02:09:28PM +0200, Peter Stuge wrote:
Kevin O'Connor wrote:
void s3_resume_vga_init() { if (!CONFIG_S3_RESUME_VGA_INIT) return; struct rom_header *rom = (void*)OPTION_ROM_START; if (! is_valid_rom(rom)) return; callrom(rom, OPTION_ROM_INITVECTOR, 0); }
Would this remove the need for the acpi=s3_bios kernel parameter?
I guess this is doing the same thing?
I think it is doing the same thing. I committed the above code to seabios, but I left it disabled by default.
Your s3_resume_vga_init() work on my board.
Jason, if you use "acpi=s3_bios" does it work without running the rom from seabios?
"acpi=s3_bios" (or acpi_sleep=s3_bios) do not work on my board. Ubuntu do not call vgabios at 0xc0000 until I press ctrl+alt+f7. And after I press ctrl+alt+f7, tty7 show GUI normal, but tty1~tty5 still have wrong color and lines.
And according to the description of linuxkernel/Documentation/power/video.txt, "(2) systems where it is possible to call the video BIOS during S3 resume. Unfortunately, it is not correct to call the video BIOS at that point, but it happens to work on some machines. Use acpi_sleep=s3_bios."
So calling vgabios in coreboot/seabios should be different with using "acpi=s3_bios".
-Kevin