Re: [coreboot] [PATCH 3/5] Intel 3100, version 3

[Peter Stuge]

On Thu, Mar 13, 2008 at 02:44:02PM -0700, Ed Swierk wrote:
> This patch implements support for Intel 3100 integrated southbridge
> devices. This is largely based on the existing Intel 6300esb code.

Also ack, but..
> +static void smbus_write_byte(unsigned device, unsigned address, unsigned char val)
> +{
> if (smbus_wait_until_ready(SMBUS_IO_BASE) < 0) {
> return;
> }
> return;
>
> +}

..is this really working? Could be just the function call in that
case.

//Peter