try again.
On Nov 25, 2007 3:23 PM, Uwe Hermann uwe@hermann-uwe.de wrote:
The fix should be easy though. You probably forgot to 'svn add' the Kconfig file mainboard/pcengines/Kconfig.
fixed.
Add a full stop to the help text, please.
fixed.
+## Copyright (C) 2007 coresystems GmbH +## (Written by Stefan Reinauer stepan@coresystems.de for coresystems GmbH)
Ron Minnich?
I added my name but this is really a copy of an existing Kconfig, so I left Stefan in.
For now I'd say just drop the entries here, the code checks via #ifdef if they're defined and does nothing if they're not...
I deleted those entries .
+int main(void) +{
u8 smb_devices[] = {
DIMM0, DIMM1
};
post_code(POST_START_OF_MAIN);
POST_START_OF_MAIN, and...
+void hardware_stage1(void) +{
post_code(POST_START_OF_MAIN);
... POST_START_OF_MAIN again.
Shouldn't those be different?
It's in every board. We have a problem here. Any ideas welcome, but I would rather not hold up this commit since it just follows the pattern of other boards; we need to fix them all.
+/{
enabled;
mainboard-vendor = "PC Engines";
mainboard-name = "Alix 1C";
ALIX1.C
fixed.
Index: mainboard/pcengines/alix1c/cmos.layout
--- mainboard/pcengines/alix1c/cmos.layout (revision 0) +++ mainboard/pcengines/alix1c/cmos.layout (revision 0)
Add the common license header to this file, please.
no other cmos.layout has it. Let's get a template and apply them all, but I don't want to hold this specific board up when we need a general fix.
Please don't hardcode POST codes, add them aѕ #defines in post_code.h and document them (i.e. in which situation it is supposed to be used).
uh oh. There's only one entry in post_code.h :-)
we need to sync up the doc and post_code.h
how about we commit this and take 3 action items: 1. fix up post_code.h 2. Fix all cmos.layout files with license headers 3. fix all main.c and stage1.c to use diffferent post code entries.
ron