coreboot December 2023

coreboot@coreboot.org

20 participants
49 discussions

2023-12-13 - coreboot Leadership Meeting Minutes
by mina＠coreboot.org 14 Dec '23

14 Dec '23

# 2023-12-13 - coreboot Leadership Meeting Minutes ## Attendees Martin R, Werner Zeh, Christian Walter, Matt DeVillier, Felix Singer, Felix Held, Jay Talbott, Marshall Dawson, Simon Glass, David Hendricks, Maximilian Brune, Jeremy Compostella, Jonathan Hall, Karthik R, Nico H, Mina A, Lean Sheng Tan. ## Open Action Items * 2023-12-13 * Patrick? FelixS?: Look at improving the responsiveness of gerrit. * Swapping issues? * Jenkins taking resources * 504 error code - 500 error code * Same patch pushed twice, same change-ID two different gerrit ids. * Patches showing up as open even after they’re merged * Move coreboot resources off of stefan’s server? * 2023-11-29 * [Open] FelixS: Draft a proof-of-concept proposal to switch to meson. * 2023-11-15 * [Done] Martin: Publish coreboot FAQ https://review.coreboot.org/c/coreboot/+/79441 * 2023-11-01 * [Open] Martin: Shallow submodules - document & test, then update submodules if testing goes well. Additionally look at whether the .branch option helps. * No progress yet * 2023-10-18 * [Started](https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/th… XKVCP3YIFJEE/) MattD and WernerZ: Work on compiling a list of website requirements from the mailing list. * No feedback yet - Matt will continue to gather feedback. * Probably have all of the community input - Need to capture the requirements as a starting point. * Move to next year. * [On hold] [pending requirements] MartinR & FelixS: Build a POC front page. * [Open] Arthur: Ask Philip about how to use company logos. * 2023-10-4 * [Started](https://docs.google.com/document/d/1Z8igNdgBG5_Qlr4kKRtlbpKaZo9RUg… Martin: Write a tutorial for gerrit - Feel free to help. * [Open] OSFF: Look into making a video about using gerrit. * Discussed with Christian who felt this was a good plan. * Look at next year. * [Open] Martin: Write a document about vendorcode submodules. * Not started * 2023-09-20 * [Started](https://review.coreboot.org/c/coreboot/+/78832) Martin: Work on [clang-format config update](https://review.coreboot.org/c/coreboot/+/78832). * We can use the clang format version from the coreboot toolchain! * Some issues with clang format - martin will present. * See [CB:78833](https://review.coreboot.org/c/coreboot/+/78833) for what the current format’s changes will look like. * [David] #defines for bits in headers lose their indenting. Maybe we should have clang-format ignore headers for now. Smaller issues can be handled on a "use your best “judgement" basis. * [Done] Martin to add [bitfield](https://review.coreboot.org/c/coreboot/+/78833/4/src/drivers/inte… example to 78833 * Let’s look at running this just for .c files to start with. ## Minutes ### [Martin] Covered open action items ### [Martin] Present Projects & RFCs list ### [Sheng] Decision for Bootflow on Arm64 Server * As mentioned in previous leadership meeting and a special meeting on 05 Dec 2023, the leadership team will make decision on going forward with the proposal here: https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/BRW3… WM/ * We’re proposing that there are two additional boot flows added to Arm’s document. https://docs.google.com/document/d/1z3fLdUmbOBKvHJfub8ki9YWjuqpK_1PY0H4BWwm… ### Decision * We’re agreeing to change the coreboot codebase to support the modified bootflow, based on the understanding that the standard coreboot arm bootflow will also be included. If that isn’t accepted, we’ll need to revisit this. If Arm agrees to include both boot flows in their document, we will get the patches merged, but we’d like an agreement from them before that’s done. * Nico: The secure monitor is still an issue. That’s not open source. * [Martin] But the secure boot monitor is not part of coreboot or even called by coreboot in the new boot flow. Let’s have a discussion about it, but there are other topics we want to cover in this meeting. ### [Martin/MaxB] Look at improving the readability of our build system * See https://review.coreboot.org/c/coreboot/+/79230 - this combines a number of changes into a single patch just to see what things would look like. * Please take a look and voice opinions. * Some problems: * Makefiles at the directory tips frequently have `ifeq` blocks surrounding the entire contents. https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/main/src/… * We probably shouldn’t indent the entire file. * To indent ifeq/ifneq/endif statements inside a target, we need to use spaces instead of tabs. This leads to an ugly mix of spaces and tabs, which can be confusing, and will break the build if it’s done incorrectly. ### [Martin] Cancel the December 27th meeting? * Cancel this! ### [PatrickG, Martin] How to present design proposals? * There’s some tension in the project between “folks write a whole new thingamabob and submit it whole to the project, then get indignant when the project doesn’t adopt it wholesale. To avoid that from happening, we discourage working like that” and “you want to do something? Build a prototype” * Should we document what we think is a good way to approach such situations? * With the example of “make a coreboot build system based on meson”, Patrick mused: “While we discourage folks from dumping a full solution on us, having a partial solution (and that should be more than a userland tool, because those are easy in meson) to offer a glimpse in how it should look is worthwhile. The problems arise when there's so much work sunk into it that rejecting it means rejecting a developer's work of months, which is why that's not a good approach to "dump code on us". * There aren't any hard & fast rules, but - "I got qemu to compile (typically the easiest target) and this is how it looks" seems like a good step in between. - If it takes months to get to that stage, it's probably not worth it, because whatever has been built in that time is as complex as what we have. - "I got qemu to compile, but don't mind the mess in most of the tree. I have a plan how it should look (see src/cpu which is more like it) but I wanted to prove the concept first" already offers something that can be discussed properly without costing too much effort. * Stefan offered that code can be published on Gerrit even when it’s not ready yet (and/or just a prototype). Gerrit does have a “Work In Progress” flag for CLs, after all, so there’s not necessarily a need to set up a branch for such work. * Flow: * Propose the idea to the mailing list * Present a draft * Do a small implementation (Qemu or similar) * Present an RFC * Review on mailing list & in leadership meeting. * ??? * Profit??? * Felixs: Start a forum? Replace the mailing list with a forum? * Felixh: We already have the bugtracker - it uses a different login than gerrit, so it’s already problematic to use. Let’s not create another. * Nico: The mailing list is the most accessible method. Everyone can participate well. * Felixs: Just looking at how other open source projects done today open projects on gitlab or github, and people discuss things there. People today are used to that. People don’t like writing emails. Modern solutions look nicer and are more accessible. * SJG: Mailing list is searchable and everything can be seen later. Other things are more of a walled garden. Replacing the mailing list would be a bad decision. * Nico: Forums are accessible only to people able to use a web browser. * This can at least be an example process, if not the only process. ### [Martin] review of “Setup Option Table” (placeholder name for what was CFR) * We’re more aligned with a build-time approach, with customization of the data structures in mainboard code. If this customization becomes commonplace, we can move functions into lib/sot or something. * Kconfig-based / data-serialization-language (like yaml, ~~cbor or protobuf~~)? * [Setup Option Table requirements](https://docs.google.com/document/d/1WAc6k8k4hUhcUJl-hl9jUfEWh… for *any* solution * Kconfig [Setup Option Tables](https://docs.google.com/document/d/1TWbxKRhsTpid7xyK-yMdsxhfZxZtTTN… h.astha87lu249) * Kconfig [Setup Option Table DSL](https://docs.google.com/document/d/18uApZbuvou9unlL8SdTZ4dTblHD2OGs_Sg… ### [Simon]: Serial RFC * The proof of concept is here https://review.coreboot.org/c/coreboot/+/79317 Now updated to allow use of a CBFS file. * Does the -2 indicate that this is being killed? * [Martin] I don’t think so - I think Julius just wanted to prevent it from going in without agreement. I think he wouldn’t have made so many comments if he just wanted to kill it. * I’ve already stated numerous times that I don’t think that an option method based solely on including the configuration directly into bootblock is the right way to go about things. If we do pursue this, I’d like to be able to see the ability to add the CCB to a separate area in CBFS, which will be far more useful in the long-run, in my opinion. # Next meeting * January 10, 2024. * [Meeting link](https://meet.google.com/pyt-newq-rbb) * [coreboot Calendar](https://coreboot.org/calendar.html) # Notice * Decisions shown here are not necessarily final, and are based on the current information available. If there are questions or comments about decisions made, or additional information to present, please put it on the leadership meeting agenda and show up if possible to discuss it. Of course items may also be discussed on the mailing list, but as it's difficult to interpret tone over email, controversial topics frequently do not have good progress in those discussions. For particularly difficult issues, it may be best to try to schedule another meeting. # coreboot leadership meeting minutes * https://docs.google.com/document/d/1NRXqXcLBp5pFkHiJbrLdv3Spqh1Hu086HYkKrgK…

1 0

Re: coreboot Meetings Announcement And Agenda Call
by Julius Werner 12 Dec '23

12 Dec '23

[edit: that was meant to go to the list, too] On Mon, Dec 11, 2023 at 3:12 PM Julius Werner <jwerner(a)chromium.org> wrote: >> >> ### [Simon]: Serial RFC >> * The proof of concept is here https://review.coreboot.org/c/coreboot/+/79317 >> * Does the -2 indicate that this is being killed? >> * [Martin] I don’t think so - I think Julius just wanted to prevent it from going in without >> agreement. I think he wouldn’t have made so many comments if he just wanted to kill it. >> * I’ve already stated numerous times that I don’t think that an option method based solely on >> including the configuration directly into bootblock is the right way to go about things. If we do >> pursue this, I’d like to be able to see the ability to add the CCB to a separate area in CBFS, >> which will be far more useful in the long-run, in my opinion. > > > Unfortunately I'll be on a plane this Wednesday and won't be able to join this discussion. Would you mind if we move this to next meeting?

2 2

coreboot Meetings Announcement And Agenda Call
by mina＠coreboot.org 11 Dec '23

11 Dec '23

Dear community, Kindly note that the upcoming coreboot leadership meeting is scheduled for Wednesday, December 13, 2023.[1] You are welcome to add things you wish to see addressed during the meeting to the current agenda items. [2] ## Current Agenda Items ### [Martin] Cover open action items ### [Martin/MaxB] Look at improving the readability of our build system * See https://review.coreboot.org/c/coreboot/+/79230 - this combines a number of changes into a single patch just to see what things would look like. ### [Martin] Cancel the December 27th meeting? ### [PatrickG, Martin] How to present design proposals? * There’s some tension in the project between “folks write a whole new thingamabob and submit it whole to the project, then get indignant when the project doesn’t adopt it wholesale. To avoid that from happening, we discourage working like that” and “you want to do something? Build a prototype” * Should we document what we think is a good way to approach such situations? * with the example of “make a coreboot build system based on meson”, Patrick mused: “While we discourage folks from dumping a full solution on us, having a partial solution (and that should be more than a userland tool, because those are easy in meson) to offer a glimpse in how it should look is worthwhile. The problems arise when there's so much work sunk into it that rejecting it means rejecting a developer's work of months, which is why that's not a good approach to "dump code on us". * There aren't any hard & fast rules, but - "I got qemu to compile (typically the easiest target) and this is how it looks" seems like a good step in between. - If it takes months to get to that stage, it's probably not worth it, because whatever has been built in that time is as complex as what we have. - "I got qemu to compile, but don't mind the mess in most of the tree. I have a plan how it should look (see src/cpu which is more like it) but I wanted to prove the concept first" already offers something that can be discussed properly without costing too much effort. * Stefan offered that code can be published on Gerrit even when it’s not ready yet (and/or just a prototype). Gerrit does have a “Work In Progress” flag for CLs, after all, so there’s not necessarily a need to set up a branch for such work. ### [Martin] Localization of non-console strings for coreboot * With the addition of an early display, we’re looking at printing text to the screen directly from coreboot. Localization is being added for this, but the current patch uses the localization code from vboot. This isn’t a security related feature so shouldn’t depend on the rest of VBOOT being enabled. https://review.coreboot.org/c/coreboot/+/79054 * We also just had an RFC about storing setup engine strings. It seems like we’d want to make sure that whatever plan we have in place also supports localization for those strings as well. * How do we want to handle localization in coreboot? It seems like we’re going to be adding more strings that will be presented to the user. ### [Martin] review of “Setup Option Table” (placeholder name for what was CFR) * We’re more aligned with a build-time approach, with customization of the data structures in mainboard code. If this customization becomes commonplace, we can move functions into lib/sot or something. * Kconfig-based / data-serialization-language (like yaml, cbor or protobuf)? * [Setup Option Table requirements](https://docs.google.com/document/d/1WAc6k8k4hUhcUJl-hl9jUfEWh… * [Setup Option Tables](https://docs.google.com/document/d/1TWbxKRhsTpid7xyK-yMdsxhfZxZtTTN… h.astha87lu249) * [Setup Option Table DSL](https://docs.google.com/document/d/18uApZbuvou9unlL8SdTZ4dTblHD2OGs_Sg… ### [Martin/others] Look at writing a doc stating what coreboot is * It’s been argued that this shouldn’t be called a “spec”, but Daniel Maslowski pointed out that coreboot is being defined by others as something that we aren’t, because we don’t have a good definition of what we are. Whatever we want to call it, it seems like a good plan to have *something* discussing what coreboot is. ### [Simon]: Serial RFC * The proof of concept is here https://review.coreboot.org/c/coreboot/+/79317 * Does the -2 indicate that this is being killed? * [Martin] I don’t think so - I think Julius just wanted to prevent it from going in without agreement. I think he wouldn’t have made so many comments if he just wanted to kill it. * I’ve already stated numerous times that I don’t think that an option method based solely on including the configuration directly into bootblock is the right way to go about things. If we do pursue this, I’d like to be able to see the ability to add the CCB to a separate area in CBFS, which will be far more useful in the long-run, in my opinion. [1] https://coreboot.org/calendar.html [2] https://docs.google.com/document/d/1NRXqXcLBp5pFkHiJbrLdv3Spqh1Hu086HYkKrgK…

1 0

geminilake fsp on Google Chromebook?
by James Feeney 11 Dec '23

11 Dec '23

Comparing the git trees for the current stock coreboot and for your MrChromebox-4.21, I'm wondering about the .config differences generated by nconfig at CONFIG_FSP_HEADER_PATH=. ./src/soc/intel/apollolake/Kconfig has: config FSP_HEADER_PATH default "src/vendorcode/intel/fsp/fsp2_0/geminilake/2.2.0.0" if VENDOR_GOOGLE && SOC_INTEL_GEMINILAKE default "src/vendorcode/intel/fsp/fsp2_0/geminilake/2.2.3.1" if SOC_INTEL_GEMINILAKE default "3rdparty/fsp/ApolloLakeFspBinPkg/Include/" But, "make nconfig" in the MrChromebox tree, nonetheless, produces 'CONFIG_FSP_HEADER_PATH="src/vendorcode/intel/fsp/fsp2_0/geminilake/2.2.3.1"' in the .config, somehow, despite the above, while the stock coreboot "make nconfig" instead produces 'CONFIG_FSP_HEADER_PATH="src/vendorcode/intel/fsp/fsp2_0/geminilake/2.2.0.0"', as might be expected. Can someone explain why there is the "if VENDOR_GOOGLE && SOC_INTEL_GEMINILAKE" consraint for the fsp? Is fsp 2.2.3.1 actually still the correct configuration when using the fsp.bin files extracted from the stock Google ChromeOS? Thanks James

3 4

Need help with porting coreboot.
by bud 08 Dec '23

08 Dec '23

Hello, I would like some help with porting coreboot using autoport. I do not understand most of the instructions given in the documentation, for example: "Grab coreboot tree" Which coreboot tree? This one?: git clone ssh://review.coreboot.org:29418/coreboot or this one?: git clone https://review.coreboot.org/coreboot.git Apart from this, I have many other issues with understanding the documentation I would really appreciate it if you could provide step by step instructions with the commands to execute, without any vague instructions from the documentation. Thank you, bud (NOTE: I apologize if my tone of writing sounded rude.)

2 1

coreboot Meetings Announcement And Agenda Call
by mina＠coreboot.org 08 Dec '23

08 Dec '23

Dear community, We are happy to announce that the upcoming coreboot leadership meeting is scheduled for Wednesday, December 13, 2023. [1] Please take a moment to update the current agenda items with matters you wish to see addressed during the meeting. [2] [1] https://coreboot.org/calendar.html [2] https://docs.google.com/document/d/1NRXqXcLBp5pFkHiJbrLdv3Spqh1Hu086HYkKrgK…

1 0

How to add additional LPC decode ranges to Baytrail.
by Jose Trujillo 08 Dec '23

08 Dec '23

Hello Dear Community: I am trying to enable UART port addresses 3e8 and 2e8 to one of my 2 superios I have attached to the same LPC port. I need 4 UART ports. Both superio chips work if I set 3f8 and 2f8 but one at the time (i need to disable the other SIO). Today I was looking at baytrail code but I got lost; I did not even find how the code add 3f8/2f8 in order to do the same to 3e8/2e8. i found the function "lpc_open_pmio_window()" but this didn't build for me on Baytrail. Do somebody know to to add LPC decode ranges for 3e8 and 2e8 on Baytrail? Please let me know. Jose Trujillo.

1 0

[coreboot - Bug #519] (New) make gconfig - could not find glade file
by James Feeney 07 Dec '23

07 Dec '23

Issue #519 has been reported by James Feeney. ---------------------------------------- Bug #519: make gconfig - could not find glade file https://ticket.coreboot.org/issues/519 * Author: James Feeney * Status: New * Priority: Normal * Target version: none * Start date: 2023-12-07 * Affected versions: 4.21 ---------------------------------------- $ git rev-parse HEAD 62c25351c101a3d5c7104aa6fc34e71990478dde Arch Linux make 4.4.1-2 $ make gconfig ... (gconf:825619): libglade-WARNING **: 09:26:11.670: could not find glade file '/sdb/coreboot.main/build/util/kconfig/gconf.glade' ** (gconf:825619): ERROR **: 09:26:11.673: GUI loading failed ! make: *** [build/util/kconfig/Makefile.real:47: gconfig] Trace/breakpoint trap (core dumped) $ find -name gconf.glade ./util/kconfig/gconf.glade $ ll /sdb/coreboot.main/build/util/kconfig/gconf.glade /bin/ls: cannot access '/sdb/coreboot.main/build/util/kconfig/gconf.glade': No such file or directory -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: https://ticket.coreboot.org/my/account

1 1

[coreboot - Bug #518] (New) make xconfig - g++: fatal error: no input files
by James Feeney 07 Dec '23

07 Dec '23

Issue #518 has been reported by James Feeney. ---------------------------------------- Bug #518: make xconfig - g++: fatal error: no input files https://ticket.coreboot.org/issues/518 * Author: James Feeney * Status: New * Priority: Normal * Category: build system * Target version: none * Start date: 2023-12-07 * Affected versions: 4.21 ---------------------------------------- $ git rev-parse HEAD 62c25351c101a3d5c7104aa6fc34e71990478dde Arch Linux make 4.4.1-2 $ make -d xconfig ... Found '/sdb/coreboot.main/util/kconfig/qconf.cc'. ... No implicit rule found for '/sdb/coreboot.main/util/kconfig/qconf.cc'. ... Finished prerequisites of target file 'build/util/kconfig/qconf.o'. Must remake target 'build/util/kconfig/qconf.o'. /sdb/coreboot.main/util/kconfig/Makefile.inc:63: update target 'build/util/kconfig/qconf.o' due to: target does not exist ... g++: fatal error: no input files compilation terminated. ... -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: https://ticket.coreboot.org/my/account

1 0

Baytrail issue to communicate with superios.
by Jose Trujillo 06 Dec '23

06 Dec '23

Hello All: I hope you are doing great. The system: Baytrail E3845, 4GB DDR3, fintek (f81803a) @0x4e and Winbond (w83627dhg) @0x2e, etc... I just built coreboot (master) the last few days, everything works wonderfully except 2 things: - Libgfxinit probably because this board is using the AUX channel instead DDI to communicate with the monitors; seems to me libgfxinit cannot find monitors thru DP ports but I could be wrong because neither VGA gets initialized; and eventually Linux always initialize the video correctly. - SuperIOs not working; "cat /proc/interrupts" shows not activity from any serial port to any processor, but, I set accordingly (konfig, devicetree and superio.asl) I will check on Monday if the route definitions of "irqroute.h" are ok. Using "superiotool" to scan for SIO devices finds Winbond W83627DHG and dumped all its registries but doesn't show Fintek f81803 because of lack of support, so, data exchange between the processor and the SIO chips via LPC port seems to be fine, maybe just need to fix the interrupt issues. Any help will be highly appreciated, Thank you, JT

2 7

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot December 2023