coreboot May 2009

coreboot@coreboot.org

92 participants
571 discussions

[patch][v2]:fam10 microcode
by Bao, Zheng 01 Jul '09

01 Jul '09

Attached are the latest ucode patches for Family 10h: 9fh for RB/BL/DA Rev C; 96h for DR Rev B. Signed-off-by: <zheng.bao(a)amd.com> Zheng

10 45

Bug in cache_as_ram.inc and cache_as_ram_post.c
by Thomas Jourdan 01 Jul '09

01 Jul '09

Hi guys I don't know how usefull is it but there is a bug in cache_as_ram.inc and cache_as_ram_post.c for the 6fx intel processors. The code disable / enable the prefetcher in IA32_MISC_ENABLES MSR register. cache_as_ram.inc : /* Disable prefetchers */ movl $0x01a0, %eax rdmsr orl $((1 << 9) | (1 << 19)), %eax orl $((1 << 5) | (1 << 7)), %edx wrmsr should be movl $0x01a0, %ecx Same thing in cache_as_ram_post.c /* Enable prefetchers */ "movl $0x01a0, %eax\n" "rdmsr\n" "andl $~((1 << 9) | (1 << 19)), %eax\n" "andl $~((1 << 5) | (1 << 7)), %edx\n" "wrmsr\n" should be "movl $0x01a0, %ecx\n" Regards, Thomas

2 1

Patch reviews
by Carl-Daniel Hailfinger 28 Jun '09

28 Jun '09

Hi, I noticed that many people are waiting for reviews/commits of their patches. This can be a frustrating experience, so please let me explain the situation. Writing a patch is a _lot_ easier than reviewing it thoroughly. Even one-liners can have a profound unwanted impact on code flow which is not visible at a first glance. Reviewing a patch is time-consuming. I usually spend at least twice the time reviewing a patch compared to writing it myself. Writing a patch is also much more pleasant than reviewing it. Writing a patch is an act of creation whereas reviewing a patch is about finding flaws. That said, reviewing a patch thoroughly (that also includes reading the code around it, the code it calls and the code it is called from) is a great way to start with development. If you want to get your hands dirty, I recommend looking for unapplied patches and reviewing them. Don't be discouraged if someone else posts a review in the meantime, your review is still valuable. If you find the same things another reviewer has mentioned, still write about them (you did find them as well, you deserve the credit). Write about everything you checked even if it is OK. That shows others what you reviewed and how you worked. If you already know the codebase well, _please_ try to review unapplied patches. Patch reviewers are essential for the success of our project because: - they keep buggy code out - they keep bad design out - they help patch submitters to improve their code - they ensure steadily increasing code quality - they show the patch submitter that someone cared about the patch. If you have unapplied patches in your queue, please reply to them with a small note ("ping" etc.) so reviewers can find them and look at them. Regards, Carl-Daniel -- http://www.hailfinger.org/

10 16

EP80579 Mainboard support
by Arnaud Maye 25 Jun '09

25 Jun '09

Hello Everyone, We are designing a mainboard powered by an EP80579 and I came across coreboot. I've seen corebot v2 supports the Truxton EP80579 Development kit. However I cannot get any relevant information about Truxton. Is this the "official" intel development kit (EP80579TRXDK) or something else? I wanted to order the exact board coreboot supports and use this as a reference design. Could the people in charge of maintaining the EP80579 modules get back to me with this information? The initial stage would be to have Windows/Linux running on our board followed by VxWorks. Anyone around here as already used coreboot to "boot" a Vxworks system? Thank you! Arnaud Maye Embedded Systems Manager. www.4dsp.com * ** *

5 15

#138: Flashrom cannot read/verify (-rv) from v2-R3923
by coreboot 19 Jun '09

19 Jun '09

#138: Flashrom cannot read/verify (-rv) from v2-R3923 ----------------------------------------+----------------------------------- Reporter: bothlyn@… | Owner: somebody Type: defect | Status: new Priority: minor | Milestone: flashrom v1.0 Component: flashrom | Version: v2 Keywords: | Dependencies: Patchstatus: patch needs review | ----------------------------------------+----------------------------------- flashrom 0.9.0 R545 cannot process -rv (Verification always fails) This appears to be due to read_flash being moved and parameters being changed in v2-R3923 This means that uint8_t *buf, declared in main, is empty when verify_flash is called. flashrom -r <filename> followed by flashrom -v <filename> Still works. Attached patch to flashrom.c appears effective against v2-R4294 -- Ticket URL: <http://tracker.coreboot.org/trac/coreboot/ticket/138> coreboot <http://www.coreboot.org/>

1 1

#122: Add links to logs of successful builds on the QA pages
by coreboot 19 Jun '09

19 Jun '09

#122: Add links to logs of successful builds on the QA pages ------------------------------------+--------------------------------------- Reporter: hailfinger | Owner: stepan Type: enhancement | Status: new Priority: major | Milestone: Component: wiki/website/tracker | Version: v2 Keywords: | Dependencies: Patchstatus: there is no patch | ------------------------------------+--------------------------------------- http://qa.coreboot.org/log_buildrev.php?revision=3962 and other build status pages contain only links to failing builds. Please add links to successful logs as well. Benefits: * easier comparisons between failing and successful builds * the ability to look for warnings in the compiler output -- Ticket URL: <http://tracker.coreboot.org/trac/coreboot/ticket/122> coreboot <http://www.coreboot.org/>

1 2

#100: flashrom: Change start/end -s and -e to -S and -E, and change erase -E to -e.
by coreboot 19 Jun '09

19 Jun '09

#100: flashrom: Change start/end -s and -e to -S and -E, and change erase -E to -e. -------------------------------------+-------------------------------------- Reporter: stuge | Owner: somebody Type: enhancement | Status: new Priority: major | Milestone: flashrom v1.0 Component: flashrom | Version: Keywords: usability cli options | Dependencies: Patchstatus: patch needs review | -------------------------------------+-------------------------------------- -- Ticket URL: <http://tracker.coreboot.org/trac/coreboot/ticket/100> coreboot <http://www.coreboot.org/>

1 4

seabios - long delays detecting disks
by Ward Vandewege 15 Jun '09

15 Jun '09

Hi Kevin et al, In this log file: http://ward.vandewege.net/coreboot/seabios/20090515-seabios-sgabios-serial-… you can see that seabios is having a hard time on this mcp55 detecting controllers/disks: ...... init hard drives ATA controller 0 at 1f0/3f0 (dev 20 prog_if 8a) ATA controller 1 at 170/370 (dev 20 prog_if 8a) ATA controller 2 at 5000/5070 (dev 28 prog_if 85) ATA controller 3 at 5010/5080 (dev 28 prog_if 85) powerup iobase=1f0 st=0 powerup iobase=1f0 st=0 ata_detect drive=0 sc=55 sn=aa dh=a0 ata_reset driveid=0 ata_reset exit status=0 Identify w0=85c0 w2=0 ata0-0: PIONEER DVD-RW DVR-111D ATAPI-5 CD-Rom/DVD-Rom powerup iobase=1f0 st=50 powerup iobase=1f0 st=0 ata_detect drive=1 sc=55 sn=aa dh=b0 send_cmd : read error (status=01 err=04) IDE time out powerup IDE floating powerup IDE floating ata_detect drive=2 sc=ff sn=ff dh=ff powerup IDE floating powerup IDE floating ata_detect drive=3 sc=ff sn=ff dh=ff powerup iobase=5000 st=50 powerup iobase=5000 st=50 ata_detect drive=4 sc=55 sn=aa dh=a0 ata_reset driveid=4 ata_reset exit status=50 send_cmd : read error (status=51 err=04) Identify w0=427a w2=0 ata2-0: PCHS=16383/16/63 translation=lba LCHS=1024/255/63 ata2-0: WDC WD2500SD-01KCB0 ATA-6 Hard-Disk (232 GiBytes) powerup iobase=5000 st=50 powerup iobase=5000 st=0 ata_detect drive=5 sc=55 sn=aa dh=b0 send_cmd : DRQ not set (status 00) powerup iobase=5010 st=7f powerup iobase=5010 st=7f ata_detect drive=6 sc=ff sn=ff dh=ff powerup iobase=5010 st=7f powerup iobase=5010 st=7f ata_detect drive=7 sc=ff sn=ff dh=ff Scan for option roms ...... It takes about 30 seconds between printing ata0-0: PIONEER DVD-RW DVR-111D ATAPI-5 CD-Rom/DVD-Rom and ata2-0: WDC WD2500SD-01KCB0 ATA-6 Hard-Disk (232 GiBytes) on the console. Cold or warm boot does not appear to make a difference, which is perhaps not surprising since I still have so much logging on that the disk is always spun up by the time the machine gets to seabios and its disk detection. Is there something that can be done about this? Thanks, Ward. -- Ward Vandewege <ward(a)fsf.org> Free Software Foundation - Senior Systems Administrator

3 11

[PATCH] move coreboot_ram to CBFS
by Patrick Georgi 15 Jun '09

15 Jun '09

Hi, attached patch moves coreboot_ram and coreboot_apc to CBFS. That allows to reduce the size of the bootblock (the patch does this for kontron/986lcd-m), though I'll work on a more generic solution next (that will fix normal images with CBFS, too) coreboot_ram and coreboot_apc are lzma compressed, which gives ~12kb versus nrv2b on the kontron, some of which will be used for the additional cbfs+lzma code in the ROM stage. I tested it with qemu, kontron and amd/serengenti_cheetah (both with and without CBFS) The patch for src/lib/cbfs.c isn't very clean right now, I'll fix it up later by adding ntohll there and fixing up cbfstool to create those fields in network order, too. The patch creates three new files by copying: A + src/arch/i386/init/ldscript_fallback_cbfs.lb A + src/arch/i386/init/ldscript_cbfs.lb A + src/arch/i386/lib/cbfs_and_run.c They are created from ldscript_fallback.lb, ldscript.lb and copy_and_run.c in the respective directories, then modified. An example on how the CBFS is used now (as said, the bootblocks can be reduced in size) cbfstool coreboot-builds/kontron_986lcd-m/coreboot.rom print coreboot-builds/kontron_986lcd-m/coreboot.rom: 1024 kB, bootblocksize 131072, romsize 1048576, offset 0x0 Alignment: 16 bytes Name Offset Type Size normal/payload 0x0 payload 23229 normal/coreboot_ram 0x5af0 stage 107448 fallback/payload 0x1fee0 payload 23229 fallback/coreboot_ram 0x259e0 stage 107053 0x3fc50 free 656280 cbfstool coreboot-builds/amd_serengeti_cheetah/coreboot.rom print coreboot-builds/amd_serengeti_cheetah/coreboot.rom: 512 kB, bootblocksize 266240, romsize 524288, offset 0x0 Alignment: 16 bytes Name Offset Type Size normal/payload 0x0 payload 23229 normal/coreboot_ram 0x5af0 stage 61307 normal/coreboot_apc 0x14ab0 stage 5687 fallback/payload 0x16120 payload 23229 fallback/coreboot_ram 0x1bc20 stage 60849 fallback/coreboot_apc 0x2aa10 stage 5687 0x2c080 free 77704 Signed-off-by: Patrick Georgi <patrick.georgi(a)coresystems.de>

3 2

[PATCH] flashrom: Make packagers happy
by Carl-Daniel Hailfinger 12 Jun '09

12 Jun '09

This patch introduces two new targets which are designed to make the life of packagers easier. In particular, it should no longer be necessary to patch the makefile for hassle-free compilation. The two new targets are: make export make tarball Both preserve svn revisions and the exported tree does not depend on subversion in any way or shape. Documentation for this feature has been added to README. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-packaging_export/Makefile =================================================================== --- flashrom-packaging_export/Makefile (Revision 505) +++ flashrom-packaging_export/Makefile (Arbeitskopie) @@ -41,9 +41,15 @@ # Set the flashrom version string from the highest revision number # of the checked out flashrom files. -SVNDEF := -D'FLASHROM_VERSION="0.9.0-r$(shell svnversion -cn . \ - | sed -e "s/.*://" -e "s/$[0-9]*$.*/\1/")"' +# Note to packagers: Any tree exported with "make export" or "make tarball" +# will not require any working subversion command. +SVNVERSION := $(shell (LANG=C svnversion -cn . | grep -v exported || cat .svnversion) \ + | sed -e "s/.*://" -e "s/$[0-9]*$.*/\1/") +VERSION := 0.9.0-r$(SVNVERSION) + +SVNDEF := -D'FLASHROM_VERSION="$(VERSION)"' + $(PROGRAM): $(OBJS) $(CC) -o $(PROGRAM) $(OBJS) $(LDFLAGS) $(STRIP) $(STRIP_ARGS) $(PROGRAM) @@ -78,6 +84,15 @@ mkdir -p $(PREFIX)/share/man/man8 $(INSTALL) $(PROGRAM).8 $(PREFIX)/share/man/man8 +export: + @svn export . flashrom-$(VERSION) + @echo -n $(SVNVERSION) >flashrom-$(VERSION)/.svnversion + @echo Exported flashrom repository contents to flashrom-$(VERSION)/ + +tarball: export + @tar cfz flashrom-$(VERSION).tar.gz flashrom-$(VERSION)/ + @echo Created tarball of repository contents at flashrom-$(VERSION).tar.gz + .PHONY: all clean distclean dep pciutils -include .dependencies Index: flashrom-packaging_export/README =================================================================== --- flashrom-packaging_export/README (Revision 505) +++ flashrom-packaging_export/README (Arbeitskopie) @@ -12,6 +12,21 @@ (see http://coreboot.org for details on coreboot) +Packaging +--------- + +To package flashrom and remove dependencies on subversion, either use +make export +or +make tarball + +make export will export all flashrom files from the subversion repository into +a directory named flashrom-$VERSION-r$SVNREVISION and will additionally create +a file .svnversion in that directory which stores the svn revision of the tree. + +make tarball will simply tar up the result of make export and gzip compress it. + + Build Requirements ------------------ -- http://www.hailfinger.org/ Index: flashrom-packaging_export/Makefile =================================================================== --- flashrom-packaging_export/Makefile (Revision 505) +++ flashrom-packaging_export/Makefile (Arbeitskopie) @@ -41,9 +41,15 @@ # Set the flashrom version string from the highest revision number # of the checked out flashrom files. -SVNDEF := -D'FLASHROM_VERSION="0.9.0-r$(shell svnversion -cn . \ - | sed -e "s/.*://" -e "s/$[0-9]*$.*/\1/")"' +# Note to packagers: Any tree exported with "make export" or "make tarball" +# will not require any working subversion command. +SVNVERSION := $(shell (LANG=C svnversion -cn . | grep -v exported || cat .svnversion) \ + | sed -e "s/.*://" -e "s/$[0-9]*$.*/\1/") +VERSION := 0.9.0-r$(SVNVERSION) + +SVNDEF := -D'FLASHROM_VERSION="$(VERSION)"' + $(PROGRAM): $(OBJS) $(CC) -o $(PROGRAM) $(OBJS) $(LDFLAGS) $(STRIP) $(STRIP_ARGS) $(PROGRAM) @@ -78,6 +84,15 @@ mkdir -p $(PREFIX)/share/man/man8 $(INSTALL) $(PROGRAM).8 $(PREFIX)/share/man/man8 +export: + @svn export . flashrom-$(VERSION) + @echo -n $(SVNVERSION) >flashrom-$(VERSION)/.svnversion + @echo Exported flashrom repository contents to flashrom-$(VERSION)/ + +tarball: export + @tar cfz flashrom-$(VERSION).tar.gz flashrom-$(VERSION)/ + @echo Created tarball of repository contents at flashrom-$(VERSION).tar.gz + .PHONY: all clean distclean dep pciutils -include .dependencies Index: flashrom-packaging_export/README =================================================================== --- flashrom-packaging_export/README (Revision 505) +++ flashrom-packaging_export/README (Arbeitskopie) @@ -12,6 +12,21 @@ (see http://coreboot.org for details on coreboot) +Packaging +--------- + +To package flashrom and remove dependencies on subversion, either use +make export +or +make tarball + +make export will export all flashrom files from the subversion repository into +a directory named flashrom-$VERSION-r$SVNREVISION and will additionally create +a file .svnversion in that directory which stores the svn revision of the tree. + +make tarball will simply tar up the result of make export and gzip compress it. + + Build Requirements ------------------

3 15

← Newer
1
2
3
4
5
6
7
...
58
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot May 2009