coreboot August 2008

coreboot@coreboot.org

64 participants
593 discussions

r3459 - trunk/coreboot-v2/src/devices
by svn＠coreboot.org 01 Aug '08

01 Aug '08

Author: stepan Date: 2008-08-01 14:53:04 +0200 (Fri, 01 Aug 2008) New Revision: 3459 Modified: trunk/coreboot-v2/src/devices/pciexp_device.c Log: Typo, thanks to Idwer for spotting this. (trivial patch) Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/coreboot-v2/src/devices/pciexp_device.c =================================================================== --- trunk/coreboot-v2/src/devices/pciexp_device.c 2008-08-01 12:28:38 UTC (rev 3458) +++ trunk/coreboot-v2/src/devices/pciexp_device.c 2008-08-01 12:53:04 UTC (rev 3459) @@ -34,7 +34,7 @@ /* error... */ return; } - printk_debug("PCIe: tunning %s\n", dev_path(dev)); + printk_debug("PCIe: tuning %s\n", dev_path(dev)); #warning "IMPLEMENT PCI EXPRESS TUNING" }

1 0

Re: [coreboot] r3458 - trunk/coreboot-v2/src/devices
by Peter Stuge 01 Aug '08

01 Aug '08

On Fri, Aug 01, 2008 at 02:28:40PM +0200, svn(a)coreboot.org wrote: > Author: stepan > New Revision: 3458 Sweet cleanups! //Peter

1 0

r3458 - trunk/coreboot-v2/src/devices
by svn＠coreboot.org 01 Aug '08

01 Aug '08

Author: stepan Date: 2008-08-01 14:28:38 +0200 (Fri, 01 Aug 2008) New Revision: 3458 Modified: trunk/coreboot-v2/src/devices/device.c Log: clarify in the printks what function is actually called. This little smart magic drove me crazy during debugging. Fix Typos. Add a warning because the on-chipset devices are hardcoded. For newer machines, a lot more memory space will have special meanings, and we can't hardcode them all in an ifdef desert. (trivial) Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/coreboot-v2/src/devices/device.c =================================================================== --- trunk/coreboot-v2/src/devices/device.c 2008-08-01 12:20:26 UTC (rev 3457) +++ trunk/coreboot-v2/src/devices/device.c 2008-08-01 12:28:38 UTC (rev 3458) @@ -272,7 +272,7 @@ min_align = 0; base = bridge->base; - printk_spew("%s compute_allocate_%s: base: %08Lx size: %08Lx align: %d gran: %d\n", + printk_spew("%s compute_allocate_resource %s: base: %08Lx size: %08Lx align: %d gran: %d\n", dev_path(bus->dev), (bridge->flags & IORESOURCE_IO)? "io": (bridge->flags & IORESOURCE_PREFETCH)? "prefmem" : "mem", @@ -312,7 +312,7 @@ align = min_align; } - /* Propogate the resource alignment to the bridge register */ + /* Propagate the resource alignment to the bridge register */ if (align > bridge->align) { bridge->align = align; } @@ -325,10 +325,12 @@ if (bridge->limit > resource->limit) { bridge->limit = resource->limit; } +#warning This heuristics should be replaced by real devices with fixed resources. /* Artificially deny limits between DEVICE_MEM_HIGH and 0xffffffff */ if ((bridge->limit > DEVICE_MEM_HIGH) && (bridge->limit <= 0xffffffff)) { bridge->limit = DEVICE_MEM_HIGH; } + if (resource->flags & IORESOURCE_IO) { /* Don't allow potential aliases over the * legacy pci expansion card addresses. @@ -373,7 +375,7 @@ */ bridge->size = round(base, bridge->gran) - bridge->base; - printk_spew("%s compute_allocate_%s: base: %08Lx size: %08Lx align: %d gran: %d done\n", + printk_spew("%s compute_allocate_resource %s: base: %08Lx size: %08Lx align: %d gran: %d done\n", dev_path(bus->dev), (bridge->flags & IORESOURCE_IO)? "io": (bridge->flags & IORESOURCE_PREFETCH)? "prefmem" : "mem", @@ -633,7 +635,7 @@ * relocated to their final position and stored to the hardware. * * I/O resources start at DEVICE_IO_START and grow upward. MEM resources start - * at DEVICE_MEM_START and grow downward. + * at DEVICE_MEM_HIGH and grow downward. * * Since the assignment is hierarchical we set the values into the dev_root * struct.

1 0

r3457 - trunk/coreboot-v2/src/config
by svn＠coreboot.org 01 Aug '08

01 Aug '08

Author: stepan Date: 2008-08-01 14:20:26 +0200 (Fri, 01 Aug 2008) New Revision: 3457 Modified: trunk/coreboot-v2/src/config/Config.lb Log: clean out obsoleted config.lb rules and output, fix indenting (trivial) Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/coreboot-v2/src/config/Config.lb =================================================================== --- trunk/coreboot-v2/src/config/Config.lb 2008-08-01 12:12:37 UTC (rev 3456) +++ trunk/coreboot-v2/src/config/Config.lb 2008-08-01 12:20:26 UTC (rev 3457) @@ -84,7 +84,7 @@ makerule coreboot_apc.o depends "coreboot_apc.a c_start.o $(LIBGCC_FILE_NAME)" - action "$(CC) $(DISTRO_LFLAGS) -nostdlib -r -o $@ c_start.o coreboot_apc.a $(LIBGCC_FILE_NAME)" + action "$(CC) $(DISTRO_LFLAGS) -nostdlib -r -o $@ c_start.o coreboot_apc.a $(LIBGCC_FILE_NAME)" end makerule coreboot_apc @@ -126,11 +126,6 @@ action "$(CROSS_COMPILE)nm -n coreboot | sort > coreboot.map" end -#makerule crt0.S -# depends "$(CRT0)" -# action "cp $< $@" -#end - # the buildrom tool makerule buildrom depends "$(TOP)/util/buildrom/buildrom.c" @@ -141,13 +136,11 @@ makedefine .PHONY : crt0.s makerule crt0.s depends "crt0.S $(CRT0_INCLUDES)" - action "@echo \"$(CPP) ... $< > $@ \"" action "$(CPP) $(CPPFLAGS) -I. -I$(TOP)/src $< > $@.new && mv $@.new $@" end makerule crt0.o depends "crt0.s" - action "@echo $(CC) ... -o $@ $<" action "@$(CC) -c $(CPU_OPT) -o $@ $<" end @@ -179,11 +172,6 @@ action "$(HOSTCC) $(HOSTCFLAGS) $(CPUFLAGS) $< -o $@" end -#makerule /$(TARGET_DIR)/option_table.c -# depends "build_opt_tbl $(MAINBOARD)/cmos.layout" -# action "./build_opt_tbl -b --config $(MAINBOARD)/cmos.layout" -#end - makerule option_table.c depends "build_opt_tbl $(MAINBOARD)/cmos.layout" action "./build_opt_tbl -b --config $(MAINBOARD)/cmos.layout --header option_table.h" @@ -196,12 +184,6 @@ if HAVE_OPTION_TABLE object ./option_table.o -#special rule -#makerule option_table.o -# depends "option_table.c" -# action "$(CC) -c $(CFLAGS) -o $@ $<" -#end -# object option_table.o end makerule clean

1 0

r3456 - trunk/coreboot-v2/src/ram
by svn＠coreboot.org 01 Aug '08

01 Aug '08

Author: stepan Date: 2008-08-01 14:12:37 +0200 (Fri, 01 Aug 2008) New Revision: 3456 Modified: trunk/coreboot-v2/src/ram/ramtest.c Log: use printk, when possible. (trivial) Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/coreboot-v2/src/ram/ramtest.c =================================================================== --- trunk/coreboot-v2/src/ram/ramtest.c 2008-08-01 12:11:00 UTC (rev 3455) +++ trunk/coreboot-v2/src/ram/ramtest.c 2008-08-01 12:12:37 UTC (rev 3456) @@ -29,22 +29,34 @@ /* * Fill. */ +#if CONFIG_USE_PRINTK_IN_CAR + printk_debug("DRAM fill: 0x%08x-0x%08x\r\n", start, stop); +#else print_debug("DRAM fill: "); print_debug_hex32(start); print_debug("-"); print_debug_hex32(stop); print_debug("\r\n"); +#endif for(addr = start; addr < stop ; addr += 4) { /* Display address being filled */ - if (!(addr & 0xffff)) { + if (!(addr & 0xfffff)) { +#if CONFIG_USE_PRINTK_IN_CAR + printk_debug("%08x \r", addr); +#else print_debug_hex32(addr); print_debug(" \r"); +#endif } write_phys(addr, addr); }; /* Display final address */ +#if CONFIG_USE_PRINTK_IN_CAR + printk_debug("%08x\r\nDRAM filled\r\n", addr); +#else print_debug_hex32(addr); print_debug("\r\nDRAM filled\r\n"); +#endif } static void ram_verify(unsigned long start, unsigned long stop) @@ -54,40 +66,70 @@ /* * Verify. */ +#if CONFIG_USE_PRINTK_IN_CAR + printk_debug("DRAM verify: 0x%08x-0x%08x\r\n", start, stop); +#else print_debug("DRAM verify: "); print_debug_hex32(start); print_debug_char('-'); print_debug_hex32(stop); print_debug("\r\n"); +#endif for(addr = start; addr < stop ; addr += 4) { unsigned long value; /* Display address being tested */ - if (!(addr & 0xffff)) { + if (!(addr & 0xfffff)) { +#if CONFIG_USE_PRINTK_IN_CAR + printk_debug("%08x \r", addr); +#else print_debug_hex32(addr); print_debug(" \r"); +#endif } value = read_phys(addr); if (value != addr) { /* Display address with error */ +#if CONFIG_USE_PRINTK_IN_CAR + printk_err("Fail: @0x%08x Read value=0x%08x\r\n", addr, value); +#else print_err("Fail: @0x"); print_err_hex32(addr); print_err(" Read value=0x"); print_err_hex32(value); print_err("\r\n"); +#endif i++; if(i>256) { +#if CONFIG_USE_PRINTK_IN_CAR + printk_debug("Aborting.\n\r"); +#else print_debug("Aborting.\n\r"); +#endif break; } } } /* Display final address */ +#if CONFIG_USE_PRINTK_IN_CAR + printk_debug("%08x", addr); +#else print_debug_hex32(addr); +#endif + if (i) { +#if CONFIG_USE_PRINTK_IN_CAR + printk_debug("\r\nDRAM did _NOT_ verify!\r\n"); +#else print_debug("\r\nDRAM did _NOT_ verify!\r\n"); +#endif + die("DRAM ERROR"); } else { +#if CONFIG_USE_PRINTK_IN_CAR + printk_debug("\r\nDRAM range verified.\r\n"); +#else print_debug("\r\nDRAM range verified.\r\n"); +#endif } } @@ -99,13 +141,21 @@ * test than a "Is my DRAM faulty?" test. Not all bits * are tested. -Tyson */ +#if CONFIG_USE_PRINTK_IN_CAR + printk_debug("Testing DRAM : %08x - %08x\r\n", start, stop); +#else print_debug("Testing DRAM : "); print_debug_hex32(start); print_debug("-"); print_debug_hex32(stop); print_debug("\r\n"); +#endif ram_fill(start, stop); ram_verify(start, stop); +#if CONFIG_USE_PRINTK_IN_CAR + printk_debug("Done.\r\n"); +#else print_debug("Done.\r\n"); +#endif }

1 0

r3455 - in trunk/coreboot-v2/src/cpu/intel: model_69x model_6dx model_6xx
by svn＠coreboot.org 01 Aug '08

01 Aug '08

Author: stepan Date: 2008-08-01 14:11:00 +0200 (Fri, 01 Aug 2008) New Revision: 3455 Modified: trunk/coreboot-v2/src/cpu/intel/model_69x/model_69x_init.c trunk/coreboot-v2/src/cpu/intel/model_6dx/model_6dx_init.c trunk/coreboot-v2/src/cpu/intel/model_6xx/model_6xx_init.c Log: match against all steppings of a CPU model, because these are _model_ drivers. (trivial) Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/coreboot-v2/src/cpu/intel/model_69x/model_69x_init.c =================================================================== --- trunk/coreboot-v2/src/cpu/intel/model_69x/model_69x_init.c 2008-08-01 12:06:08 UTC (rev 3454) +++ trunk/coreboot-v2/src/cpu/intel/model_69x/model_69x_init.c 2008-08-01 12:11:00 UTC (rev 3455) @@ -38,7 +38,8 @@ .init = model_69x_init, }; static struct cpu_device_id cpu_table[] = { - { X86_VENDOR_INTEL, 0x0695 }, /* Pentium M */ + { X86_VENDOR_INTEL, 0x0690 }, /* Pentium M */ + { X86_VENDOR_INTEL, 0x0695 }, { 0, 0 }, }; Modified: trunk/coreboot-v2/src/cpu/intel/model_6dx/model_6dx_init.c =================================================================== --- trunk/coreboot-v2/src/cpu/intel/model_6dx/model_6dx_init.c 2008-08-01 12:06:08 UTC (rev 3454) +++ trunk/coreboot-v2/src/cpu/intel/model_6dx/model_6dx_init.c 2008-08-01 12:11:00 UTC (rev 3455) @@ -38,6 +38,7 @@ .init = model_6dx_init, }; static struct cpu_device_id cpu_table[] = { + { X86_VENDOR_INTEL, 0x06D0 }, /* Pentium M on 90nm with 2MiB of L2 cache */ { X86_VENDOR_INTEL, 0x06D6 }, /* Pentium M on 90nm with 2MiB of L2 cache */ { 0, 0 }, }; Modified: trunk/coreboot-v2/src/cpu/intel/model_6xx/model_6xx_init.c =================================================================== --- trunk/coreboot-v2/src/cpu/intel/model_6xx/model_6xx_init.c 2008-08-01 12:06:08 UTC (rev 3454) +++ trunk/coreboot-v2/src/cpu/intel/model_6xx/model_6xx_init.c 2008-08-01 12:11:00 UTC (rev 3455) @@ -44,17 +44,21 @@ .init = model_6xx_init, }; static struct cpu_device_id cpu_table[] = { + { X86_VENDOR_INTEL, 0x0650 }, { X86_VENDOR_INTEL, 0x0652 }, - { X86_VENDOR_INTEL, 0x0665 }, /* Celeron (Mendocino) */ + { X86_VENDOR_INTEL, 0x0660 }, /* Celeron (Mendocino) */ + { X86_VENDOR_INTEL, 0x0665 }, { X86_VENDOR_INTEL, 0x0672 }, { X86_VENDOR_INTEL, 0x0673 }, + { X86_VENDOR_INTEL, 0x0680 }, { X86_VENDOR_INTEL, 0x0681 }, { X86_VENDOR_INTEL, 0x0683 }, { X86_VENDOR_INTEL, 0x0686 }, { X86_VENDOR_INTEL, 0x06A0 }, { X86_VENDOR_INTEL, 0x06A1 }, { X86_VENDOR_INTEL, 0x06A4 }, - { X86_VENDOR_INTEL, 0x06B4 }, /* Mobile Celeron FCBGA */ + { X86_VENDOR_INTEL, 0x06B0 }, /* Mobile Celeron FCBGA */ + { X86_VENDOR_INTEL, 0x06B4 }, { 0, 0 }, };

1 0

r3454 - trunk/coreboot-v2/src/pc80
by svn＠coreboot.org 01 Aug '08

01 Aug '08

Author: stepan Date: 2008-08-01 14:06:08 +0200 (Fri, 01 Aug 2008) New Revision: 3454 Removed: trunk/coreboot-v2/src/pc80/serial.inc Log: serial.inc is not used anywhere. drop it (trivial) Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Deleted: trunk/coreboot-v2/src/pc80/serial.inc =================================================================== --- trunk/coreboot-v2/src/pc80/serial.inc 2008-08-01 11:54:55 UTC (rev 3453) +++ trunk/coreboot-v2/src/pc80/serial.inc 2008-08-01 12:06:08 UTC (rev 3454) @@ -1,107 +0,0 @@ -#include <part/fallback_boot.h> - - -/* Base Address */ -#ifndef TTYS0_BASE -#define TTYS0_BASE 0x3f8 -#endif - -/* Baud Rate */ -#ifndef TTYS0_BAUD -#define TTYS0_BAUD 115200 -#endif - -#if ((115200%TTYS0_BAUD) != 0) -#error Bad ttys0 baud rate -#endif - -/* Baud Rate Divisor */ -#define TTYS0_DIV (115200/TTYS0_BAUD) -#define TTYS0_DIV_LO (TTYS0_DIV&0xFF) -#define TTYS0_DIV_HI ((TTYS0_DIV >> 8)&0xFF) - -/* Line Control Settings */ -#ifndef TTYS0_LCS -/* Set 8bit, 1 stop bit, no parity */ -#define TTYS0_LCS 0x3 -#endif - -/* Data */ -#define TTYS0_RBR (TTYS0_BASE+0x00) - -/* Control */ -#define TTYS0_TBR TTYS0_RBR -#define TTYS0_IER (TTYS0_BASE+0x01) -#define TTYS0_IIR (TTYS0_BASE+0x02) -#define TTYS0_FCR TTYS0_IIR -#define TTYS0_LCR (TTYS0_BASE+0x03) -#define TTYS0_MCR (TTYS0_BASE+0x04) -#define TTYS0_DLL TTYS0_RBR -#define TTYS0_DLM TTYS0_IER - -/* Status */ -#define TTYS0_LSR (TTYS0_BASE+0x05) -#define TTYS0_MSR (TTYS0_BASE+0x06) -#define TTYS0_SCR (TTYS0_BASE+0x07) - -#if USE_OPTION_TABLE == 1 -.section ".rom.data" - .type div,@object - .size div,8 -div: -.byte 1,2,3,6,12,24,48,96 - -.previous -#endif - - jmp serial0 - - /* uses: ax, dx */ -#define TTYS0_TX_AL \ - mov %al, %ah ; \ -9: mov $TTYS0_LSR, %dx ; \ - inb %dx, %al ; \ - test $0x20, %al ; \ - je 9b ; \ - mov $TTYS0_TBR, %dx ; \ - mov %ah, %al ; \ - outb %al, %dx - -serial_init: - /* Set 115.2Kbps,8n1 */ - /* Set 8bit, 1 stop bit, no parity, DLAB */ - mov $TTYS0_LCR, %dx - mov $(TTYS0_LCS | 0x80), %al - out %al, %dx - - /* set Baud Rate Divisor to 1 ==> 115200 Buad */ -#if USE_OPTION_TABLE == 1 - - movb $(RTC_BOOT_BYTE+1), %al - outb %al, $0x70 - xorl %edx,%edx - inb $0x71, %al - andb $7,%al - movb %al,%dl - movb div(%edx),%al - mov $TTYS0_DLL, %dx - out %al, %dx - mov $TTYS0_DLM, %dx - xorb %al,%al - out %al, %dx -#else - mov $TTYS0_DLL, %dx - mov $TTYS0_DIV_LO, %al - out %al, %dx - mov $TTYS0_DLM, %dx - mov $TTYS0_DIV_HI, %al - out %al, %dx -#endif - /* Disable DLAB */ - mov $TTYS0_LCR, %dx - mov $(TTYS0_LCS & 0x7f), %al - out %al, %dx - RETSP - -serial0: - CALLSP(serial_init)

1 0

r3453 - trunk/coreboot-v2/src/cpu/x86/mtrr
by svn＠coreboot.org 01 Aug '08

01 Aug '08

Author: stepan Date: 2008-08-01 13:54:55 +0200 (Fri, 01 Aug 2008) New Revision: 3453 Modified: trunk/coreboot-v2/src/cpu/x86/mtrr/mtrr.c Log: same spelling in all mtrr output.. (trivial) Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/coreboot-v2/src/cpu/x86/mtrr/mtrr.c =================================================================== --- trunk/coreboot-v2/src/cpu/x86/mtrr/mtrr.c 2008-08-01 11:53:39 UTC (rev 3452) +++ trunk/coreboot-v2/src/cpu/x86/mtrr/mtrr.c 2008-08-01 11:54:55 UTC (rev 3453) @@ -352,7 +352,7 @@ printk_debug("\n"); /* Initialized the fixed_mtrrs to uncached */ - printk_debug("Setting fixed MTRRs(%d-%d) type: UC\n", + printk_debug("Setting fixed MTRRs(%d-%d) Type: UC\n", 0, NUM_FIXED_RANGES); set_fixed_mtrrs(0, NUM_FIXED_RANGES, MTRR_TYPE_UNCACHEABLE);

1 0

r3452 - in trunk/coreboot-v2/src/cpu/intel: hyperthreading thermal_monitoring
by svn＠coreboot.org 01 Aug '08

01 Aug '08

Author: stepan Date: 2008-08-01 13:53:39 +0200 (Fri, 01 Aug 2008) New Revision: 3452 Removed: trunk/coreboot-v2/src/cpu/intel/thermal_monitoring/Config.lb Modified: trunk/coreboot-v2/src/cpu/intel/hyperthreading/intel_sibling.c Log: drop unused code (trivial) Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/coreboot-v2/src/cpu/intel/hyperthreading/intel_sibling.c =================================================================== --- trunk/coreboot-v2/src/cpu/intel/hyperthreading/intel_sibling.c 2008-08-01 11:50:52 UTC (rev 3451) +++ trunk/coreboot-v2/src/cpu/intel/hyperthreading/intel_sibling.c 2008-08-01 11:53:39 UTC (rev 3452) @@ -48,7 +48,6 @@ for(i = 1; i < siblings; i++) { struct device_path cpu_path; device_t new; - unsigned long count; /* Build the cpu device path */ cpu_path.type = DEVICE_PATH_APIC; cpu_path.u.apic.apic_id = cpu->path.u.apic.apic_id + i; Deleted: trunk/coreboot-v2/src/cpu/intel/thermal_monitoring/Config.lb =================================================================== --- trunk/coreboot-v2/src/cpu/intel/thermal_monitoring/Config.lb 2008-08-01 11:50:52 UTC (rev 3451) +++ trunk/coreboot-v2/src/cpu/intel/thermal_monitoring/Config.lb 2008-08-01 11:53:39 UTC (rev 3452) @@ -1,3 +0,0 @@ -#define THERMAL_MONITORING_OFF 0 -#define THERMAL_MONITORING_SET 0x00000008 -#define MISC_ENABLE 0x01a0

1 0

r3451 - trunk/coreboot-v2/src/southbridge/ricoh/rl5c476
by svn＠coreboot.org 01 Aug '08

01 Aug '08

Author: stepan Date: 2008-08-01 13:50:52 +0200 (Fri, 01 Aug 2008) New Revision: 3451 Modified: trunk/coreboot-v2/src/southbridge/ricoh/rl5c476/rl5c476.c Log: coding style fixes (trivial) Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/coreboot-v2/src/southbridge/ricoh/rl5c476/rl5c476.c =================================================================== --- trunk/coreboot-v2/src/southbridge/ricoh/rl5c476/rl5c476.c 2008-08-01 11:48:00 UTC (rev 3450) +++ trunk/coreboot-v2/src/southbridge/ricoh/rl5c476/rl5c476.c 2008-08-01 11:50:52 UTC (rev 3451) @@ -1,7 +1,6 @@ /* * (C) Copyright 2004 Nick Barker <nick.barker9(a)btinternet.com> * - * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License as * published by the Free Software Foundation; either version 2 of @@ -20,7 +19,6 @@ /* (C) Copyright 2005 Nick Barker <nick.barker(a)btinternet.com brought into line with the current architecture of coreboot */ - #include <arch/io.h> #include <device/device.h> #include <device/pci.h> @@ -34,10 +32,10 @@ static int enable_cf_boot = 0; static unsigned int cf_base; -static void udelay(int i){ +static void udelay(int i) +{ for(; i > 0 ; i--) inb(0x80); - } static void rl5c476_init(device_t dev) @@ -105,8 +103,6 @@ pc16->ioffl1 = 0x0; pc16->ioffh1 = 0; - - // set up CF config window pc16->smpga0 = cf_base>>24; pc16->smsth0 = (cf_base>>20)&0x0f; @@ -164,15 +160,12 @@ resource->size = 0x1000; resource->align = resource->gran = 12; resource->limit= 0xffff0000; - //compute_allocate_resource(&dev->link[0],resource,resource->flags,resource->flags); } cardbus_read_resources(dev); - } void rl5c476_set_resources(device_t dev) { - struct resource *resource; printk_debug("%s In set resources \n",dev_path(dev)); if( enable_cf_boot && (PCI_FUNC(dev->path.u.pci.devfn) == 1)){

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot August 2008