coreboot April 2008

coreboot@coreboot.org

75 participants
404 discussions

core names
by Peter Stuge 12 Apr '08

12 Apr '08

Hi, I was reading up on the list and want to ask a favour from all. I expect several cool payloads to pop up, much thanks to libpayload. Please please do think about how you name them. The name coreinfo is easy to confuse with coreboot. To make matters worse, the two 'core' do not refer to the same thing. There's nothing kernel-core about coreinfo whatsoever, so that 'core' simply refers to the coreboot project, for some reason. Please try to avoid inheriting core like that and really think hard about your payload names, because they CAN become immensely popular and I know I want people to immediately understand what they do. I'll be happy to help if you need to discuss name ideas. I'll try to help with ideas but when short on time I may not always be very creative. :\ //Peter

2 1

Re: [coreboot] r3236 - in trunk/payloads/libpayload: include libc
by a a 11 Apr '08

11 Apr '08

Ulf Jordan wrote: > On Fri, 11 Apr 2008, svn(a)coreboot.org wrote: > >> +int isxdigit(int c) >> +{ >> + return isdigit(c) || (tolower(c)>= 'a' && tolower(c) <= 'z'); >> +} > > Shouldn't this be > > return isdigit(c) || (tolower(c)>= 'a' && tolower(c) <= 'f'); jep it should.. but why not : return isdigit(c) || c>= 'a' && c <= 'f' || c>= 'A' && c <= 'F' ); it might be even faster if you do return isdigit(c) || (c & ~0x20)>= 'A' && (c & ~0x20) <= 'F' ); > > > /ulf > _________________________________________________________________ Express yourself instantly with MSN Messenger! Download today it's FREE! http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/

2 1

Re: [coreboot] r3236 - in trunk/payloads/libpayload: include libc
by Ulf Jordan 11 Apr '08

11 Apr '08

On Fri, 11 Apr 2008, svn(a)coreboot.org wrote: > +int isxdigit(int c) > +{ > + return isdigit(c) || (tolower(c) >= 'a' && tolower(c) <= 'z'); > +} Shouldn't this be return isdigit(c) || (tolower(c) >= 'a' && tolower(c) <= 'f'); /ulf

1 0

[3/3] [buildrom]: Add coreinfo to buildrom
by Jordan Crouse 11 Apr '08

11 Apr '08

Patch 3 of 3 - add coreinfo to buildrom. Yay!

2 3

buildrom: libpayload patch, version 2
by Jordan Crouse 11 Apr '08

11 Apr '08

A new copy of the libpayload patch for buildrom that includes the latest version of libpayload plus a specific patch for building Geode. Also, you know, this one actually... um.. works. Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc.

2 2

r144 - in buildrom-devel: config/payloads packages packages/coreinfo packages/coreinfo/conf
by svn＠coreboot.org 11 Apr '08

11 Apr '08

Author: jcrouse Date: 2008-04-11 22:28:36 +0200 (Fri, 11 Apr 2008) New Revision: 144 Added: buildrom-devel/config/payloads/coreinfo.conf buildrom-devel/packages/coreinfo/ buildrom-devel/packages/coreinfo/conf/ buildrom-devel/packages/coreinfo/conf/defconfig buildrom-devel/packages/coreinfo/coreinfo.mk Modified: buildrom-devel/config/payloads/Config.in buildrom-devel/config/payloads/payloads.conf Log: [buildrom]: Add coreinfo to buildrom Signed-off-by: Jordan Crouse <jordan.crouse(a)amd.com> Acked-by: Ward Vandewege <ward(a)gnu.org> Modified: buildrom-devel/config/payloads/Config.in =================================================================== --- buildrom-devel/config/payloads/Config.in 2008-04-11 20:27:01 UTC (rev 143) +++ buildrom-devel/config/payloads/Config.in 2008-04-11 20:28:36 UTC (rev 144) @@ -9,6 +9,9 @@ help Buildrom can build a number of different payloads for the ROM +config PAYLOAD_COREINFO + bool "Coreinfo" + config PAYLOAD_CUSTOM bool "Custom Payload" Added: buildrom-devel/config/payloads/coreinfo.conf =================================================================== --- buildrom-devel/config/payloads/coreinfo.conf (rev 0) +++ buildrom-devel/config/payloads/coreinfo.conf 2008-04-11 20:28:36 UTC (rev 144) @@ -0,0 +1,14 @@ +# Configuration file for the coreinfo payload + +# Common configuration options + +PAYLOAD_BUILD=scripts/Makefile.generic + +PAYLOAD_ELF=$(OUTPUT_DIR)/coreinfo-payload.elf +PAYLOAD_COMPRESSED=$(OUTPUT_DIR)/coreinfo-payload.elf.lzma + +PAYLOAD-y=coreinfo +PAYLOAD=coreinfo + +# Add libpayload as a dependency +DEPENDS-y=libpayload Modified: buildrom-devel/config/payloads/payloads.conf =================================================================== --- buildrom-devel/config/payloads/payloads.conf 2008-04-11 20:27:01 UTC (rev 143) +++ buildrom-devel/config/payloads/payloads.conf 2008-04-11 20:28:36 UTC (rev 144) @@ -24,7 +24,9 @@ PCONF-$(CONFIG_PAYLOAD_MEMTEST) = memtest.conf PCONF-$(CONFIG_PAYLOAD_KERNEL) = kernel.conf PCONF-$(CONFIG_PAYLOAD_CUSTOM) = custom.conf +PCONF-$(CONFIG_PAYLOAD_COREINFO) = coreinfo.conf +DEPENDS-y= include $(CONFIG_DIR)/payloads/$(PCONF-y) # Add LZMA if it is enabled and we are using v2 Added: buildrom-devel/packages/coreinfo/conf/defconfig =================================================================== --- buildrom-devel/packages/coreinfo/conf/defconfig (rev 0) +++ buildrom-devel/packages/coreinfo/conf/defconfig 2008-04-11 20:28:36 UTC (rev 144) @@ -0,0 +1,18 @@ +# +# Automatically generated make config: don't edit +# coreinfo version: 0.1.0 +# Wed Apr 9 15:45:52 2008 +# + +# +# General settings +# +CONFIG_SHOW_DATE_TIME=y + +# +# Modules +# +CONFIG_MODULE_COREBOOT=y +CONFIG_MODULE_CPUINFO=y +CONFIG_MODULE_PCI=y +CONFIG_MODULE_NVRAM=y Added: buildrom-devel/packages/coreinfo/coreinfo.mk =================================================================== --- buildrom-devel/packages/coreinfo/coreinfo.mk (rev 0) +++ buildrom-devel/packages/coreinfo/coreinfo.mk 2008-04-11 20:28:36 UTC (rev 144) @@ -0,0 +1,61 @@ +COREINFO_URL=svn://coreboot.org/repos/trunk/payloads/coreinfo +COREINFO_TAG=3228 + +COREINFO_DIR=$(BUILD_DIR)/coreinfo +COREINFO_SRC_DIR=$(COREINFO_DIR)/svn +COREINFO_STAMP_DIR=$(COREINFO_DIR)/stamps +COREINFO_LOG_DIR=$(COREINFO_DIR)/logs + +ifeq ($(CONFIG_VERBOSE),y) +COREINFO_FETCH_LOG=/dev/stdout +COREINFO_BUILD_LOG=/dev/stdout +else +COREINFO_BUILD_LOG=$(COREINFO_LOG_DIR)/build.log +COREINFO_FETCH_LOG=$(COREINFO_LOG_DIR)/fetch.log +endif + +COREINFO_CONFIG=$(PACKAGE_DIR)/coreinfo/conf/defconfig + +COREINFO_TARBALL=coreinfo-svn-$(COREINFO_TAG).tar.gz + +$(SOURCE_DIR)/$(COREINFO_TARBALL): + @ mkdir -p $(SOURCE_DIR)/coreinfo + @ $(BIN_DIR)/fetchsvn.sh $(COREINFO_URL) $(SOURCE_DIR)/coreinfo \ + $(COREINFO_TAG) $(SOURCE_DIR)/$(COREINFO_TARBALL) \ + > $(COREINFO_FETCH_LOG) 2>&1 + +$(COREINFO_STAMP_DIR)/.unpacked: $(SOURCE_DIR)/$(COREINFO_TARBALL) | $(COREINFO_STAMP_DIR) $(COREINFO_DIR) + @ echo "Unpacking coreinfo..." + @ tar -C $(COREINFO_DIR) -zxf $(SOURCE_DIR)/$(COREINFO_TARBALL) + @ touch $@ + +$(COREINFO_SRC_DIR)/.config: $(COREINFO_STAMP_DIR)/.unpacked + @ cp $(COREINFO_CONFIG) $@ + @ make -C $(COREINFO_SRC_DIR) oldconfig > $(COREINFO_BUILD_LOG) 2>&1 + +$(COREINFO_SRC_DIR)/build/coreinfo.elf: $(COREINFO_SRC_DIR)/.config + @ echo "Building coreinfo..." + @ make -C $(COREINFO_SRC_DIR) LIBPAYLOAD_DIR=$(STAGING_DIR)/libpayload \ + > $(COREINFO_BUILD_LOG) 2>&1 + +$(COREINFO_STAMP_DIR)/.copied: $(COREINFO_SRC_DIR)/build/coreinfo.elf + @ mkdir -p $(shell dirname $(PAYLOAD_ELF)) + @ cp $(COREINFO_SRC_DIR)/build/coreinfo.elf $(PAYLOAD_ELF) + @ touch $@ + +$(COREINFO_STAMP_DIR) $(COREINFO_LOG_DIR): + @ mkdir -p $@ + +coreinfo: $(COREINFO_STAMP_DIR) $(COREINFO_LOG_DIR) $(COREINFO_STAMP_DIR)/.copied + +coreinfo-clean: + @ echo "Cleaning coreinfo..." + @ $(MAKE) -C $(COREINFO_SRC_DIR) clean > /dev/null 2>&1 + @ rm -f $(COREINFO_STAMP_DIR)/.installed + +coreinfo-distclean: + @ rm -rf $(COREINFO_DIR)/* + +coreinfo-extract: $(COREINFO_STAMP_DIR)/.unpacked + +coreinfo-config:

1 0

r143 - in buildrom-devel: . packages packages/libpayload packages/libpayload/conf
by svn＠coreboot.org 11 Apr '08

11 Apr '08

Author: jcrouse Date: 2008-04-11 22:27:01 +0200 (Fri, 11 Apr 2008) New Revision: 143 Added: buildrom-devel/packages/libpayload/ buildrom-devel/packages/libpayload/conf/ buildrom-devel/packages/libpayload/conf/defconfig buildrom-devel/packages/libpayload/conf/defconfig.geode buildrom-devel/packages/libpayload/libpayload.mk Modified: buildrom-devel/Makefile Log: buildrom: Add support for libpayload as a dependency This adds support for libpayload which is built as a dependency for payloads that require it. Signed-off-by: Jordan Crouse <jordan.crouse(a)amd.com> Acked-by: Ward Vandewege <ward(a)gnu.org> Modified: buildrom-devel/Makefile =================================================================== --- buildrom-devel/Makefile 2008-04-11 20:14:30 UTC (rev 142) +++ buildrom-devel/Makefile 2008-04-11 20:27:01 UTC (rev 143) @@ -54,7 +54,7 @@ # Construct the list of packages we will be building -PKGLIST = $(COREBOOT-y) $(PAYLOAD-y) $(HOSTTOOLS-y) +PKGLIST = $(COREBOOT-y) $(DEPENDS-y) $(PAYLOAD-y) $(HOSTTOOLS-y) # Construct the various targets @@ -97,7 +97,7 @@ @ $(STAGING_DIR)/bin/lar -z $(TARGET_ROM_FILE) endif -payload: $(PAYLOAD_TARGET) +payload: $(DEPENDS-y) $(PAYLOAD_TARGET) extract: $(PKG_extract) Added: buildrom-devel/packages/libpayload/conf/defconfig =================================================================== --- buildrom-devel/packages/libpayload/conf/defconfig (rev 0) +++ buildrom-devel/packages/libpayload/conf/defconfig 2008-04-11 20:27:01 UTC (rev 143) @@ -0,0 +1,26 @@ +# +# Automatically generated make config: don't edit +# Libpayload version: +# Fri Apr 11 12:53:56 2008 +# +CONFIG_HAVE_DOT_CONFIG=y +CONFIG_TARGET_I386=y + +# +# Output Options +# +CONFIG_SERIAL_CONSOLE=y +CONFIG_SERIAL_IOBASE=0x3f8 +# CONFIG_SERIAL_SET_SPEED is not set +CONFIG_SERIAL_BAUD_RATE= +CONFIG_VIDEO_CONSOLE=y +CONFIG_VGA_VIDEO_CONSOLE=y +# CONFIG_GEODE_VIDEO_CONSOLE is not set +CONFIG_PC_KEYBOARD=y +CONFIG_NVRAM=y +# CONFIG_RTC_PORT_EXTENDED_VIA is not set + +# +# Build Options +# +CONFIG_TINYCURSES=y Added: buildrom-devel/packages/libpayload/conf/defconfig.geode =================================================================== --- buildrom-devel/packages/libpayload/conf/defconfig.geode (rev 0) +++ buildrom-devel/packages/libpayload/conf/defconfig.geode 2008-04-11 20:27:01 UTC (rev 143) @@ -0,0 +1,26 @@ +# +# Automatically generated make config: don't edit +# Libpayload version: +# Fri Apr 11 12:45:11 2008 +# +CONFIG_HAVE_DOT_CONFIG=y +CONFIG_TARGET_I386=y + +# +# Output Options +# +CONFIG_SERIAL_CONSOLE=y +CONFIG_SERIAL_IOBASE=0x3f8 +# CONFIG_SERIAL_SET_SPEED is not set +CONFIG_SERIAL_BAUD_RATE= +CONFIG_VIDEO_CONSOLE=y +# CONFIG_VGA_VIDEO_CONSOLE is not set +CONFIG_GEODE_VIDEO_CONSOLE=y +CONFIG_PC_KEYBOARD=y +CONFIG_NVRAM=y +# CONFIG_RTC_PORT_EXTENDED_VIA is not set + +# +# Build Options +# +CONFIG_TINYCURSES=y Added: buildrom-devel/packages/libpayload/libpayload.mk =================================================================== --- buildrom-devel/packages/libpayload/libpayload.mk (rev 0) +++ buildrom-devel/packages/libpayload/libpayload.mk 2008-04-11 20:27:01 UTC (rev 143) @@ -0,0 +1,93 @@ +LIBPAYLOAD_URL=svn://coreboot.org/repos/trunk/payloads/libpayload +LIBPAYLOAD_TAG=3235 + +LIBPAYLOAD_DIR=$(BUILD_DIR)/libpayload +LIBPAYLOAD_SRC_DIR=$(LIBPAYLOAD_DIR)/svn +LIBPAYLOAD_STAMP_DIR=$(LIBPAYLOAD_DIR)/stamps +LIBPAYLOAD_LOG_DIR=$(LIBPAYLOAD_DIR)/logs + +ifeq ($(CONFIG_VERBOSE),y) +LIBPAYLOAD_FETCH_LOG=/dev/stdout +LIBPAYLOAD_BUILD_LOG=/dev/stdout +LIBPAYLOAD_INSTALL_LOG=/dev/stdout +else +LIBPAYLOAD_BUILD_LOG=$(LIBPAYLOAD_LOG_DIR)/build.log +LIBPAYLOAD_INSTALL_LOG=$(LIBPAYLOAD_LOG_DIR)/install.log +LIBPAYLOAD_FETCH_LOG=$(LIBPAYLOAD_LOG_DIR)/fetch.log +endif + +ifeq ($(call custom-config-exists,libpayload), 1) +LIBPAYLOAD_CONFIG=$(call custom-config-name,libpayload) +else +ifeq ($(CONFIG_PLATFORM_GEODE),y) +LIBPAYLOAD_CONFIG=$(PACKAGE_DIR)/libpayload/conf/defconfig.geode +else +LIBPAYLOAD_CONFIG=$(PACKAGE_DIR)/libpayload/conf/defconfig +endif +endif + +LIBPAYLOAD_TARBALL=libpayload-svn-$(LIBPAYLOAD_TAG).tar.gz + +$(SOURCE_DIR)/$(LIBPAYLOAD_TARBALL): + @ mkdir -p $(SOURCE_DIR)/libpayload + @ $(BIN_DIR)/fetchsvn.sh $(LIBPAYLOAD_URL) $(SOURCE_DIR)/libpayload \ + $(LIBPAYLOAD_TAG) $(SOURCE_DIR)/$(LIBPAYLOAD_TARBALL) \ + > $(LIBPAYLOAD_FETCH_LOG) 2>&1 + +$(LIBPAYLOAD_STAMP_DIR)/.unpacked: $(SOURCE_DIR)/$(LIBPAYLOAD_TARBALL) | $(LIBPAYLOAD_STAMP_DIR) $(LIBPAYLOAD_DIR) + @ echo "Unpacking libpayload..." + @ tar -C $(LIBPAYLOAD_DIR) -zxf $(SOURCE_DIR)/$(LIBPAYLOAD_TARBALL) + @ touch $@ + +$(LIBPAYLOAD_SRC_DIR)/.config: $(LIBPAYLOAD_STAMP_DIR)/.unpacked + @ cp $(LIBPAYLOAD_CONFIG) $@ + @ make -C $(LIBPAYLOAD_SRC_DIR) oldconfig > $(LIBPAYLOAD_BUILD_LOG) 2>&1 + +$(LIBPAYLOAD_SRC_DIR)/lib/libpayload.a: $(LIBPAYLOAD_SRC_DIR)/.config + @ echo "Building libpayload..." +ifeq ($(findstring customconfig,$(LIBPAYLOAD_CONFIG)),customconfig) + @ echo "Using custom config $(LIBPAYLOAD_CONFIG)" +endif + @ make -C $(LIBPAYLOAD_SRC_DIR) > $(LIBPAYLOAD_BUILD_LOG) 2>&1 + @ mkdir -p $(OUTPUT_DIR)/config/libpayload + @ cp $(LIBPAYLOAD_SRC_DIR)/.config $(OUTPUT_DIR)/config/libpayload + +$(LIBPAYLOAD_STAMP_DIR)/.installed: $(LIBPAYLOAD_SRC_DIR)/lib/libpayload.a + @ echo "Installing libpayload..." + @ make -C $(LIBPAYLOAD_SRC_DIR) DESTDIR=$(STAGING_DIR) install \ + > $(LIBPAYLOAD_INSTALL_LOG) 2>&1 + @ touch $@ + +$(LIBPAYLOAD_STAMP_DIR) $(LIBPAYLOAD_LOG_DIR): + @ mkdir -p $@ + +libpayload: $(LIBPAYLOAD_STAMP_DIR) $(LIBPAYLOAD_LOG_DIR) $(LIBPAYLOAD_STAMP_DIR)/.installed + +libpayload-clean: + @ echo "Cleaning libpayload..." + @ $(MAKE) -C $(LIBPAYLOAD_SRC_DIR) clean > /dev/null 2>&1 + @ rm -f $(LIBPAYLOAD_STAMP_DIR)/.installed + +libpayload-distclean: + @ rm -rf $(LIBPAYLOAD_DIR)/* + +libpayload-extract: $(LIBPAYLOAD_STAMP_DIR)/.patched + +libpayload-config: | $(LIBPAYLOAD_SRC_DIR)/.config +ifeq ($(call custom-config-exists,libpayload), 1) + @ cp -f $(call custom-config-name,libpayload) $(LIBPAYLOAD_SRC_DIR)/.config +endif + @ echo "Configure libpayload..." + @ $(MAKE) -C $(LIBPAYLOAD_SRC_DIR) menuconfig + @ echo +ifeq ($(call custom-config-exists,libpayload),1) + @ echo "Found an existing custom configuration file:" + @ echo " $(call custom-config-name,libpayload)" + @ echo "I've copied it back to the source directory for modification." + @ echo "Remove the above file and re-run this command if you want to create a new customer configuration from scratch for this payload/board." + @ echo +endif + @ cp -f $(LIBPAYLOAD_SRC_DIR)/.config $(call custom-config-name,libpayload) + @ echo "Your custom config file has been saved as $(call custom-config-name,libpayload)." + @ echo +

1 0

[1/3] buildrom: Construct generic calls for custom config filename
by Jordan Crouse 11 Apr '08

11 Apr '08

Patch 1 of 3 to buildrom - this conslidates the custom config name creation behavior into a set of generic calls. Jordan

2 2

r3237 - in trunk/payloads/libpayload: curses drivers drivers/video i386 include libc
by svn＠coreboot.org 11 Apr '08

11 Apr '08

Author: uwe Date: 2008-04-11 22:16:24 +0200 (Fri, 11 Apr 2008) New Revision: 3237 Modified: trunk/payloads/libpayload/curses/local.h trunk/payloads/libpayload/drivers/keyboard.c trunk/payloads/libpayload/drivers/serial.c trunk/payloads/libpayload/drivers/video/geode.c trunk/payloads/libpayload/i386/coreboot.c trunk/payloads/libpayload/i386/sysinfo.c trunk/payloads/libpayload/include/libpayload.h trunk/payloads/libpayload/libc/printf.c Log: Drop unneeded #includes, add EXIT_SUCCESS/EXIT_FAILURE (trivial). Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/payloads/libpayload/curses/local.h =================================================================== --- trunk/payloads/libpayload/curses/local.h 2008-04-11 19:43:55 UTC (rev 3236) +++ trunk/payloads/libpayload/curses/local.h 2008-04-11 20:16:24 UTC (rev 3237) @@ -59,8 +59,6 @@ #undef USE_TERMLIB #include <libpayload.h> -#include <arch/types.h> -#include <arch/io.h> #include <curses.h> #include <curses.priv.h> @@ -86,9 +84,4 @@ /* Share the color table for easy lookup */ extern unsigned char color_pairs[256]; -/* speaker.c */ -void speaker_enable(u16 freq); -void speaker_disable(void); -void speaker_tone(u16 freq, unsigned int duration); - #endif Modified: trunk/payloads/libpayload/drivers/keyboard.c =================================================================== --- trunk/payloads/libpayload/drivers/keyboard.c 2008-04-11 19:43:55 UTC (rev 3236) +++ trunk/payloads/libpayload/drivers/keyboard.c 2008-04-11 20:16:24 UTC (rev 3237) @@ -27,7 +27,6 @@ * SUCH DAMAGE. */ -#include <arch/io.h> #include <libpayload.h> unsigned char map[2][0x57] = { Modified: trunk/payloads/libpayload/drivers/serial.c =================================================================== --- trunk/payloads/libpayload/drivers/serial.c 2008-04-11 19:43:55 UTC (rev 3236) +++ trunk/payloads/libpayload/drivers/serial.c 2008-04-11 20:16:24 UTC (rev 3237) @@ -28,7 +28,6 @@ */ #include <libpayload.h> -#include <sysinfo.h> #define IOBASE lib_sysinfo.ser_ioport Modified: trunk/payloads/libpayload/drivers/video/geode.c =================================================================== --- trunk/payloads/libpayload/drivers/video/geode.c 2008-04-11 19:43:55 UTC (rev 3236) +++ trunk/payloads/libpayload/drivers/video/geode.c 2008-04-11 20:16:24 UTC (rev 3237) @@ -30,9 +30,7 @@ #include <libpayload.h> #include <pci.h> #include <video_console.h> -#include <arch/io.h> #include <arch/msr.h> - #include "font8x16.h" /* This is the video mode that we're going to use for our VGA screen */ Modified: trunk/payloads/libpayload/i386/coreboot.c =================================================================== --- trunk/payloads/libpayload/i386/coreboot.c 2008-04-11 19:43:55 UTC (rev 3236) +++ trunk/payloads/libpayload/i386/coreboot.c 2008-04-11 20:16:24 UTC (rev 3237) @@ -28,7 +28,6 @@ */ #include <libpayload.h> -#include <sysinfo.h> #include <coreboot_tables.h> /* Modified: trunk/payloads/libpayload/i386/sysinfo.c =================================================================== --- trunk/payloads/libpayload/i386/sysinfo.c 2008-04-11 19:43:55 UTC (rev 3236) +++ trunk/payloads/libpayload/i386/sysinfo.c 2008-04-11 20:16:24 UTC (rev 3237) @@ -28,7 +28,6 @@ */ #include <libpayload.h> -#include <sysinfo.h> /** * This is a global structure that is used through the library - we set it Modified: trunk/payloads/libpayload/include/libpayload.h =================================================================== --- trunk/payloads/libpayload/include/libpayload.h 2008-04-11 19:43:55 UTC (rev 3236) +++ trunk/payloads/libpayload/include/libpayload.h 2008-04-11 20:16:24 UTC (rev 3237) @@ -49,6 +49,9 @@ #define BYTE_ORDER BIG_ENDIAN #endif +#define EXIT_SUCCESS 0 +#define EXIT_FAILURE 1 + #define RAND_MAX 0x7fffffff /* Some NVRAM byte definitions */ Modified: trunk/payloads/libpayload/libc/printf.c =================================================================== --- trunk/payloads/libpayload/libc/printf.c 2008-04-11 19:43:55 UTC (rev 3236) +++ trunk/payloads/libpayload/libc/printf.c 2008-04-11 20:16:24 UTC (rev 3237) @@ -34,7 +34,6 @@ */ #include <libpayload.h> -#include <stdarg.h> /** Structure for specifying output methods for different printf clones. */ struct printf_spec {

1 0

r142 - buildrom-devel/scripts
by svn＠coreboot.org 11 Apr '08

11 Apr '08

Author: jcrouse Date: 2008-04-11 22:14:30 +0200 (Fri, 11 Apr 2008) New Revision: 142 Modified: buildrom-devel/scripts/Build.settings Log: buildrom: Construct generic calls to figure out the custom config filename A set of custom generic calls that make it easier to construct a filename for a custom configuration Signed-off-by: Jordan Crouse <jordan.crouse(a)amd.com> Acked-by: Ward Vandewege <ward(a)gnu.org> Modified: buildrom-devel/scripts/Build.settings =================================================================== --- buildrom-devel/scripts/Build.settings 2008-04-05 04:28:24 UTC (rev 141) +++ buildrom-devel/scripts/Build.settings 2008-04-11 20:14:30 UTC (rev 142) @@ -81,3 +81,13 @@ PARALLEL_MAKE=-j$(CONFIG_MAKE_JOBS) export CC AS CFLAGS LDFLAGS ASFLAGS LIBS PARALLEL_MAKE + +# Several functions to get a custom config file name + +custom-get-arch = $(if $(CONFIG_TARGET_64BIT),x86_64,i386) + +custom-config-name = $(shell \ + echo "$(PACKAGE_DIR)/$(1)/conf/customconfig--$(PAYLOAD)--$(call custom-get-arch)--$(COREBOOT_VENDOR)--$(COREBOOT_BOARD)") + +custom-config-exists = $(shell if [ -f $(call custom-config-name,$(1)) ]; \ + then echo 1; fi)

1 0

← Newer
1
...
25
26
27
28
29
30
31
...
41
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot April 2008