coreboot November 2007

coreboot@coreboot.org

75 participants
397 discussions

[LinuxBIOS] Flashrom support for NVidia MCP51?
by Shocky 07 Dec '07

07 Dec '07

Now that I can build and run flashrom, I get: Calibrating delay loop.. OK. No LinuxBIOS table found. Found chipset "NVidia MCP51", enabling flash write... OK generic_spi_command called, but no SPI chipset detected No EEPROM/flash device found. I see on the supported devices list that NVidia MCP55 is supported, but mine is "?". Anything I can do to help get it supported? I don't know what type of flash chip I have, or for that matter what type of m/b. It's an HP Pavilion dv2412ca laptop. I haven't been able to figure out how to open the case to see what's inside (I took out all the swappable components, removed all visible screws on the bottom, and searched for hidden ones, but the case was still solidly locked in place; in fact it makes me wonder what all the screws were for 8^). Any advice on the next steps? Shocky -- These are my opinions. Get your own.

2 5

[LinuxBIOS] flashrom fails on GA-M57SLI with 1MB ROM
by Andreas B. Mundt 06 Dec '07

06 Dec '07

Hi all, today, I replaced the 512kB EEPROM on my GA-M57SLI by a 1024kB SST49LF080A chip. Flashing of a 1024kB BIOS (after booting with proprietary BIOS) works fine. After booting LB, writing with flashrom fails. (If you rewrite the same linuxbios.rom and use '--verify', anything looks ok, but if you write something 'new' on the ROM, the verification fails. Reading the ROM content and comparing it with the content written shows differences at the very end of the image.) So the issue that has been solved for the 512kB LPC recently seems to pop up again!? Regards, Andi

7 27

[LinuxBIOS] [PATCH] v3: duplicate less code
by Carl-Daniel Hailfinger 06 Dec '07

06 Dec '07

Hi, some time ago, we decided that stage2 should share code with stage0 whenever possible. I have investigated the current situation and we could do much better. Example analysis for the qemu target in its current revision follows: Shared functions/symbols: die gdt_limit gdtptr get_option_table post_code printk rtc_init sprintf Duplicated functions: size name 0000001a delay 0000001a mdelay 0000000e udelay 00000027 memcmp 0000000f memcpy 000000d6 memcpy_helper 00000021 memmove 00000013 memset 00000007 rawpnp_enter_ext_func_mode 00000006 rawpnp_exit_ext_func_mode 00000015 rawpnp_set_enable 00000029 rawpnp_set_iobase 00000012 rawpnp_set_logical_device 0000000e rawpnp_write_config We waste a total of 493 bytes. Patch for *delay and mem* functions follows, saving 386 bytes. Regards, Carl-Daniel To reduce code duplication, make sure STAGE2_*OBJ does not contain any object already mentioned in STAGE0_*_OBJ. Specifically, remove mem.o, delay.o, udelay_io.o from STAGE2_*OBJ. This saves 386 bytes in stage2 (~240 bytes after LZMA compression). In the future, automatically removing objects from STAGE2_OBJ which are already included in STAGE0_OBJ will be the way to go. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> --- Index: LinuxBIOSv3/arch/x86/Makefile =================================================================== --- LinuxBIOSv3/arch/x86/Makefile (revision 512) +++ LinuxBIOSv3/arch/x86/Makefile (working copy) @@ -167,11 +167,13 @@ # Where should it be built, maybe in device/? # # TODO: This should be compressed with the default compressor. +# To reduce code duplication, always make sure STAGE2_LIB_OBJ does not contain +# any object already mentioned in STAGE0_LIB_OBJ. # -STAGE2_LIB_OBJ = stage2.o clog2.o mem.o tables.o delay.o compute_ip_checksum.o +STAGE2_LIB_OBJ = stage2.o clog2.o tables.o compute_ip_checksum.o -STAGE2_ARCH_X86_OBJ = archtables.o linuxbios_table.o udelay_io.o +STAGE2_ARCH_X86_OBJ = archtables.o linuxbios_table.o STAGE2_ARCH_X86_OBJ += pci_ops_auto.o pci_ops_conf1.o pci_ops_conf2.o STAGE2_ARCH_X86_OBJ += keyboard.o i8259.o isa-dma.o

3 7

[LinuxBIOS] State of the buildrom
by Jordan Crouse 05 Dec '07

05 Dec '07

We've been doing a lot of hacking on buildrom lately. Thanks to everybody, especially Ward and Myles. I wanted to take some time to discuss where we are and particularly where we want to go. Here is where we are: * v2 support for 10 platforms (alix1c, db800, dbe61, ga-2761gxdk, m57sli, msm800sev, norwich, serengeti_cheetah, tyan-s2882 and tyan-s2891). * 5 payloads supported (etherboot, filo, kernel, LAB, memtest). Also, you can plug in a custom ELF if you see fit. Thats fun, but its more interesting to talk about what we still have left to do: * v3 support: This is probably the most useful extension we can do in the near term - not only does it serve our v3 hackers, but it also will force us to review some of the buildrom internals (in particular, I am worried about the state of the packages/linuxbios directory). * OFW: We need to return OFW to working. * gPXE: Ward is taking the lead on this * grub2: Another payload we desperately need to get into buildrom - any volunteers? * New platforms: New platforms always seem to introduce new wrinkles that we haven't thought about. In particular, the VIA platforms are pretty popular, so it would be nice to get support for them. * buildroot/firmware_linux/etc: I'm still interested in partnering with other build systems in an effort to better scale support for LAB payloads. * Optimizations: There are always things we can do to clean up - add -j N support for make, reduce memory usage, avoid stupid gmake tricks and the like. I think things are stable enough in the core that we can start to twist some knobs without blowing everything up. What does everybody else think? What have I missed? Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc.

10 23

[LinuxBIOS] Abit KN9 Ultra - output of 'lspci -tvnn', 'superiotool -dV' and 'flashrom -V'
by Dawn Light 04 Dec '07

04 Dec '07

-[0000:00]-+-00.0 nVidia Corporation MCP55 Memory Controller [10de:0369] +-01.0 nVidia Corporation MCP55 LPC Bridge [10de:0362] +-01.1 nVidia Corporation MCP55 SMBus [10de:0368] +-02.0 nVidia Corporation MCP55 USB Controller [10de:036c] +-02.1 nVidia Corporation MCP55 USB Controller [10de:036d] +-04.0 nVidia Corporation MCP55 IDE [10de:036e] +-05.0 nVidia Corporation MCP55 SATA Controller [10de:037f] +-05.1 nVidia Corporation MCP55 SATA Controller [10de:037f] +-05.2 nVidia Corporation MCP55 SATA Controller [10de:037f] +-06.0-[0000:01]----08.0 Texas Instruments TSB43AB22/A IEEE-1394a-2000 Controller (PHY/Link) [104c:8023] +-06.1 nVidia Corporation MCP55 High Definition Audio [10de:0371] +-08.0 nVidia Corporation MCP55 Ethernet [10de:0373] +-09.0 nVidia Corporation MCP55 Ethernet [10de:0373] +-0c.0-[0000:02]-- +-0d.0-[0000:03]-- +-0e.0-[0000:04]-- +-0f.0-[0000:05]----00.0 nVidia Corporation G70 [GeForce 7600 GT] [10de:0391] +-18.0 Advanced Micro Devices [AMD] K8 [Athlon64/Opteron] HyperTransport Technology Configuration [1022:1100] +-18.1 Advanced Micro Devices [AMD] K8 [Athlon64/Opteron] Address Map [1022:1101] +-18.2 Advanced Micro Devices [AMD] K8 [Athlon64/Opteron] DRAM Controller [1022:1102] \-18.3 Advanced Micro Devices [AMD] K8 [Athlon64/Opteron] Miscellaneous Control [1022:1103] ########################## superiotool r2922 Probing for ALi Super I/O at 0x3f0... Failed. Returned data: id=0xffff, rev=0xff Probing for ALi Super I/O at 0x370... Failed. Returned data: id=0xffff, rev=0xff Probing for Fintek Super I/O at 0x2e... Failed. Returned data: vid=0x8400, id=0x6388 Probing for Fintek Super I/O at 0x4e... Failed. Returned data: vid=0xffff, id=0xffff Probing for ITE Super I/O (init=0x87,0x01,0x55,0x55/0xaa) at 0x2e... Failed. Returned data: id=0xffff, rev=0xf Probing for ITE Super I/O (init=0x87,0x87) at 0x2e... Failed. Returned data: id=0x8863, rev=0xf Probing for ITE Super I/O (init=0x87,0x01,0x55,0x55/0xaa) at 0x4e... Failed. Returned data: id=0xffff, rev=0xf Probing for ITE Super I/O (init=0x87,0x87) at 0x4e... Failed. Returned data: id=0xffff, rev=0xf Probing for NSC Super I/O at 0x2e... Failed. Returned data: port=0xff, port+1=0xff Probing for NSC Super I/O at 0x4e... Failed. Returned data: port=0xff, port+1=0xff Probing for SMSC Super I/O (idregs=0x20/0x21) at 0x2e... Failed. Returned data: id=0xff, rev=0xff Probing for SMSC Super I/O (idregs=0x0d/0x0e) at 0x2e... Failed. Returned data: id=0xff, rev=0xff Probing for SMSC Super I/O (idregs=0x20/0x21) at 0x4e... Failed. Returned data: id=0xff, rev=0xff Probing for SMSC Super I/O (idregs=0x0d/0x0e) at 0x4e... Failed. Returned data: id=0xff, rev=0xff Probing for SMSC Super I/O (idregs=0x20/0x21) at 0x162e... Failed. Returned data: id=0xff, rev=0xff Probing for SMSC Super I/O (idregs=0x0d/0x0e) at 0x162e... Failed. Returned data: id=0xff, rev=0xff Probing for SMSC Super I/O (idregs=0x20/0x21) at 0x164e... Failed. Returned data: id=0xff, rev=0xff Probing for SMSC Super I/O (idregs=0x0d/0x0e) at 0x164e... Failed. Returned data: id=0xff, rev=0xff Probing for SMSC Super I/O (idregs=0x20/0x21) at 0x3f0... Failed. Returned data: id=0xff, rev=0xff Probing for SMSC Super I/O (idregs=0x0d/0x0e) at 0x3f0... Failed. Returned data: id=0xff, rev=0xff Probing for SMSC Super I/O (idregs=0x20/0x21) at 0x370... Failed. Returned data: id=0xff, rev=0xff Probing for SMSC Super I/O (idregs=0x0d/0x0e) at 0x370... Failed. Returned data: id=0xff, rev=0xff Probing for Winbond Super I/O (init=0x88) at 0x2e... Failed. Returned data: id/oldid=0xff/0x0f, rev=0xff Probing for Winbond Super I/O (init=0x89) at 0x2e... Failed. Returned data: id/oldid=0xff/0x0f, rev=0xff Probing for Winbond Super I/O (init=0x86,0x86) at 0x2e... Failed. Returned data: id/oldid=0xff/0x0f, rev=0xff Probing for Winbond Super I/O (init=0x87,0x87) at 0x2e... Found Winbond W83627EHF/EF/EHG/EG (id=0x88, rev=0x63) at 0x2e Register dump: idx 20 21 22 23 24 25 26 27 28 29 2a 2b 2c 2d 2e 2f val 88 63 ff 00 84 00 00 ff 50 00 7c c0 08 01 00 ff def 88 MM ff 00 MM 00 MM RR 50 04 00 RR 00 21 00 00 LDN 0x00 (Floppy) idx 30 60 61 70 74 f0 f1 f2 f4 f5 val 01 03 f0 06 02 0e 00 ff 00 00 def 01 03 f0 06 02 8e 00 ff 00 00 LDN 0x01 (Parallel port) idx 30 60 61 70 74 f0 val 00 00 00 00 04 38 def 01 03 78 07 04 3f LDN 0x02 (COM1) idx 30 60 61 70 f0 val 00 00 00 00 00 def 01 03 f8 04 00 LDN 0x03 (COM2) idx 30 60 61 70 f0 f1 val 00 00 00 00 00 00 def 01 02 f8 03 00 00 LDN 0x05 (Keyboard) idx 30 60 61 62 63 70 72 f0 val 01 00 60 00 64 01 0c 80 def 01 00 60 00 64 01 0c 83 LDN 0x06 (Serial flash interface) idx 30 62 63 val 00 ff ff def 00 00 00 LDN 0x07 (GPIO 1, GPIO 6, game port, MIDI port) idx 30 60 61 62 63 70 f0 f1 f2 f3 f4 f5 f6 f7 val 01 00 00 00 00 00 fd 00 00 02 ff ff ff 00 def 00 02 01 03 30 09 ff 00 00 00 ff 00 00 00 LDN 0x08 (WDTO#, PLED) idx 30 f5 f6 f7 val 00 ff 00 ff def 00 00 00 00 LDN 0x09 (GPIO 2, GPIO 3, GPIO 4, GPIO 5, SUSLED) idx 30 e0 e1 e2 e3 e4 e5 f0 f1 f2 f3 f4 f5 f6 f7 val 00 ff ff ff ff ff ff ff ff ff 00 ff ff ff ff def 00 ff 00 00 ff 00 00 ff 00 00 00 ff 00 00 00 LDN 0x0a (ACPI) idx 30 70 e0 e1 e2 e3 e4 e5 e6 e7 e8 f2 f3 f4 f6 f7 val 00 00 00 00 c0 00 00 00 0c 00 09 7c 00 00 00 00 def 00 00 01 00 ff 08 00 RR 00 00 RR 7c 00 00 00 00 LDN 0x0b (Hardware monitor) idx 30 60 61 70 f0 f1 val 01 02 90 00 c1 3f def 00 00 00 00 c1 00 Probing for Winbond Super I/O (init=0x88) at 0x4e... Failed. Returned data: id/oldid=0xff/0x0f, rev=0xff Probing for Winbond Super I/O (init=0x89) at 0x4e... Failed. Returned data: id/oldid=0xff/0x0f, rev=0xff Probing for Winbond Super I/O (init=0x86,0x86) at 0x4e... Failed. Returned data: id/oldid=0xff/0x0f, rev=0xff Probing for Winbond Super I/O (init=0x87,0x87) at 0x4e... Failed. Returned data: id/oldid=0xff/0x0f, rev=0xff Probing for Winbond Super I/O (init=0x88) at 0x3f0... Failed. Returned data: id/oldid=0xff/0x0f, rev=0xff Probing for Winbond Super I/O (init=0x89) at 0x3f0... Failed. Returned data: id/oldid=0xff/0x0f, rev=0xff Probing for Winbond Super I/O (init=0x86,0x86) at 0x3f0... Failed. Returned data: id/oldid=0xff/0x0f, rev=0xff Probing for Winbond Super I/O (init=0x87,0x87) at 0x3f0... Failed. Returned data: id/oldid=0xff/0x0f, rev=0xff Probing for Winbond Super I/O (init=0x88) at 0x370... Failed. Returned data: id/oldid=0xff/0x0f, rev=0xff Probing for Winbond Super I/O (init=0x89) at 0x370... Failed. Returned data: id/oldid=0xff/0x0f, rev=0xff Probing for Winbond Super I/O (init=0x86,0x86) at 0x370... Failed. Returned data: id/oldid=0xff/0x0f, rev=0xff Probing for Winbond Super I/O (init=0x87,0x87) at 0x370... Failed. Returned data: id/oldid=0xff/0x0f, rev=0xff Probing for Winbond Super I/O (init=0x88) at 0x250... Failed. Returned data: id/oldid=0xff/0x0f, rev=0xff Probing for Winbond Super I/O (init=0x89) at 0x250... Failed. Returned data: id/oldid=0xff/0x0f, rev=0xff Probing for Winbond Super I/O (init=0x86,0x86) at 0x250... Failed. Returned data: id/oldid=0xff/0x0f, rev=0xff Probing for Winbond Super I/O (init=0x87,0x87) at 0x250... Failed. Returned data: id/oldid=0xff/0x0f, rev=0xff ########################## Calibrating delay loop... 758M loops per second. OK. No LinuxBIOS table found. Found chipset "NVIDIA MCP55", enabling flash write... OK. Probing for Am29F040B, 512 KB probe_29f040b: id1 0x49, id2 0x4d Probing for Am29LV040B, 512 KB probe_29f040b: id1 0x49, id2 0x4d Probing for Am29F016D, 2048 KB probe_29f040b: id1 0xff, id2 0xff Probing for AE49F2008, 256 KB probe_jedec: id1 0x9d, id2 0x6e Probing for At29C040A, 512 KB probe_jedec: id1 0x9d, id2 0x6e Probing for At29C020, 256 KB probe_jedec: id1 0x9d, id2 0x6e Probing for MBM29F400TC, 512 KB probe_m29f400bt: id1 0x49, id2 0x44 Probing for MX29F002, 256 KB probe_29f002: id1 0x9d, id2 0x6e Probing for MX25L4005, 512 KB generic_spi_command called, but no SPI chipset detected Probing for SST29EE020A, 256 KB probe_jedec: id1 0x9d, id2 0x6e Probing for SST28SF040A, 512 KB probe_28sf040: id1 0x49, id2 0x4d Probing for SST39SF010A, 128 KB probe_jedec: id1 0x9d, id2 0x6e Probing for SST39SF020A, 256 KB probe_jedec: id1 0x9d, id2 0x6e Probing for SST39SF040, 512 KB probe_jedec: id1 0x9d, id2 0x6e Probing for SST39VF020, 256 KB probe_jedec: id1 0x9d, id2 0x6e Probing for SST49LF040B, 512 KB probe_jedec: id1 0x9d, id2 0x6e Probing for SST49LF040, 512 KB probe_jedec: id1 0x9d, id2 0x6e Probing for SST49LF020A, 256 KB probe_jedec: id1 0x9d, id2 0x6e Probing for SST49LF080A, 1024 KB probe_jedec: id1 0xff, id2 0xff Probing for SST49LF002A/B, 256 KB probe_jedec: id1 0x9d, id2 0x6e Probing for SST49LF003A/B, 384 KB probe_jedec: id1 0x9d, id2 0x6e Probing for SST49LF004A/B, 512 KB probe_jedec: id1 0x9d, id2 0x6e Probing for SST49LF008A, 1024 KB probe_jedec: id1 0xff, id2 0xff Probing for SST49LF004C, 512 KB probe_49lfxxxc: id1 0x49, id2 0x4d Probing for SST49LF008C, 1024 KB probe_49lfxxxc: id1 0xff, id2 0xff Probing for SST49LF016C, 2048 KB probe_49lfxxxc: id1 0xff, id2 0xff Probing for SST49LF160C, 2048 KB probe_49lfxxxc: id1 0xff, id2 0xff Probing for Pm49FL002, 256 KB probe_jedec: id1 0x9d, id2 0x6e Probing for Pm49FL004, 512 KB probe_jedec: id1 0x9d, id2 0x6e Pm49FL004 found at physical address 0xfff80000. Flash part is Pm49FL004 (512 KB). No operations were specified. -- Dawn Light שחר אור 050-7966664

2 2

[LinuxBIOS] [PATCH] v3: reorder rules in mainboard/*/*/Makefile
by Carl-Daniel Hailfinger 04 Dec '07

04 Dec '07

Reorder the rules in mainboard/*/*/Makefile so their order is identical across all of these makefiles. The rules are now in order of execution during boot, that is: STAGE0_MAINBOARD_OBJ INITRAM_OBJ STAGE2_MAINBOARD_OBJ As added benefit, mainboard makefiles are now almost identical. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: LinuxBIOSv3-filteroutduplicatedshared/mainboard/adl/msm800sev/Makefile =================================================================== --- LinuxBIOSv3-filteroutduplicatedshared/mainboard/adl/msm800sev/Makefile (Revision 529) +++ LinuxBIOSv3-filteroutduplicatedshared/mainboard/adl/msm800sev/Makefile (Arbeitskopie) @@ -21,14 +21,14 @@ STAGE0_MAINBOARD_OBJ := $(obj)/mainboard/$(MAINBOARDDIR)/stage1.o +INITRAM_OBJ = $(obj)/mainboard/$(MAINBOARDDIR)/initram.o \ + $(obj)/northbridge/amd/geodelx/raminit.o \ + $(obj)/southbridge/amd/cs5536/smbus_initram.o \ + $(obj)/arch/x86/geodelx/geodelx.o + STAGE2_MAINBOARD_OBJ = $(obj)/linuxbios.vpd: $(Q)printf " BUILD DUMMY VPD\n" $(Q)dd if=/dev/zero of=$(obj)/linuxbios.vpd bs=256 count=1 $(SILENT) -INITRAM_OBJ = $(obj)/mainboard/$(MAINBOARDDIR)/initram.o \ - $(obj)/northbridge/amd/geodelx/raminit.o \ - $(obj)/southbridge/amd/cs5536/smbus_initram.o \ - $(obj)/arch/x86/geodelx/geodelx.o - Index: LinuxBIOSv3-filteroutduplicatedshared/mainboard/artecgroup/dbe61/Makefile =================================================================== --- LinuxBIOSv3-filteroutduplicatedshared/mainboard/artecgroup/dbe61/Makefile (Revision 529) +++ LinuxBIOSv3-filteroutduplicatedshared/mainboard/artecgroup/dbe61/Makefile (Arbeitskopie) @@ -21,12 +21,12 @@ STAGE0_MAINBOARD_OBJ := $(obj)/mainboard/$(MAINBOARDDIR)/stage1.o +INITRAM_OBJ = $(obj)/mainboard/$(MAINBOARDDIR)/initram.o \ + $(obj)/arch/x86/geodelx/geodelx.o + STAGE2_MAINBOARD_OBJ = $(obj)/linuxbios.vpd: $(Q)printf " BUILD DUMMY VPD\n" $(Q)dd if=/dev/zero of=$(obj)/linuxbios.vpd bs=256 count=1 $(SILENT) -INITRAM_OBJ = $(obj)/mainboard/$(MAINBOARDDIR)/initram.o \ - $(obj)/arch/x86/geodelx/geodelx.o - Index: LinuxBIOSv3-filteroutduplicatedshared/mainboard/emulation/qemu-x86/Makefile =================================================================== --- LinuxBIOSv3-filteroutduplicatedshared/mainboard/emulation/qemu-x86/Makefile (Revision 529) +++ LinuxBIOSv3-filteroutduplicatedshared/mainboard/emulation/qemu-x86/Makefile (Arbeitskopie) @@ -21,6 +21,15 @@ STAGE0_MAINBOARD_OBJ := $(obj)/mainboard/$(MAINBOARDDIR)/stage1.o +# +# This is going to be the init RAM code. +# +# The initram file is always uncompressed. It belongs into the mainboard +# directory and is built from what was auto.c in v2. +# + +INITRAM_OBJ = $(obj)/mainboard/$(MAINBOARDDIR)/initram.o + STAGE2_MAINBOARD_OBJ = vga.o # @@ -33,12 +42,3 @@ $(Q)printf " BUILD DUMMY VPD\n" $(Q)dd if=/dev/zero of=$(obj)/linuxbios.vpd bs=256 count=1 $(SILENT) -# -# This is going to be the init RAM code. -# -# The initram file is always uncompressed. It belongs into the mainboard -# directory and is built from what was auto.c in v2. -# - -INITRAM_OBJ = $(obj)/mainboard/$(MAINBOARDDIR)/initram.o -

2 8

[LinuxBIOS] Infamous __stack_chk_fail problem.
by Steve Isaacs 03 Dec '07

03 Dec '07

When attempting to use buildrom I'm seeing the " undefined reference to `__stack_chk_fail'" message. I see that this was a topic of discussion back in January but haven't found anything to say how or if this was resolved. At the risk of scratching an old itch I have to ask if this was resolved or if a solution to the problem is still needed. I'm building on Ubuntu 6.10 which installs a gcc configured for stack checking. I know about the -fno-stack-protector option when compiling and have used this as a work-around but I'm thinking that if this was/is a problem then other host distro dependent issues perhaps will or still be lurking to catch someone. Is it a viable solution to have buildrom build a cross-tool chain? Imho: This would be best in order to have repeatable results. Having config options to control the gcc and binutils versions cross-host build repeatability would be improved. Steve

5 18

[LinuxBIOS] [PATCH] Improved Intel 82371EB (and others) support
by Uwe Hermann 03 Dec '07

03 Dec '07

See patch. This is required to make all 440BX based boards in v2 almost fully supported. Without the patch at least the Super I/O init is never performed, thus lots of stuff is broken. Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

3 5

[LinuxBIOS] [PATCH] v3: Crash with a descriptive message in case of compiler bugs
by Carl-Daniel Hailfinger 03 Dec '07

03 Dec '07

Ron mentioned he had strange hangs in pll_reset on various targets. This may be due to miscompilation of XIP objects which do not have _MAINBOBJECT defined. This issue was impossible to see on qemu because no such object existed. Introduce initram_printktest.c in the Qemu target, which will test for miscompilation and crash with a descriptive error message. This has been build tested and runtime tested on Qemu, and with my compiler/linker combination it indeed crashes. gcc (GCC) 4.2.1 (SUSE Linux) GNU ld (GNU Binutils) 2.17.50.20070726-14 (SUSE Linux) Trying with gcc-4.1 (GCC) 4.1.3 20070724 (prerelease) (SUSE Linux) and the linker above had exactly the same results. Unless we manage to fix the bug uncovered by this patch, leaving the Qemu target in crashing state is the best thing we can do because this behaviour mirrors the state of all other targets. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> (don't forget "svn add ainboard/emulation/qemu-x86/initram_printktest.c" if you commit) Index: LinuxBIOSv3-xiptest/mainboard/emulation/qemu-x86/initram.c =================================================================== --- LinuxBIOSv3-xiptest/mainboard/emulation/qemu-x86/initram.c (Revision 532) +++ LinuxBIOSv3-xiptest/mainboard/emulation/qemu-x86/initram.c (Arbeitskopie) @@ -2,6 +2,7 @@ * This file is part of the LinuxBIOS project. * * Copyright (C) 2007 Stefan Reinauer <stepan(a)coresystems.de> + * Copyright (C) 2007 Carl-Daniel Hailfinger * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -21,6 +22,8 @@ #include <console.h> +int printktest(void); + /* printktest1() is here to increase the likelihood of main() not ending up at * the beginning of the file, so we can check whether the entry point at main() * was honored. @@ -39,6 +42,9 @@ printk(BIOS_INFO, "RAM init code started.\n"); printk(BIOS_INFO, "Nothing to do.\n"); printktest1(); + printk(BIOS_INFO, "Trying absolute call from non-_MAINOBJECT XIP code.\n"); + printktest(); + printk(BIOS_INFO, "Done.\n"); return 0; } Index: LinuxBIOSv3-xiptest/mainboard/emulation/qemu-x86/initram_printktest.c =================================================================== --- LinuxBIOSv3-xiptest/mainboard/emulation/qemu-x86/initram_printktest.c (Revision 0) +++ LinuxBIOSv3-xiptest/mainboard/emulation/qemu-x86/initram_printktest.c (Revision 0) @@ -0,0 +1,31 @@ +/* + * This file is part of the LinuxBIOS project. + * + * Copyright (C) 2007 Carl-Daniel Hailfinger + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#include <console.h> + +int printktest(void) +{ + /* If printk succeeds, it will print the message below. This is not a + * success message after a test, but a success message used as test. + * In case of compiler/linker bugs the printk call is likely to crash. + */ + printk(BIOS_INFO, "Absolute call successful.\n"); + + return 0; +} Index: LinuxBIOSv3-xiptest/mainboard/emulation/qemu-x86/Makefile =================================================================== --- LinuxBIOSv3-xiptest/mainboard/emulation/qemu-x86/Makefile (Revision 532) +++ LinuxBIOSv3-xiptest/mainboard/emulation/qemu-x86/Makefile (Arbeitskopie) @@ -40,5 +40,6 @@ # directory and is built from what was auto.c in v2. # -INITRAM_OBJ = $(obj)/mainboard/$(MAINBOARDDIR)/initram.o +INITRAM_OBJ = $(obj)/mainboard/$(MAINBOARDDIR)/initram.o \ + $(obj)/mainboard/$(MAINBOARDDIR)/initram_printktest.o

3 6

[LinuxBIOS] [PATCH] v3: Refactoring, northbridgelib.c
by Uwe Hermann 03 Dec '07

03 Dec '07

See patch. Factor out common code. In v2 98% of all northbridges do exactly the same thing (in these functions), thus refactor. It's easy to override the common functions if a northbridge needs slightly different ones (I think K8 will, for example). Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

2 3

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot November 2007