Re: [coreboot] patch: resource map proposal.

[Peter Stuge]

On Mon, Aug 04, 2008 at 09:01:20AM -0700, ron minnich wrote:
> This is a possible mod to change the way resource maps are done.
>
> Unify the big mess into a little mess. 
> This code has all the functionality of the 4 or 5 rmap functions from v2 ..

Awesome. But..
> +void setup_resource_map_x_offset(const rmap *rm, u32 max,
>                             u32 offset_dev, u32 offset_pciio, 
>                             u32 offset_io)
>
> +{
> u32 i;
> printk(BIOS_DEBUG, "setting up resource map ex offset....\n");
> for(i = 0; i < max; i++, rm++) {
>      switch (rm->type){
> case PCIRM: 
> 	{
>                      u32 dev;
>                      unsigned where;
>                      unsigned long reg;
> 	  printk(BIOS_DEBUG, "(%x,%x+%x,%x,%x) & %08x | %08x+%08x\n", r->pcm.bus,r->pcm.dev+offset_dev,
>                             r->pcm.fn,r->pcm.reg,
> 		 r->pcm.and,r->pcm.or, offset_pciio);

This will not build. r is undeclared. :) When fixed,

Acked-by: Peter Stuge

//Peter