Re: [coreboot] [PATCH]more kconfig

[Peter Stuge]

Patrick Georgi wrote:
> +++ src/mainboard/gigabyte/ga_2761gxdk/Kconfig	(Revision 0)
> @@ -0,0 +1,148 @@
> +config BOARD_GIGABYTE_GA_2761GXDK
> bool "GA-2761GXDK"
> select ARCH_X86
> select CPU_AMD_K8
> select CPU_AMD_SOCKET_AM2
> select NORTHBRIDGE_AMD_AMDK8
> select NORTHBRIDGE_AMD_AMDK8_ROOT_COMPLEX
> select SOUTHBRIDGE_SIS_SIS966
> select SUPERIO_ITE_IT8716F

..
> +config MAX_CPUS
> int
> default 2
> depends on BOARD_GIGABYTE_GA_2761GXDK
>
> +config MAX_PHYSICAL_CPUS
> int
> default 1
> depends on BOARD_GIGABYTE_GA_2761GXDK

Does it make sense to set these CPU options in socket Kconfigs?
> +++ src/mainboard/rca/rm4100/Makefile.inc	(Revision 0)
> @@ -0,0 +1,4 @@
> +ROMCCFLAGS=-mcpu=p3 -O

..
> +++ src/mainboard/iei/nova4899r/Makefile.inc	(Arbeitskopie)
> @@ -18,6 +18,6 @@
>  ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
>  ##
>
> -ROMCCFLAGS := -mcpu=i386
> +ROMCCFLAGS := -mcpu=i386 -O2

The same question for -mcpu in ROMCCFLAGS? Couldn't that also be set
in socket Kconfigs?

//Peter