Re: [coreboot] [PATCH] Improve coreboot build output and eliminate some warnings

[Myles Watson]

On Tue, Oct 27, 2009 at 1:40 PM, Uwe Hermann  wrote:
> Build-tested on ASUS P2B-F where 80% of the warnings are now gone.

Great.

Index: src/arch/i386/boot/gdt.c
===================================================================
--- src/arch/i386/boot/gdt.c    (Revision 4873)
+++ src/arch/i386/boot/gdt.c    (Arbeitskopie)
@@ -47,11 +47,11 @@
             printk(BIOS_ERR, "Error: Could not relocate GDT.\n");
             return;
         }
-        printk_debug("Moving GDT to %#lx...", newgdt);
+        printk_debug("Moving GDT to %#lx...", (long unsigned int)newgdt);
I'd prefer just using %p since it's a pointer.

The pci_check_direct stuff needs to disappear, so it might be better to have
a warning there until it does, but I'm not picky about that either way.

With the %p:
Acked-by: Myles Watosn

Thanks,
Myles