On 25.08.2008 17:06, Ed Swierk wrote:
On Wed, Aug 20, 2008 at 1:41 PM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
A few comments about this one:
Index: coreboot-v2-3363/src/include/device/pci_ids.h
--- coreboot-v2-3363.orig/src/include/device/pci_ids.h +++ coreboot-v2-3363/src/include/device/pci_ids.h @@ -2354,6 +2354,17 @@ #define PCI_DEVICE_ID_INTEL_3100_PCIE_PA 0x35b6 #define PCI_DEVICE_ID_INTEL_3100_PCIE_PA1 0x35b7
+/* Intel EP80579 */ +#define PCI_DEVICE_ID_INTEL_EP80579_LPC 0x5031 +#define PCI_DEVICE_ID_INTEL_EP80579_EHCI 0x5035 +#define PCI_DEVICE_ID_INTEL_EP80579_SATA 0x5028
Call this one ..._SATA_IDE or ..._SATA_COMPAT?
+#define PCI_DEVICE_ID_INTEL_EP80579_SATA_R 0x5029
..._SATA_AHCI?
+#define PCI_DEVICE_ID_INTEL_EP80579_USB 0x5033
..._UHCI instead?
+#define PCI_DEVICE_ID_INTEL_EP80579_SMB 0x5032 +#define PCI_DEVICE_ID_INTEL_EP80579_MC 0x5020 +#define PCI_DEVICE_ID_INTEL_EP80579_PCIE_PA 0x5024
.._PA0?
+#define PCI_DEVICE_ID_INTEL_EP80579_PCIE_PA1 0x5025
#define PCI_DEVICE_ID_INTEL_80310 0x530d #define PCI_DEVICE_ID_INTEL_82810_MC1 0x7120 #define PCI_DEVICE_ID_INTEL_82810_IG1 0x7121
OK, I've made these changes to both the EP80579 and 3100 macros for consistency; see below.
Thanks! Looks fine, please take my Ack and commit. Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Regards, Carl-Daniel