Sven Schnelle (svens@stackframe.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/334
-gerrit
commit 0139e6e1c0527c0be622e92f596a3b159ecde2e2 Author: Sven Schnelle svens@stackframe.org Date: Tue Oct 25 15:29:47 2011 +0200
Lenovo H8: Fix h8_set_audio_mute()
Logic is inverted (if argument is true, one would expect that mute is enabled) and the wrong bit was used (1 instead 0)
Change-Id: I71133ba639f1fb0d3c3582f16211dd266a11cc64 Signed-off-by: Sven Schnelle svens@stackframe.org --- src/ec/lenovo/h8/h8.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c index 560c39c..f81a39c 100644 --- a/src/ec/lenovo/h8/h8.c +++ b/src/ec/lenovo/h8/h8.c @@ -63,12 +63,12 @@ static void h8_log_ec_version(void) fwvh >> 4, fwvh & 0x0f, fwvl >> 4, 0x41 + (fwvl & 0xf)); }
-void h8_set_audio_mute(int on) +void h8_set_audio_mute(int mute) { - if (on) - ec_clr_bit(0x3a, 0); + if (mute) + ec_set_bit(0x3a, 0); else - ec_set_bit(0x3a, 1); + ec_clr_bit(0x3a, 0); }
void h8_enable_event(int event)