Re: [coreboot] [PATCHes]more kconfig stuff

[Peter Stuge]

Patrick Georgi wrote:
> +++ src/mainboard/msi/ms7135/Kconfig	(Revision 0)
> @@ -0,0 +1,137 @@
> +config BOARD_MSI_MS7135
> bool "MS7135"

Do these board names have a dash? "MS-7135" ?
> +config MAINBOARD_DIR
> string
> default msi/ms7135
> depends on BOARD_MSI_MS7135

This is really sad. The directory name is already known, it's the one
where this Kconfig file is stored. It would be nice to just generate
this rather than risk humans introducing errors.
(And, the value might need quotes.)
> +++ src/mainboard/msi/ms9185/Kconfig	(Revision 0)
> @@ -0,0 +1,123 @@
> +config BOARD_MSI_MS9185
> bool "MS9185"

..
> +config MAINBOARD_PART_NUMBER
> string
> default "ultra40"
> depends on BOARD_MSI_MS9185

Oops.

Acked-by: Peter Stuge