Dear Idwer,
Am Dienstag, den 08.11.2011, 03:23 +0100 schrieb Idwer Vollering:
Idwer Vollering (vidwer@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/415
-gerrit
commit 897a07d55541bec5336b67789cfc155c31053d41 Author: Idwer Vollering vidwer@gmail.com Date: Mon Nov 7 17:48:33 2011 +0100
Refactor src/southbridge/intel/i82801ex/ Change-Id: I8be22f0292e322562b117f1e8bf493ed25eb4bec Signed-off-by: Idwer Vollering <vidwer@gmail.com>
src/southbridge/intel/i82801ex/chip.h | 1 - src/southbridge/intel/i82801ex/early_smbus.c | 32 ++++++++------ src/southbridge/intel/i82801ex/ehci.c | 8 ++- src/southbridge/intel/i82801ex/i82801ex.c | 12 +++--- src/southbridge/intel/i82801ex/i82801ex.h | 26 +++++++++--- src/southbridge/intel/i82801ex/ide.c | 15 +++---- src/southbridge/intel/i82801ex/lpc.c | 59 +++++++++++++------------- src/southbridge/intel/i82801ex/pci.c | 20 +++++---- src/southbridge/intel/i82801ex/sata.c | 35 +++++++++------- src/southbridge/intel/i82801ex/smbus.c | 3 +- src/southbridge/intel/i82801ex/smbus.h | 6 ++- src/southbridge/intel/i82801ex/uhci.c | 1 - src/southbridge/intel/i82801ex/watchdog.c | 10 +++-- src/superio/winbond/w83627thg/early_serial.c | 11 +++++ src/superio/winbond/w83627thg/w83627thg.h | 2 + 15 files changed, 141 insertions(+), 100 deletions(-)
that new diff looks rather large. Especially in comparison with the former patch iteration. The w83627thg changes could also go in as a separate patch?
What is the objective of the refactoring? To more conform with other targets?
[…]
Thanks,
Paul