Re: [coreboot] [patch][v2] AMD Fam10 HT BUID setup

[Carl-Daniel Hailfinger]

On 17.07.2008 00:10, Marc Jones wrote:
> This fixes a non-coherent link speed setting.
>
> Add manual HT BUID fixup to detect previously set BUIDs in early init. This
> fixes the coherent link running at default speed.
>
> Fix HT event notify to output useful information.
>
> Signed-off-by: Marc Jones

Acked-by: Carl-Daniel Hailfinger

I have one minor nitpick, though:
> Index: coreboot-v2/src/northbridge/amd/amdht/ht_wrapper.c
>
> --- coreboot-v2.orig/src/northbridge/amd/amdht/ht_wrapper.c	2008-07-16 15:37:37.000000000 -0600
> +++ coreboot-v2/src/northbridge/amd/amdht/ht_wrapper.c	2008-07-15 15:05:16.000000000 -0600
> @@ -110,6 +150,7 @@
>   */
>  void amd_ht_init(struct sys_info *sysinfo)
>  {

Accidental new empty line.
> AMD_HTBLOCK ht_wrapper = {
>    	NULL,	// u8 **topolist;
>    	0,	// u8 AutoBusStart;

Regards,
Carl-Daniel