On Thu, Apr 05, 2007 at 02:38:12AM -0400, Corey Osgood wrote:
+/* Generic Registers */ +/* Not used yet, but may be in the future */ +#define F71805F_CHIP_ID1 0x20 /* Chip ID 1 of F71805 (Def: 0x04) */ +#define F71805F_CHIP_ID2 0x21 /* Chip ID 2 of F71805 (Def: 0x06) */ +#define F71805F_VENDOR_ID1 0x23 /* Vendor ID 1 of Fintek Devices */ +#define F71805F_VENDOR_ID2 0x24 /* Vendor ID 2 of Fintek Devices */ +#define F71805F_SOFTPD 0x25 /* Software Pull-Down Register */ +#define F71805F_IRQ_CTL 0x26 /* UART IRQ Sharing Register */ +#define F71805F_PWON_TRAP 0x27 /* Power On Trap Status Register */ +#define F71805F_FLASH_CTL 0x28 /* Flash Control Register */ +#define F71805F_VFAULT_CTL 0x29 /* Voltage Fault Enable Register */
I think you can drop these lines, you'll probably never need them...
+struct chip_operations; +extern struct chip_operations superio_fintek_f71805f_ops;
+#include <pc80/keyboard.h> +#include <uart8250.h>
+struct superio_fintek_f71805f_config {
- struct uart8250 com1, com2;
Does the chip have keyboard support? If so, you can add struct pc_keyboard keyboard; here.
Index: src/superio/fintek/f71805f/f71805f_early_serial.c
--- src/superio/fintek/f71805f/f71805f_early_serial.c (revision 0) +++ src/superio/fintek/f71805f/f71805f_early_serial.c (revision 0) @@ -0,0 +1,48 @@ +/*
- This file is part of the LinuxBIOS project.
- Copyright (C) 2007 Corey Osgood corey@slightlyhackish.com
- Copyright (C) 2005 Digital Design Corporation
You can drop this, I think. You didn't really reuse any substantial code from the LPC47B272, this whole file is more or less just a trivial implementation of some "APIs" (sort of like a getter/setter method in Java -- there really isn't any other way than this to write the code).
(in fact, this code is so common in many Super I/Os that it should probably be abstracted away in some generic file one day...)
+/* Ported from the SMSC LPC47B272 driver */
Can be dropped.
Otherwise the patch looks good.
Uwe.