Re: [coreboot] [PATCH] Various x86emu fixes

[Myles Watson]

On Fri, Nov 6, 2009 at 10:18 AM, Peter Stuge  wrote:
> Myles Watson wrote:
> > I don't think we should depend on the value from the card.  The
> > point of that check is to make sure we don't run the wrong types of
> > ROMs. One way to work around it would be to correct the VGA BIOS
> > from your card and put it into CBFS.
>
> Stefan, what about Myles' comment above? I think it's a good point.

We started discussing it off list.  This should catch the list up:

On Thu, Nov 5, 2009 at 11:03 AM, Stefan Reinauer wrote:
> Myles Watson wrote:
> > Did you see my concern with checking the device instead of the ROM?
> >
> > Thanks,
> > Myles
>
> oops sorry.. I missed that one..

No problem.
> Hm.. not sure.. that particular check does not seem to be a consistency
> check but rather a check to determine from which location to run the VGA
> OPROM from... Generally, VGA oproms should run from 0xc0000.

Yes.  His card is broken.  I just wanted to make sure the change doesn't
break other things to enable his 10-year-old card.
> Maybe we should add another check whether class of the card and class of
> the device are the same?

If we did, that would break his card again.

I guess someone will complain if/when it matters.  I'm not sure what the
"right" thing to do is.

Thanks,
Myles