Re: [coreboot] [PATCH] consolidate K8M890 VGA code

[Luc Verhaegen]

On Wed, Oct 28, 2009 at 05:00:11PM -0600, Myles Watson wrote:
> On Wed, Oct 28, 2009 at 4:44 PM, Myles Watson  wrote:
> > fbbits = ((log2(uma_memory_size >> 20) - 2) << 4);
> >
> > Why not use CONFIG_VIDEO_MB here?  If it is going to be fixed at compile
> > time, it seems like you can get rid of uma_memory_size.
>
> Either way:
>
> Acked-by: Myles Watson
>
> Thanks,
> Myles

NACK.

WHY?

Luc Verhaegen.