On Thu, Oct 8, 2009 at 3:30 PM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
On 08.10.2009 22:49, Myles Watson wrote:
Check the return value when decompressing.
It's not 100% fixed, since the caller (cbfs_load_stage) returns -1 and then cbfs_and_run_core jumps to it.
print_debug("Jumping to image.\r\n"); dst = cbfs_load_stage(filename); print_debug("Jumping to image.\r\n");
Why do we jump to a -1 instead of hanging?
I sent a patch do die() instead,
I thought it seemed familiar. I just hit it for the first time.
but Stefan wrote he had a more extensive pending in that area, so my patch was not committed. See http://patchwork.coreboot.org/patch/203/ for details.
It looks like he was talking about the linker error, right?
Thanks, Myles