Re: [coreboot] [PATCH] warning days - m57sli/mcp55

[Myles Watson]

> If there are better ways to kill the warnings, please let me know!
> Index: src/mainboard/gigabyte/m57sli/fanctl.c
>
> --- src/mainboard/gigabyte/m57sli/fanctl.c	(revision 5411)
> +++ src/mainboard/gigabyte/m57sli/fanctl.c	(working copy)
> @@ -71,6 +71,7 @@
>  /*
> Called from superio.c
>
> */
> +extern void init_ec(uint16_t base);
>  void init_ec(uint16_t base)
>  {
>    int i;

I would ack the patch except for the added extern statements.  I thought
extern was for functions and variables that are declared in another file.

I've been fixing the "no previous prototype" warnings in two ways:
1. declare the function static if it is only used in that file
2. Add a prototype in a header that is included in the file where the
function is defined and the file where it's used.

Thanks,
Myles