Re: [coreboot] [commit] r6530 - in trunk/src/mainboard/lenovo: . t60 t60/acpi

[Peter Stuge]

repository service wrote:
> +++ trunk/src/mainboard/lenovo/t60/acpi/dock.asl	Wed Apr 20 11:12:17 2011	(r6530)
> @@ -53,15 +53,39 @@
> Method(_STA, 0, NotSerialized)
> {
> Return (DSTA)
> 	Return (DSTA)
> }
> }
>
> }

Would be even nicer to have fixed this whitespace in x60 before the copy.
> +++ trunk/src/mainboard/lenovo/t60/cmos.layout	Wed Apr 20 11:12:17 2011	(r6530)
> @@ -107,6 +107,7 @@
>  1048         4       r       0        C0DRT1
>  1052         4       r       0        C1DRT1
>
> +1060         1       e       1        touchpad
>  # -----------------------------------------------------------------

Is this on the wrong side of the newline? And what about the
position? I would rather have expected it to be at 1056?
> +++ trunk/src/mainboard/lenovo/t60/devicetree.cb	Wed Apr 20 11:12:17 2011	(r6530)

..
> device pci 02.1 on # display controller
> 	subsystemid 0x17aa 0x201a
> end

Same, nicer to have whitespace fix in x60 first.

//Peter