On Thu, Nov 6, 2008 at 7:40 AM, Myles Watson mylesgw@gmail.com wrote:
v2 uses the #if X == 1
v3 uses #ifdef X
I doubt we want condifional compilation at all. coreboot is firmware, not an OS, and we don't want lots of variant versions. I lean toward yanking this type of conditional compilation.
I think the reason this was originally done was for size. There might be some people who are unhappy with HT, PCIe, and PCIx support compiled in for their embedded box.
Let me restate. I like the idea of NOT compiling in un-needed drivers. I just wonder about the way it was done in device code.
Sorry, have not had breakfast yet, just got off the phone with comcast.
ron