Stefan Reinauer (stefan.reinauer@coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1715
-gerrit
commit 687d81236cdc0ad908f90ef41e7d4fc76e4edddc Author: Vadim Bendebury vbendeb@chromium.org Date: Wed Aug 29 15:03:09 2012 -0700
Fix cbmem to work on 64 bit platforms
For some reason which I fail to understand, specifying endiannes using '@' (which means 'native' and should be the same as '<' on x86 platforms) causes cbmem.py to crash the machine on 64 bit systems.
What happens is that the addresses read from various table headers' struct representations do not make sense, when bogus address gets passed to get_phys_mem, the crash happens while that function is executed.
dlaurie@ found out that replacing "@" with "<" in fact fixes the issue. After some investigation I am just submitting this fix without much understanding of the root cause.
Change-Id: Iaba9bc72a3f6b1d0407a5f1e3b459ccf5063969d Signed-off-by: Duncan Laurie dlaurie@chromium.org Signed-off-by: Vadim Bendebury vbendeb@chromium.org --- util/cbmem/cbmem.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/cbmem/cbmem.py b/util/cbmem/cbmem.py index f4f3e88..839393b 100755 --- a/util/cbmem/cbmem.py +++ b/util/cbmem/cbmem.py @@ -57,7 +57,7 @@ def get_phys_mem(addr, size): class MetaCStruct(type): def __init__(cls, name, bases, dct): struct_members = dct["struct_members"] - cls.struct_fmt = "@" + cls.struct_fmt = "<" for char, name in struct_members: cls.struct_fmt += char cls.struct_len = struct.calcsize(cls.struct_fmt)