Re: [coreboot] [patch][v2] cs5536 usb port4 configuration

[Peter Stuge]

On Wed, Jun 04, 2008 at 01:21:46PM -0600, Marc Jones wrote:
> This patch uses byte pointer and the MMIO read and write functions.

Nice.
> writel(readl(bar + IPREG04) | USB_HCCPW_SET, bar + IPREG04);

..though I still prefer set and clear functions or macros over this.

//Peter