Re: [coreboot] Unifying AMD SB700/SB800/SB900 code base

[Bruce Griffith]

> This is awesome news. Was it intentional that you did not reply to the 
> list
> too?

It was intentional but probably poor judgment.  This reply is to the list.
> As can be seen from the latest responses this seems to be considered
> quite controversial.

The focus is on AMD-designed boards, but may impact other boards with AMD 
processors and chipsets.  Marc and Martin are watching over the effort and 
the patches will be pushed to Gerrit where they will go through the normal 
review process.
> My message was also about code outside `src/mainboard`. But let’s take one
> step at a time.

Replicated code in the wrappers for CIM-X, AGESA, and pre-AGESA is less of a 
concern.  That would be at a lower priority than src/mainboards.
> -----Original Message-----
> From: Paul Menzel [mailto:[e-mail]]
> Sent: 07 March 2013 4:35 AM
> To: Bruce Griffith
> Subject: Re: [coreboot] Unifying AMD SB700/SB800/SB900 code base
>
> Dear Bruce,
>
> thank you very much for your response and sorry for my late reply.
>
> Am Montag, den 04.03.2013, 18:40 -0600 schrieb Bruce Griffith:
> > You're right.  There's a lot of replicated code in the AMD-specific
> > parts of the coreboot tree.  In the past, the focus has been to get
> > new parts and development boards released as early as possible.  And
> > that has been at the expense of keeping the codebase clean.
> >
> > There is an effort starting up to clean up the codebase to [get] as much
> > code as possible out of the mainboards directories for AMD boards.  As
> > a consequence, we expect that some amount of code will get refactored
> > into common files.   Using standard file names, function names, and
> > variable names when similar code needs to be differentiated by
> > processor or chipset is a good suggestion.
> >
> > I expect that we will start to have patches into gerrit within a week
> > or two.
>
> This is awesome news. Was it intentional that you did not reply to the 
> list
> too? As can be seen from the latest responses this seems to be considered
> quite controversial.
>
> My message was also about code outside `src/mainboard`. But let’s take one
> step at a time.
>
> Thanks,
> Paul