Re: [coreboot] PATCH: superiotool probe for ServerEngines chip

[Ruud Schramp (DT)]

Updated

Signed-off-by: Ruud Schramp

-----Original Message-----
From: coreboot-bounces+schramp=[e-mail]
[mailto:coreboot-bounces+schramp=[e-mail]] On Behalf Of
Stefan Reinauer
Sent: Saturday, April 09, 2011 1:08 AM
To: Ruud Schramp (DT)
Cc: [e-mail]
Subject: Re: [coreboot] PATCH: superiotool probe for ServerEngines chip

* Ruud Schramp (DT)  [110408 10:21]:
> Hi guys,
>
> Do not know how to handle the unknown devices (LDN's) yet. For now I 
> dump all IO base registers etc for information purposed.
>
> I have identified two LDN's as Serial port; (LDN 0x01 and LDN 0x02)
>
> Best regards,
>
> Ruud
>
> Signed-off-by: Ruud Schramp
> diff -uNr superiotool_org/serverengine.c superiotool/serverengine.c
> --- superiotool_org/serverengine.c	1970-01-01 01:00:00.000000000

+0100
> +++ superiotool/serverengine.c	2011-04-08 10:13:33.000000000

+0200

please rename to serverengines.c
> @@ -0,0 +1,106 @@
> +/*
> This file is part of the superiotool project.
> Copyright (C) 2007 Uwe Hermann

Please add your copyright here
> +static const struct superio_registers reg_table[] = {
> /* TODO: M5113 doesn't seem to have ID registers? */

Astray line from original code? Please delete
> {0x02c0, "Server Engine SE-SM 4210-P01", {

Drop Server Engine here.
> /* TODO: Not documented/available on M512x (?) */

Left over comment?

Stefan