Re: [coreboot] r3474 - in trunk/payloads/libpayload: drivers i386 include

[Stefan Reinauer]

Jordan Crouse wrote:
> > Weird, it compiles fine here. I strongly suggest changing the Makefile,
> > adding -Wno-pointer-sign. It's a dumb warning.
>
> Nak.  This is not a dumb warning - I have seen it expose some real
> issues.

Yes? Please exemplify
> And the memory compare functions should probably be taking void *.

Just checked. Normal libc memcmp takes void. I thought libpayload
functions were modelled after these. If not, that should be fixed anyways.

void * is a good idea here.