On Fri, Nov 14, 2008 at 8:50 AM, Myles Watson mylesgw@gmail.com wrote:
It could be done in superio.c where the mask is being set.
I think it should be done in dts, but this *is* an option. If the dts setting is zero pick a reasonable default.
That was one of my questions. Aren't these settings mainboard specific? In that case we want to set them in each mainboard. Otherwise it'll bite lots of people.
They are usually generic, and only rarely need to change. This supports your idea of having defaults in .c files. This makes the defaults harder to find, but it would work. However, I like your idea below a little better:
If we're going that way, I'd rather just use what we have and change the PNP code to match. (Let it create dynamic devices but pass more information in the info structure so that the enables get set, etc.) The hierarchy buys us nothing if we just make lots of little files and types.
I think this makes the most sense.
BTW: Does anyone see PNP devices besides the SuperIOs? I.E., will the PNP code ever get used for anything else?
not yet. I hope never. PNP is a mess.
ron