On 28.01.2008 14:28, Stefan Reinauer wrote:
- Marc Jones marc.jones@amd.com [080122 00:01]:
-/* smbus functions */ -int smbus_read_byte(unsigned device, unsigned address);
hmm. So where does the prototype live then?
They should not necessarily be inter-stage prototypes. I think they can be part of the "initram" stage and stay in there. No?
We may need access to SMBUS for hardware other than SPD.
-/* dram functions */ -void ram_failure(const char *why); -void ram_initialize(int controllers, void *ctrl);
These are in lib/ram.c and even defined in the documentation ;-)
What should we do about that?
You have a point. There should be a standard prototype but lib.h seemed to be a random place for them.
Don't think we want them in the bootblock. It's too big already anyways.
I always wondered why the bootblock was so large in v3 although not that much code was linked into it. Maybe I underestimated the amount of code linked into the bootblock.
Regards, Carl-Daniel