On Fri, Aug 21, 2009 at 12:33 PM, Harald Gutmannharald.gutmann@gmx.net wrote:
On Friday 21 August 2009 20:21:27 Myles Watson wrote:
OK, I am going to apply Cristi's patch, and, if it looks good, commit. Then we can do nvidia south.
Okay, sounds good.
Lets not create a new CONFIG variable SOUTHBRIDGE_NVIDIA_MCP55. I think that whole file can go. And the files that source it. Index: nvidia/mcp55/Kconfig Index: nvidia/Kconfig
Are you sure that this will work as in the mainboard/{vendor}/{model}/Kconfig it is used to select which sb is used. (Maybe I'm wrong with this, but I used the amd_serengeti target as starting point, and there it's done the same way.)
You're right. The reason I was questioning it was that I grepped the tree and didn't find any CONFIG_SOUTHBRIDGE_NVIDIA*
I think the correct fix for that problem is to change src/southbridge/nvidia/Makefile.inc subdirs-y should be subdirs-$(CONFIG_SOUTHBRIDGE_NVIDIA_MCP55).
Does that sound better?
I'd rather you didn't remove the ck804 references, since my patch will have to put them back.
Done.
+driver-$(CONFIG_HAVE_ACPI_TABLES) += mcp55_fadt.o I think you mean obj here.
Yes.
v2 of the patch attached, with some more (little) modifications.
Thanks, Myles