Re: [coreboot] r3977 - in trunk/coreboot-v2/src: arch/i386/boot arch/i386/smp cpu/x86/lapic cpu/x86/tsc devices

[Myles Watson]

On Fri, Mar 6, 2009 at 11:36 AM, Carl-Daniel Hailfinger
 wrote:
> On 06.03.2009 18:24, [e-mail] wrote:
> > Author: stepan
> > Date: 2009-03-06 18:24:29 +0100 (Fri, 06 Mar 2009)
> > New Revision: 3977
> >
> > fix a bunch of cast and type warnings and don't call the apic "nvram", that
> > doesn't make no sense. (trivial)
>
> The change to the ROUND macro is rather non-trivial. It changes the
> formula. If the new formula is indeed what you want, one parenthesis can
> be removed:
>
> #define ROUND(_r,_a) (((_r) + ((_a) - 1)) & ~((_a) - 1))

I agree that a parenthesis can be removed, but since + has precedence
over & I don't see how the formula was changed.

Thanks,
Myles