On Fri, Oct 2, 2009 at 11:41 AM, Tom Sylla tsylla@gmail.com wrote:
As a side rant, why does do Linux and coreboot insist on referring to SMBus addresses shifted right byte one bit? They are 7 bits long, and should be *left* justified in the byte. Take a look at every SMBus controller, and you will see that is how the register is laid out, address is the top 7 bits, and the bottom bit is read/write. Take a look at the SMBus drivers in coreboot, and you will see the access function doing something like: dimm_address << 1 | READ_WRITE. It just seems silly to me :)
Maybe it is a difference in view. The address is 7 bits in all the docs. How it is laid out in the register and on the bits on the wire is really a different concern.
I can see an argument for either side ...
ron