Re: [coreboot] [PATCH] More Kconfig changes

[Myles Watson]

On Mon, Oct 19, 2009 at 3:39 PM, Peter Stuge  wrote:
> Myles Watson wrote:
> > +config GENERATE_ACPI_TABLES
> >       bool
> > default y if HAVE_ACPI_TABLES
> > default n
>
> Can it be simply:
>
> default HAVE_ACPI_TABLES

It looks like it could.  We have a mix of the two styles right now.

src/console/Kconfig:    default MAXIMUM_CONSOLE_LOGLEVEL_8
src/console/Kconfig:    default DEFAULT_CONSOLE_LOGLEVEL_8
src/mainboard/Kconfig:    default VENDOR_EMULATION
src/mainboard/Kconfig:    default COREBOOT_ROMSIZE_KB_128 if
BOARD_ROMSIZE_KB_128
src/mainboard/Kconfig:    default COREBOOT_ROMSIZE_KB_256 if
BOARD_ROMSIZE_KB_256
> +++ svn/src/northbridge/amd/amdfam10/Kconfig
> > @@ -21,11 +21,35 @@ config NORTHBRIDGE_AMD_AMDFAM10
> >       bool
> >       select HAVE_HIGH_TABLES
> >       select HYPERTRANSPORT_PLUGIN_SUPPORT
> > select HT3_SUPPORT
> >
> > config AGP_APERTURE_SIZE
> >       hex
> >       default 0x4000000
> >       depends on NORTHBRIDGE_AMD_AMDFAM10
> >
> > +config HT3_SUPPORT
> > bool
> > default y
> > depends on NORTHBRIDGE_AMD_AMDFAM10
>
> Is this good?

It has to be defined somewhere.  The alternative is to put config
HT3_SUPPORT somewhere else, then use select in this file.  Since there are
no other devices with HT3_SUPPORT at this time, I think this is the place to
put it.

If you use select and HT3_SUPPORT isn't defined somewhere else, it silently
fails.
> I find having single line selects instead of repeating the horribly
> long NB option name over and over very appealing

Me too.
> but I don't know
> enough about Kconfig to say if it makes a difference?

In this case it does.

Thanks,
Myles