Ühel kenal päeval, P, 2008-08-10 kell 15:03, kirjutas ron minnich:
On Sun, Aug 10, 2008 at 2:45 PM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
On 10.08.2008 23:25, ron minnich wrote:
This patch is for include/ to add k8 includes.
ron
Add defines for K8
Signed-off-by: Ronald G. Minnich rminnich@gmail.com
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Committed revision 732.
This broke the build of all GeodeLX targets, because the define of PCI_DEVICE_ID_AMD_LXBRIDGE lost a newline before it and got to the same line as PCI_DEVICE_ID_AMD_VIPER_7412 - including in the reviewed attachment. Not a big deal, I've committed a trivial fix with a self-ack in r737 as follows:
Author: mraudsepp mraudsepp@f3766cd6-281f-0410-b1cd-43a5c92072e9 Date: Mon Aug 11 13:23:40 2008 +0000
Trivial: Add a missing newline in front of PCI_DEVICE_ID_AMD_LXBRIDGE define, lost in r732
Fixes geodelx target builds, compile-tested on DBE62
Signed-off-by: Mart Raudsepp mart.raudsepp@artecdesign.ee Acked-by: Mart Raudsepp mart.raudsepp@artecdesign.ee
git-svn-id: svn://coreboot.org/repository/coreboot-v3@737 f3766cd6-281f-0410-b1cd-43a5c92072e9
diff --git a/include/device/pci_ids.h b/include/device/pci_ids.h index b65c3d2..4136fd0 100644 --- a/include/device/pci_ids.h +++ b/include/device/pci_ids.h @@ -191,7 +191,8 @@ #define PCI_DEVICE_ID_AMD_AES 0x2082 #define PCI_DEVICE_ID_AMD_761_0 0x700E #define PCI_DEVICE_ID_AMD_761_1 0x700F -#define PCI_DEVICE_ID_AMD_VIPER_7412 0x7412#define PCI_DEVICE_ID_AMD_LXBRIDGE 0x2080 +#define PCI_DEVICE_ID_AMD_VIPER_7412 0x7412 +#define PCI_DEVICE_ID_AMD_LXBRIDGE 0x2080 #define PCI_DEVICE_ID_AMD_CS5536_ISA 0x2090 #define PCI_DEVICE_ID_AMD_CS5536_FLASH 0x2091 #define PCI_DEVICE_ID_AMD_CS5536_A0_IDE 0x2092