Re: [coreboot] PATCH: Add Spansion S25FL016A to flashrom

[Stefan Reinauer]

* Peter Stuge  [080124 13:38]:
> Index: util/flashrom/flash.h
>
> --- util/flashrom/flash.h	(revision 3073)
> +++ util/flashrom/flash.h	(working copy)
> @@ -166,6 +166,14 @@
>  #define SHARP_LHF00L04		0xCF
>
> /*
> Spansion was previously a joint venture of AMD and Fujitsu.
> S25 chips are SPI. The first device ID byte is memory type and
> the second device ID byte is memory capacity.
> */
>
> +#define SPANSION_ID		0x01	/* Spansion */
> +#define SPANSION_S25FL016A	0x0214

This is unrelated to your patch, but I don't like that we list all the
IDs as defines in flash.h just to put that define in the same place in
flashchips.c.

Can't we just put the ID directly into the array in flashchips.c and
rather add another string for the vendor name?