RE: FYI: Merge in progress...

[YhLu]

There is overlapping between prefmem and mem.

PCI_DOMAIN: 0000 00 <- [0x0000001000 - 0x0000005fff] io
PCI_DOMAIN: 0000 01 <- [0x00f8000000 - 0x01007fffff] prefmem
PCI_DOMAIN: 0000 02 <- [0x00f8000000 - 0x00fe6fffff] mem
PCI: 00:18.0 1c0 <- [0x0000001000 - 0x0000003fff] io <node 0 link 0>
PCI: 00:18.0 1b8 <- [0x0000000000 - 0x000fffffff] prefmem <node 0 link 0>
PCI: 00:18.0 1b0 <- [0x00fc000000 - 0x00fe1fffff] mem <node 0 link 0>
PCI: 00:18.0 1da <- [0x0000004000 - 0x0000004fff] io <node 0 link 2>
PCI: 00:18.0 1aa <- [0x0100800000 - 0x01007fffff] prefmem <node 0 link 2>
PCI: 00:18.0 1a2 <- [0x00fe200000 - 0x00fe4fffff] mem <node 0 link 2>

PCI: 00:18.3 94 <- [0x00f8000000 - 0x00fbffffff] mem <gart>
PCI: 00:19.3 94 <- [0x00f8000000 - 0x00fbffffff] mem <gart>
PCI: 00:19.0 1c8 <- [0x0000005000 - 0x0000005fff] io <node 1 link 0>
PCI: 00:19.0 198 <- [0x00f8000000 - 0x01007fffff] prefmem <node 1 link 0>
PCI: 00:19.0 190 <- [0x00fe500000 - 0x00fe6fffff] mem <node 1 link 0>

-----Original Message-----
From: YhLu 
Sent: Monday, October 18, 2004 2:29 PM
To: '[e-mail]'
Cc: Ronald G. Minnich; Li-Ta Lo; 'LinuxBIOS'
Subject: RE: FYI: Merge in progress...

self.firstparentdevicelink()

How about IORESOURCE_FIXED ?

static void pnp_set_resource(device_t dev, struct resource *resource)
{
        if (!(resource->flags & IORESOURCE_ASSIGNED)) {
                printk_err("ERROR: %s %02x not allocated\n",
                        dev_path(dev), resource->index);
                return; 
        }

-----Original Message-----
From: [e-mail] [mailto:[e-mail]] 
Sent: Monday, October 18, 2004 2:22 PM
To: YhLu
Cc: Ronald G. Minnich; Li-Ta Lo; 'LinuxBIOS'
Subject: Re: FYI: Merge in progress...

YhLu  writes:
> It should config.g bug, there is some un consistent.

It could be. I should have fixed this Saturday, but...

Looking Hmm...
> For dev33 and it sibling
> should be .bus = &_dev4.link[2],
> instead of 
>    .bus = &_dev4.link[0],

Good catch.  We do not yet have the link of the parent device set
properly in the .bus field.  It is always hard coded to 0 :(

Ok the fix looks easy, committed.

Hopefully I have not missed any other cases...

Eric