coreboot

coreboot@coreboot.org

17 participants
39654 discussions

New Defects reported by Coverity Scan for coreboot
by scan-admin＠coverity.com 20 Oct '22

20 Oct '22

Hi, Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan. 1 new defect(s) introduced to coreboot found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1499913: Integer handling issues (NO_EFFECT) /3rdparty/arm-trusted-firmware/drivers/arm/gic/v3/gicv3_main.c: 1109 in gicv3_raise_sgi() ________________________________________________________________________________________________________ *** CID 1499913: Integer handling issues (NO_EFFECT) /3rdparty/arm-trusted-firmware/drivers/arm/gic/v3/gicv3_main.c: 1109 in gicv3_raise_sgi() 1103 u_register_t target) 1104 { 1105 unsigned int tgt, aff3, aff2, aff1, aff0; 1106 uint64_t sgi_val; 1107 1108 /* Verify interrupt number is in the SGI range */ >>> CID 1499913: Integer handling issues (NO_EFFECT) >>> This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "sgi_num >= 0U". 1109 assert((sgi_num >= MIN_SGI_ID) && (sgi_num < MIN_PPI_ID)); 1110 1111 /* Extract affinity fields from target */ 1112 aff0 = MPIDR_AFFLVL0_VAL(target); 1113 aff1 = MPIDR_AFFLVL1_VAL(target); 1114 aff2 = MPIDR_AFFLVL2_VAL(target); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

[coreboot - Bug #431] (New) fix src/arch/x86/smbios issues
by Martin Roth 20 Oct '22

20 Oct '22

Issue #431 has been reported by Martin Roth. ---------------------------------------- Bug #431: fix src/arch/x86/smbios issues https://ticket.coreboot.org/issues/431 * Author: Martin Roth * Status: New * Priority: Normal * Assignee: Solomon Alan-Dei * Category: coreboot common code * Target version: none * Start date: 2022-10-20 ---------------------------------------- There are currently 20 coverity issues affecting smbios code in src/arch/x86/smbios* https://scan6.scan.coverity.com/reports.htm#v55284/p10744 https://docs.google.com/spreadsheets/d/1hacitQU1zn7CU44eXP3xVdvq-OjnIF_h8LR… ---Files-------------------------------- Outstanding+Issues+in+smbios.csv (3.61 KB) -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: https://ticket.coreboot.org/my/account

1 0

[coreboot - Bug #430] (New) Fix util/cbfstool coverity issues
by Martin Roth 20 Oct '22

20 Oct '22

Issue #430 has been reported by Martin Roth. ---------------------------------------- Bug #430: Fix util/cbfstool coverity issues https://ticket.coreboot.org/issues/430 * Author: Martin Roth * Status: New * Priority: Normal * Category: userspace utilities * Target version: none * Start date: 2022-10-20 ---------------------------------------- There are currently 25 coverity issues against files in the util/cbfstool directory: https://scan6.scan.coverity.com/reports.htm#v55283/p10744 https://docs.google.com/spreadsheets/d/1hacitQU1zn7CU44eXP3xVdvq-OjnIF_h8LR… ---Files-------------------------------- Outstanding+Issues+in+cbfstool.csv (4.47 KB) -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: https://ticket.coreboot.org/my/account

1 1

[coreboot - Bug #401] (New) edk2 hangs indefiniately
by Sean Rhodes 19 Oct '22

19 Oct '22

Issue #401 has been reported by Sean Rhodes. ---------------------------------------- Bug #401: edk2 hangs indefiniately https://ticket.coreboot.org/issues/401 * Author: Sean Rhodes * Status: New * Priority: Normal * Assignee: Arthur Heymans * Category: board support * Target version: none * Start date: 2022-07-08 * Affected versions: master * Affected hardware: Everything * Affected OS: Doesn't matter ---------------------------------------- Since CB:63555, edk2 will no longer boot and hangs indefiniately Various forks disable MTRR programming in edk2 (such as https://github.com/MrChromebox/edk2/commit/d641ea6920737fd9b9a94210e9a2e763…) but this shouldn't be done as it breaks spec. Workarounds are to revert CB:64804, CB:63550, CB:64803 and CB:63555. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: https://ticket.coreboot.org/my/account

7 11

New on blogs.coreboot.org: Announcing coreboot 4.18
by blogs.coreboot.org 18 Oct '22

18 Oct '22

1 0

[coreboot - Bug #427] (New) x200: Two battery charging issues
by Akura Ryu 17 Oct '22

17 Oct '22

Issue #427 has been reported by Akura Ryu. ---------------------------------------- Bug #427: x200: Two battery charging issues https://ticket.coreboot.org/issues/427 * Author: Akura Ryu * Status: New * Priority: Urgent * Category: board support * Target version: master * Start date: 2022-10-14 * Affected versions: master * Needs backport to: master * Affected hardware: ThinkPad X200 * Affected OS: Linux ---------------------------------------- I've flashed my ThinkPad X200 with coreboot. Currently it has trouble when charging. ## 1. Cannot charge when battery level is below 20%. When I plug in my AC adapter, system always reports " **Not charging** ". Here's the output from the `acpi` utility: ``` Battery 0: Not charging, 23% Adapter 0: on-line ``` But weirdly, battery level is still increasing as the AC adapter is on-line. ## 2. Battery threshold doesn't seem to work. Since tp_smapi is unusable without stock firmware, I use `tpacpi-bat` to configure battery threshold. My KDE battery indicator can recognize these thresholds. ```sh sudo tpacpi-bat -s ST 1 88 # Start threshold sudo tpacpi-bat -s SP 1 90 # Stop threshold ``` But no matter how I charge, battery will always be fully charged. ## Revision - **OS**: Arch Linux with KDE - **Coreboot revision**: 93781523a - **Configuration**: See attachment ---Files-------------------------------- .config (18.8 KB) -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: https://ticket.coreboot.org/my/account

2 6

[coreboot - Documentation #426] (New) Document existing and added TPM event log formats and PCR usage
by Krystian Hebel 14 Oct '22

14 Oct '22

Issue #426 has been reported by Krystian Hebel. ---------------------------------------- Documentation #426: Document existing and added TPM event log formats and PCR usage https://ticket.coreboot.org/issues/426 * Author: Krystian Hebel * Status: New * Priority: Normal * Category: Documentation * Target version: none * Start date: 2022-10-12 ---------------------------------------- Documentation should mention at least: - what formats are available and where they are described - what are possible consumers of each format - which hashing algorithms can be used - what additional info is added to that required by specification, if any - which component is extended to which PCR for each of supported scheme (may be in form of example event log) Additionally, existing vboot documentation should be fixed, especially parts describing SRTM and DRTM. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: https://ticket.coreboot.org/my/account

2 2

[coreboot - Feature #425] (New) Add parsing of new TPM event log formats to cbmem utility
by Krystian Hebel 14 Oct '22

14 Oct '22

Issue #425 has been reported by Krystian Hebel. ---------------------------------------- Feature #425: Add parsing of new TPM event log formats to cbmem utility https://ticket.coreboot.org/issues/425 * Author: Krystian Hebel * Status: New * Priority: Normal * Category: userspace utilities * Target version: none * Start date: 2022-10-12 ---------------------------------------- All existing and newly implemented formats must be parse-able by cbmem. It should be able to automatically recognize used format and parse it accordingly, so there are no significant differences in invocation of this tool by end users. Crypto agile format will require implementation of additional unmarshaling. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: https://ticket.coreboot.org/my/account

2 3

[coreboot - Feature #424] (New) Create and implement option to choose either TCG or vboot PCR assignment
by Krystian Hebel 14 Oct '22

14 Oct '22

Issue #424 has been reported by Krystian Hebel. ---------------------------------------- Feature #424: Create and implement option to choose either TCG or vboot PCR assignment https://ticket.coreboot.org/issues/424 * Author: Krystian Hebel * Status: New * Priority: Normal * Target version: none * Start date: 2022-10-12 ---------------------------------------- As with TPM event log, standardized TCG assignment should be chosen by default, with opt-in possibility to choose existing behaviour for platforms that depend on it. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: https://ticket.coreboot.org/my/account

2 2

[coreboot - Feature #423] (New) Implement legacy and crypto agile TPM event log formats
by Krystian Hebel 14 Oct '22

14 Oct '22

Issue #423 has been reported by Krystian Hebel. ---------------------------------------- Feature #423: Implement legacy and crypto agile TPM event log formats https://ticket.coreboot.org/issues/423 * Author: Krystian Hebel * Status: New * Priority: Normal * Target version: none * Start date: 2022-10-12 ---------------------------------------- Legacy format is simple, it always uses SHA1 and its entries can be described by a C structure, with one field of variable length at the end. Crypto agile format is slightly more complicated. There can be more than one digest in entry, and their sizes depend on algorithm. There is code for marshaling of required structures in security/tpm/tss/tcg-2.0, but it assumes TPM endianness (BE), while entries in event log are always LE. Headers for both formats have vendorInfo field, which can be used to hold additional data, not described by specification. An example of such may be offset to next entry to be added, which saves code from walking through all entries (possibly with different sizes) for each new entry. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: https://ticket.coreboot.org/my/account

2 2

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot