coreboot

coreboot@coreboot.org

11 participants
39712 discussions

RE: Adding a PCI device that doesn't exist (yet)
by Ronald G. Minnich 06 Oct '04

06 Oct '04

On Wed, 6 Oct 2004, Jay Miller wrote: > No, it's not a bridge. It's just a card, but I was under the impression > that you needed hardware support for hotplug? I've got more reading to do on hotplug, but it seems to me that if you have (e.g.) and empty bus slot, and a device appears there, then the daemon has to pick up the interrupt for that and start the hotplug sequence. In your case, it seems to me a program could run and "make the card exist" and then start the hotplug sequence. But I doubt I know what I'm talking about. ron

1 0

Re: Adding a PCI device that doesn't exist (yet)
by tyson＠irobot.com 06 Oct '04

06 Oct '04

Jay Miller wrote: > That's it, thanks so much. > > Guess I'll have to go buy a Roomba now. ;-) It'll take more than that! I work on the PackBot systems. :-) Cheers! Ty -- Tyson D Sawyer iRobot Corporation Lead Systems Engineer Government & Industrial Robotics tsawyer(a)irobot.com Robots for the Real World 781-345-0200 ext 3329 http://www.irobot.com

1 1

RE: Adding a PCI device that doesn't exist (yet)
by Jay Miller 06 Oct '04

06 Oct '04

That's it, thanks so much. Guess I'll have to go buy a Roomba now. ;-) Cheers, Jay Miller 781-229-7812x117 Actuality Systems, Inc. jmiller(a)actuality-systems.com -----Original Message----- From: tyson(a)irobot.com [mailto:tyson@irobot.com] Sent: Wednesday, October 06, 2004 2:35 PM To: Jay Miller Cc: Ronald G. Minnich; YhLu; linuxbios(a)clustermatic.org Subject: Re: Adding a PCI device that doesn't exist (yet) Jay Miller wrote: > Thanks Ty, that's exactly what we're looking for. The de-allocation > wouldn't be an issue as we would be re-programming on the reboot anyway. > > Did you use the proc_pci_attach_device() mechanism? > > Cheers, > > Jay Miller > 781-229-7812x117 > Actuality Systems, Inc. > jmiller(a)actuality-systems.com > > > -----Original Message----- > From: tyson(a)irobot.com [mailto:tyson@irobot.com] > Sent: Wednesday, October 06, 2004 1:52 PM > To: Jay Miller > Cc: Ronald G. Minnich; YhLu; linuxbios(a)clustermatic.org > Subject: Re: Adding a PCI device that doesn't exist (yet) > > Hopping in mid-thread here so I may have the context wrong: > > I have succeeded at programming the FPGA to create a PCI device after > the boot process. I was then able to have the device driver add the > device to the pci device table and get resources allocated for it and > get it paired up with the alread loaded device driver. > > I did not figure out how to de-allocate/de-register such that I could > cleanely re-program the FPGA without a re-boot. > > Is this relevant? > > Cheers! > Ty It is only a specific variation of this device that needed this code so it is hacked in by conditionally including the header file below into a .c file. Crufty code organization, but now you know. This was made to work by having user level initialization scripts program the FPGA before loading the device driver. The first thing that the device driver did in its init function was call the function below. This is working code as it sits. The things like "PCI_VENDOR_ID_IROBOT" are our own local hacks and defines. Things like "list_for_each_safe() come from the kernel headers. I think that <linux/pci.h> was all I needed for this part of the code but it might be dependent on others as well. I'd be happy to attempt to answer specific questions, but I think everything needed is here. I figured this out thought a lot of grepping and "use the source Luke!". Cheers! Ty =================================================================== /* * neolink2.h */ #define PCI_FNBUS 0 #define PCI_FNSLOT 16 #define PCI_FNFUNC 0 static int __init neolink2_init(void) { struct list_head *list, *list_tmp; struct pci_bus *bus; struct pci_dev dev, *dev1; if (pci_find_device(PCI_VENDOR_ID_IROBOT, PCI_DEVICE_ID_IROBOT_FN2A, NULL)) { printk("%6d:%s:%s() - Device is already initialized\n", __LINE__, __FILE__, __FUNCTION__); return 0; } list_for_each_safe(list, list_tmp, &pci_root_buses) { bus = pci_bus_b(list); if (bus->number == PCI_FNBUS) { memset(&dev, 0, sizeof(dev)); dev.bus = bus; dev.sysdata = bus->sysdata; dev.devfn = PCI_DEVFN(PCI_FNSLOT, PCI_FNFUNC); dev1 = pci_scan_slot(&dev); if (!dev1) { printk("%6d:%s:%s() - No device found\n", __LINE__, __FILE__, __FUNCTION__); return -ENODEV; } else { printk("%6d:%s:%s() - Found device %s\n", __LINE__, __FILE__, __FUNCTION__, dev1->name); pci_set_power_state(dev1, 0); pci_assign_resource(dev1, 0); pci_enable_device(dev1); // pci_announce_device_to_drivers(dev1); return 0; } break; } } printk("%6d:%s:%s() - Bus %d found\n", __LINE__, __FILE__, __FUNCTION__, PCI_FNBUS); return -ENODEV; } ===================================================================== -- Tyson D Sawyer iRobot Corporation Lead Systems Engineer Government & Industrial Robotics tsawyer(a)irobot.com Robots for the Real World 781-345-0200 ext 3329 http://www.irobot.com

1 0

Re: Adding a PCI device that doesn't exist (yet)
by tyson＠irobot.com 06 Oct '04

06 Oct '04

Jay Miller wrote: > Thanks Ty, that's exactly what we're looking for. The de-allocation > wouldn't be an issue as we would be re-programming on the reboot anyway. > > Did you use the proc_pci_attach_device() mechanism? > > Cheers, > > Jay Miller > 781-229-7812x117 > Actuality Systems, Inc. > jmiller(a)actuality-systems.com > > > -----Original Message----- > From: tyson(a)irobot.com [mailto:tyson@irobot.com] > Sent: Wednesday, October 06, 2004 1:52 PM > To: Jay Miller > Cc: Ronald G. Minnich; YhLu; linuxbios(a)clustermatic.org > Subject: Re: Adding a PCI device that doesn't exist (yet) > > Hopping in mid-thread here so I may have the context wrong: > > I have succeeded at programming the FPGA to create a PCI device after > the boot process. I was then able to have the device driver add the > device to the pci device table and get resources allocated for it and > get it paired up with the alread loaded device driver. > > I did not figure out how to de-allocate/de-register such that I could > cleanely re-program the FPGA without a re-boot. > > Is this relevant? > > Cheers! > Ty It is only a specific variation of this device that needed this code so it is hacked in by conditionally including the header file below into a .c file. Crufty code organization, but now you know. This was made to work by having user level initialization scripts program the FPGA before loading the device driver. The first thing that the device driver did in its init function was call the function below. This is working code as it sits. The things like "PCI_VENDOR_ID_IROBOT" are our own local hacks and defines. Things like "list_for_each_safe() come from the kernel headers. I think that <linux/pci.h> was all I needed for this part of the code but it might be dependent on others as well. I'd be happy to attempt to answer specific questions, but I think everything needed is here. I figured this out thought a lot of grepping and "use the source Luke!". Cheers! Ty =================================================================== /* * neolink2.h */ #define PCI_FNBUS 0 #define PCI_FNSLOT 16 #define PCI_FNFUNC 0 static int __init neolink2_init(void) { struct list_head *list, *list_tmp; struct pci_bus *bus; struct pci_dev dev, *dev1; if (pci_find_device(PCI_VENDOR_ID_IROBOT, PCI_DEVICE_ID_IROBOT_FN2A, NULL)) { printk("%6d:%s:%s() - Device is already initialized\n", __LINE__, __FILE__, __FUNCTION__); return 0; } list_for_each_safe(list, list_tmp, &pci_root_buses) { bus = pci_bus_b(list); if (bus->number == PCI_FNBUS) { memset(&dev, 0, sizeof(dev)); dev.bus = bus; dev.sysdata = bus->sysdata; dev.devfn = PCI_DEVFN(PCI_FNSLOT, PCI_FNFUNC); dev1 = pci_scan_slot(&dev); if (!dev1) { printk("%6d:%s:%s() - No device found\n", __LINE__, __FILE__, __FUNCTION__); return -ENODEV; } else { printk("%6d:%s:%s() - Found device %s\n", __LINE__, __FILE__, __FUNCTION__, dev1->name); pci_set_power_state(dev1, 0); pci_assign_resource(dev1, 0); pci_enable_device(dev1); // pci_announce_device_to_drivers(dev1); return 0; } break; } } printk("%6d:%s:%s() - Bus %d found\n", __LINE__, __FILE__, __FUNCTION__, PCI_FNBUS); return -ENODEV; } ===================================================================== -- Tyson D Sawyer iRobot Corporation Lead Systems Engineer Government & Industrial Robotics tsawyer(a)irobot.com Robots for the Real World 781-345-0200 ext 3329 http://www.irobot.com

1 0

RE: Adding a PCI device that doesn't exist (yet)
by Jay Miller 06 Oct '04

06 Oct '04

Thanks Ty, that's exactly what we're looking for. The de-allocation wouldn't be an issue as we would be re-programming on the reboot anyway. Did you use the proc_pci_attach_device() mechanism? Cheers, Jay Miller 781-229-7812x117 Actuality Systems, Inc. jmiller(a)actuality-systems.com -----Original Message----- From: tyson(a)irobot.com [mailto:tyson@irobot.com] Sent: Wednesday, October 06, 2004 1:52 PM To: Jay Miller Cc: Ronald G. Minnich; YhLu; linuxbios(a)clustermatic.org Subject: Re: Adding a PCI device that doesn't exist (yet) Hopping in mid-thread here so I may have the context wrong: I have succeeded at programming the FPGA to create a PCI device after the boot process. I was then able to have the device driver add the device to the pci device table and get resources allocated for it and get it paired up with the alread loaded device driver. I did not figure out how to de-allocate/de-register such that I could cleanely re-program the FPGA without a re-boot. Is this relevant? Cheers! Ty Jay Miller wrote: > Thanks for your help. Certainly that's not ideal, but it may turn out > to be our only option. > > Currently I'm investigating using proc_pci_attach_device() at the kernel > level to add the device from the driver module init(post-program), but > it's not looking promising. > > Thanks, > > Jay Miller > 781-229-7812x117 > Actuality Systems, Inc. > jmiller(a)actuality-systems.com > > > -----Original Message----- > From: Ronald G. Minnich [mailto:rminnich@lanl.gov] > Sent: Wednesday, October 06, 2004 12:23 PM > To: YhLu > Cc: Jay Miller; linuxbios(a)clustermatic.org > Subject: RE: Adding a PCI device that doesn't exist (yet) > > > > On Tue, 5 Oct 2004, YhLu wrote: > > >>Can you for the FPGA programming in the auto.c and issue an soft_reset > > in > >>auto.c? > > > I think this can work with the current mechanisms. You need to have your > > chip programmed pre-pci-scan, and the current config mechanism supports > that fine. > > > Is this V1 or V2, I forget. > > ron > _______________________________________________ > Linuxbios mailing list > Linuxbios(a)clustermatic.org > http://www.clustermatic.org/mailman/listinfo/linuxbios -- Tyson D Sawyer iRobot Corporation Lead Systems Engineer Government & Industrial Robotics tsawyer(a)irobot.com Robots for the Real World 781-345-0200 ext 3329 http://www.irobot.com

1 0

RE: Adding a PCI device that doesn't exist (yet)
by Dave Aubin 06 Oct '04

06 Oct '04

Hi Ty, Please tell:) What approach did you use to create the pci Device after boot? Thanks, Dave:) -----Original Message----- From: linuxbios-admin(a)clustermatic.org [mailto:linuxbios-admin@clustermatic.org] On Behalf Of tyson(a)irobot.com Sent: Wednesday, October 06, 2004 1:52 PM To: Jay Miller Cc: Ronald G. Minnich; YhLu; linuxbios(a)clustermatic.org Subject: Re: Adding a PCI device that doesn't exist (yet) Hopping in mid-thread here so I may have the context wrong: I have succeeded at programming the FPGA to create a PCI device after the boot process. I was then able to have the device driver add the device to the pci device table and get resources allocated for it and get it paired up with the alread loaded device driver. I did not figure out how to de-allocate/de-register such that I could cleanely re-program the FPGA without a re-boot. Is this relevant? Cheers! Ty Jay Miller wrote: > Thanks for your help. Certainly that's not ideal, but it may turn out > to be our only option. > > Currently I'm investigating using proc_pci_attach_device() at the > kernel level to add the device from the driver module > init(post-program), but it's not looking promising. > > Thanks, > > Jay Miller > 781-229-7812x117 > Actuality Systems, Inc. > jmiller(a)actuality-systems.com > > > -----Original Message----- > From: Ronald G. Minnich [mailto:rminnich@lanl.gov] > Sent: Wednesday, October 06, 2004 12:23 PM > To: YhLu > Cc: Jay Miller; linuxbios(a)clustermatic.org > Subject: RE: Adding a PCI device that doesn't exist (yet) > > > > On Tue, 5 Oct 2004, YhLu wrote: > > >>Can you for the FPGA programming in the auto.c and issue an soft_reset > > in > >>auto.c? > > > I think this can work with the current mechanisms. You need to have > your > > chip programmed pre-pci-scan, and the current config mechanism > supports that fine. > > > Is this V1 or V2, I forget. > > ron > _______________________________________________ > Linuxbios mailing list > Linuxbios(a)clustermatic.org > http://www.clustermatic.org/mailman/listinfo/linuxbios -- Tyson D Sawyer iRobot Corporation Lead Systems Engineer Government & Industrial Robotics tsawyer(a)irobot.com Robots for the Real World 781-345-0200 ext 3329 http://www.irobot.com _______________________________________________ Linuxbios mailing list Linuxbios(a)clustermatic.org http://www.clustermatic.org/mailman/listinfo/linuxbios

1 0

Re: Adding a PCI device that doesn't exist (yet)
by tyson＠irobot.com 06 Oct '04

06 Oct '04

Hopping in mid-thread here so I may have the context wrong: I have succeeded at programming the FPGA to create a PCI device after the boot process. I was then able to have the device driver add the device to the pci device table and get resources allocated for it and get it paired up with the alread loaded device driver. I did not figure out how to de-allocate/de-register such that I could cleanely re-program the FPGA without a re-boot. Is this relevant? Cheers! Ty Jay Miller wrote: > Thanks for your help. Certainly that's not ideal, but it may turn out > to be our only option. > > Currently I'm investigating using proc_pci_attach_device() at the kernel > level to add the device from the driver module init(post-program), but > it's not looking promising. > > Thanks, > > Jay Miller > 781-229-7812x117 > Actuality Systems, Inc. > jmiller(a)actuality-systems.com > > > -----Original Message----- > From: Ronald G. Minnich [mailto:rminnich@lanl.gov] > Sent: Wednesday, October 06, 2004 12:23 PM > To: YhLu > Cc: Jay Miller; linuxbios(a)clustermatic.org > Subject: RE: Adding a PCI device that doesn't exist (yet) > > > > On Tue, 5 Oct 2004, YhLu wrote: > > >>Can you for the FPGA programming in the auto.c and issue an soft_reset > > in > >>auto.c? > > > I think this can work with the current mechanisms. You need to have your > > chip programmed pre-pci-scan, and the current config mechanism supports > that fine. > > > Is this V1 or V2, I forget. > > ron > _______________________________________________ > Linuxbios mailing list > Linuxbios(a)clustermatic.org > http://www.clustermatic.org/mailman/listinfo/linuxbios -- Tyson D Sawyer iRobot Corporation Lead Systems Engineer Government & Industrial Robotics tsawyer(a)irobot.com Robots for the Real World 781-345-0200 ext 3329 http://www.irobot.com

1 0

RE: Adding a PCI device that doesn't exist (yet)
by Dave Aubin 06 Oct '04

06 Oct '04

Yes, hotplug in 2.6 would be excellent, but in order to Make the device hotplug it needs to show up the /sys/bus/pci... Power entry. I'm not sure how to make that happen. If it did then all things would be great. Thanks, Dave -----Original Message----- From: linuxbios-admin(a)clustermatic.org [mailto:linuxbios-admin@clustermatic.org] On Behalf Of Ronald G. Minnich Sent: Wednesday, October 06, 2004 1:23 PM To: Jay Miller Cc: YhLu; linuxbios(a)clustermatic.org Subject: RE: Adding a PCI device that doesn't exist (yet) On Wed, 6 Oct 2004, Jay Miller wrote: > Thanks for your help. Certainly that's not ideal, but it may turn out > to be our only option. the reason being you don't want to embed the bitstream in linuxbios, right? Are you sure that you can't take advantage of the hotplug stuff in 2.6 for your device? Is your device a bridge or ... ron _______________________________________________ Linuxbios mailing list Linuxbios(a)clustermatic.org http://www.clustermatic.org/mailman/listinfo/linuxbios

1 0

RE: Adding a PCI device that doesn't exist (yet)
by Jay Miller 06 Oct '04

06 Oct '04

Exactly! No, it's not a bridge. It's just a card, but I was under the impression that you needed hardware support for hotplug? Dave Aubin had been looking at this and he concluded that without hardware support there needed to be some enumeration present at the time the Linux kernel loads. Presumably this would be provided by the BIOS. This is why I was looking at some way to force an entry into the bus scan of LinuxBIOS, thus providing the enumeration that the hotplug kernel would need. Jay Miller 781-229-7812x117 Actuality Systems, Inc. jmiller(a)actuality-systems.com -----Original Message----- From: Ronald G. Minnich [mailto:rminnich@lanl.gov] Sent: Wednesday, October 06, 2004 1:23 PM To: Jay Miller Cc: YhLu; linuxbios(a)clustermatic.org Subject: RE: Adding a PCI device that doesn't exist (yet) On Wed, 6 Oct 2004, Jay Miller wrote: > Thanks for your help. Certainly that's not ideal, but it may turn out > to be our only option. the reason being you don't want to embed the bitstream in linuxbios, right? Are you sure that you can't take advantage of the hotplug stuff in 2.6 for your device? Is your device a bridge or ... ron

1 0

RE: Adding a PCI device that doesn't exist (yet)
by Ronald G. Minnich 06 Oct '04

06 Oct '04

On Wed, 6 Oct 2004, Jay Miller wrote: > Thanks for your help. Certainly that's not ideal, but it may turn out > to be our only option. the reason being you don't want to embed the bitstream in linuxbios, right? Are you sure that you can't take advantage of the hotplug stuff in 2.6 for your device? Is your device a bridge or ... ron

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot