coreboot April 2021

coreboot@coreboot.org

34 participants
37 discussions

New Defects reported by Coverity Scan for coreboot
by scan-admin＠coverity.com 09 Apr '21

09 Apr '21

Hi, Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan. 1 new defect(s) introduced to coreboot found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1452250: Uninitialized variables (UNINIT) ________________________________________________________________________________________________________ *** CID 1452250: Uninitialized variables (UNINIT) /tests/lib/bootmem-test.c: 235 in init_memory_table_library() 229 struct lb_memory *lb_mem; 230 231 /* Allocate space for 10 lb_mem entries to be safe */ 232 lb_mem = malloc(sizeof(*lb_mem) + 10 * sizeof(struct lb_memory_range)); 233 234 /* We need to call this only to initialize library */ >>> CID 1452250: Uninitialized variables (UNINIT) >>> Using uninitialized value "lb_mem->size" when calling "bootmem_write_memory_table". 235 bootmem_write_memory_table(lb_mem); 236 free(lb_mem); 237 } 238 239 static void test_bootmem_add_range(void **state) 240 { ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

problem after "convert to ASL 2.0"
by Andrew A. I. 08 Apr '21

08 Apr '21

4 6

On handling vendorcode
by Patrick Georgi 08 Apr '21

08 Apr '21

Hi everybody, We recently landed a change (https://review.coreboot.org/51827) to be more selective which parts of src/vendorcode are checked for coding style because some areas are really coreboot code "by vendors". The original purpose of that subhierarchy was to isolate code we draw in from the outside to make every dev aware that the file they're touching has some upstream other than coreboot and that this code shouldn't be modified except to track that upstream. Any objections to moving the code out there that has no other upstream (e.g. src/vendorcode/google/chromeos or src/vendorcode/eltan, I think?) while moving in code from elsewhere in the tree that fits the "it has a foreign upstream" description (e.g. the lzma library)? Regards, Patrick -- Google Germany GmbH, ABC-Str. 19, 20354 Hamburg Registergericht und -nummer: Hamburg, HRB 86891, Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

4 6

New Defects reported by Coverity Scan for coreboot
by scan-admin＠coverity.com 06 Apr '21

06 Apr '21

Hi, Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan. 1 new defect(s) introduced to coreboot found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1452005: Memory - corruptions (OVERRUN) /tests/lib/malloc-test.c: 53 in setup_calloc_test() ________________________________________________________________________________________________________ *** CID 1452005: Memory - corruptions (OVERRUN) /tests/lib/malloc-test.c: 53 in setup_calloc_test() 47 48 return 0; 49 } 50 51 static int setup_calloc_test(void **state) 52 { >>> CID 1452005: Memory - corruptions (OVERRUN) >>> Overrunning buffer pointed to by "&_heap" of 1 bytes by passing it to a function which accesses it at byte offset 4194303 using argument "4194304UL". [Note: The source code implementation of the function has been overridden by a builtin model.] 53 memset(&_heap, 0xFF, TEST_HEAP_SZ); 54 return setup_test(state); 55 } 56 57 static void test_malloc_out_of_memory(void **state) 58 { ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

Re: CB:46587 - pirq_routing
by Mike Banon 06 Apr '21

06 Apr '21

Hi there Elyes, Your "getpir" idea really helped me to implement a set of CB:48427 "AMD good IRQ" patches. Thank you so much for your kind help! Wanted to thank you earlier but it got lost in drafts ;-)

1 0

[coreboot - Bug #304] (New) HP EliteBook 2560p fails to reboot on new kernels
by coreboot＠fe80.eu 03 Apr '21

03 Apr '21

Issue #304 has been reported by Iru Cai. ---------------------------------------- Bug #304: HP EliteBook 2560p fails to reboot on new kernels https://ticket.coreboot.org/issues/304 * Author: Iru Cai * Status: New * Priority: Normal * Assignee: Iru Cai * Category: * Target version: ---------------------------------------- My EliteBook 2560p fails to reboot on new kernels. We need to fix the ACPI of hp/kbc1126. After bisecting the kernel, I found this kernel commit is to blame: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… commit d60cd06331a3566d3305b3c7b566e79edf4e2095 (HEAD, refs/bisect/bad) Author: Kai-Heng Feng <kai.heng.feng(a)canonical.com> Date: Fri Oct 30 15:06:57 2020 +0800 PM: ACPI: reboot: Use S5 for reboot I haven't tested with the OEM firmware yet. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: https://ticket.coreboot.org/my/account

1 0

New Defects reported by Coverity Scan for coreboot
by scan-admin＠coverity.com 02 Apr '21

02 Apr '21

Hi, Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan. 1 new defect(s) introduced to coreboot found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1451732: Incorrect expression (SIZEOF_MISMATCH) /src/soc/ti/am335x/mmc.c: 263 in am335x_mmc_init_storage() ________________________________________________________________________________________________________ *** CID 1451732: Incorrect expression (SIZEOF_MISMATCH) /src/soc/ti/am335x/mmc.c: 263 in am335x_mmc_init_storage() 257 258 int am335x_mmc_init_storage(struct am335x_mmc_host *mmc_host) 259 { 260 int err = 0; 261 262 struct sd_mmc_ctrlr *mmc_ctrlr = &mmc_host->sd_mmc_ctrlr; >>> CID 1451732: Incorrect expression (SIZEOF_MISMATCH) >>> Passing argument "mmc_ctrlr" of type "struct sd_mmc_ctrlr *" and argument "4U /* sizeof (mmc_ctrlr) */" to function "memset" is suspicious. 263 memset(mmc_ctrlr, 0, sizeof(mmc_ctrlr)); 264 265 266 err = am335x_mmc_init(mmc_host->reg); 267 if (err != 0) { 268 printk(BIOS_ERR, "ERROR: Initialising AM335X SD failed.\n"); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot April 2021