coreboot August 2020

coreboot@coreboot.org

22 participants
22 discussions

New Defects reported by Coverity Scan for coreboot
by scan-admin＠coverity.com 04 Aug '20

04 Aug '20

Hi, Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan. 7 new defect(s) introduced to coreboot found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 7 of 7 defect(s) ** CID 1431127: Memory - corruptions (ARRAY_VS_SINGLETON) /src/lib/gcov-glue.c: 128 in coverage_init() ________________________________________________________________________________________________________ *** CID 1431127: Memory - corruptions (ARRAY_VS_SINGLETON) /src/lib/gcov-glue.c: 128 in coverage_init() 122 extern long __CTOR_LIST__; 123 typedef void (*func_ptr)(void); 124 func_ptr *ctor = (func_ptr *) &__CTOR_LIST__; 125 if (ctor == NULL) 126 return; 127 >>> CID 1431127: Memory - corruptions (ARRAY_VS_SINGLETON) >>> Using "ctor" as an array. This might corrupt or misinterpret adjacent memory locations. 128 for (; *ctor != (func_ptr) 0; ctor++) 129 (*ctor)(); 130 } 131 132 void __gcov_flush(void); 133 static void coverage_exit(void *unused) ** CID 1431126: (DEADCODE) /src/lib/libgcov.c: 425 in gcov_exit() /src/lib/libgcov.c: 391 in gcov_exit() ________________________________________________________________________________________________________ *** CID 1431126: (DEADCODE) /src/lib/libgcov.c: 425 in gcov_exit() 419 fname += 2; 420 421 /* Build relocated filename, stripping off leading 422 * directories from the initial filename if requested. 423 */ 424 if (gcov_prefix_strip > 0) { >>> CID 1431126: (DEADCODE) >>> Execution cannot reach this statement: "level = 0;". 425 int level = 0; 426 427 s = fname; 428 if (IS_DIR_SEPARATOR(*s)) 429 ++s; 430 /src/lib/libgcov.c: 391 in gcov_exit() 385 } else 386 #endif 387 prefix_length = 0; 388 389 /* If no prefix was specified and a prefix strip, then we assume 390 relative. */ >>> CID 1431126: (DEADCODE) >>> Execution cannot reach the expression "prefix_length == 0UL" inside this statement: "if (gcov_prefix_strip != 0 ...". 391 if (gcov_prefix_strip != 0 && prefix_length == 0) { 392 gcov_prefix = "."; 393 prefix_length = 1; 394 } 395 /* Allocate and initialize the filename scratch space plus one. */ 396 gi_filename = (char *) alloca(prefix_length + gcov_max_filename + 2); ** CID 1431125: Control flow issues (DEADCODE) /src/lib/gcov-glue.c: 126 in coverage_init() ________________________________________________________________________________________________________ *** CID 1431125: Control flow issues (DEADCODE) /src/lib/gcov-glue.c: 126 in coverage_init() 120 static void coverage_init(void *unused) 121 { 122 extern long __CTOR_LIST__; 123 typedef void (*func_ptr)(void); 124 func_ptr *ctor = (func_ptr *) &__CTOR_LIST__; 125 if (ctor == NULL) >>> CID 1431125: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return;". 126 return; 127 128 for (; *ctor != (func_ptr) 0; ctor++) 129 (*ctor)(); 130 } 131 ** CID 1431124: Integer handling issues (BAD_SHIFT) /src/security/intel/txt/common.c: 166 in validate_acm() ________________________________________________________________________________________________________ *** CID 1431124: Integer handling issues (BAD_SHIFT) /src/security/intel/txt/common.c: 166 in validate_acm() 160 /* 161 * Causes #GP if acm_header->size > processor internal authenticated 162 * code area capacity. 163 * SAFER MODE EXTENSIONS REFERENCE. 164 * Intel 64 and IA-32 Architectures Software Developer Manuals Vol 2D 165 */ >>> CID 1431124: Integer handling issues (BAD_SHIFT) >>> In expression "1UL << log2_ceil((acm_header->size & 0xffffffU) << 2)", shifting by a negative amount has undefined behavior. The shift amount, "log2_ceil((acm_header->size & 0xffffffU) << 2)", is -1. 166 const size_t acm_len = 1UL << log2_ceil((acm_header->size & 0xffffff) << 2); 167 if (max_size_acm_area < acm_len) { 168 printk(BIOS_ERR, "TEE-TXT: BIOS ACM doesn't fit into AC execution region\n"); 169 return ACM_E_NOT_FIT_INTO_CPU_ACM_MEM; 170 } 171 ** CID 1431123: Control flow issues (DEADCODE) /src/lib/libgcov.c: 398 in gcov_exit() ________________________________________________________________________________________________________ *** CID 1431123: Control flow issues (DEADCODE) /src/lib/libgcov.c: 398 in gcov_exit() 392 gcov_prefix = "."; 393 prefix_length = 1; 394 } 395 /* Allocate and initialize the filename scratch space plus one. */ 396 gi_filename = (char *) alloca(prefix_length + gcov_max_filename + 2); 397 if (prefix_length) >>> CID 1431123: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "memcpy(gi_filename, gcov_pr...". 398 memcpy(gi_filename, gcov_prefix, prefix_length); 399 gi_filename_up = gi_filename + prefix_length; 400 401 /* Now merge each file. */ 402 for (gi_ptr = gcov_list; gi_ptr; gi_ptr = gi_ptr->next) { 403 unsigned int n_counts; ** CID 1255942: Code maintainability issues (UNUSED_VALUE) /src/drivers/usb/ehci_debug.c: 572 in usbdebug_init_() ________________________________________________________________________________________________________ *** CID 1255942: Code maintainability issues (UNUSED_VALUE) /src/drivers/usb/ehci_debug.c: 572 in usbdebug_init_() 566 dbgp_mdelay(100); 567 568 struct ehci_dbg_port *port = (void *)(uintptr_t)info->ehci_debug; 569 ret = dbgp_probe_gadget(port, &info->ep_pipe[0]); 570 if (ret < 0) { 571 dprintk(BIOS_INFO, "Could not probe gadget on debug port.\n"); >>> CID 1255942: Code maintainability issues (UNUSED_VALUE) >>> Assigning value "-6" to "ret" here, but that stored value is overwritten before it can be used. 572 ret = -6; 573 goto err; 574 } 575 576 info->ep_pipe[0].status &= ~DBGP_EP_NOT_PRESENT; 577 ** CID 1241836: Code maintainability issues (UNUSED_VALUE) /src/drivers/usb/ehci_debug.c: 561 in usbdebug_init_() ________________________________________________________________________________________________________ *** CID 1241836: Code maintainability issues (UNUSED_VALUE) /src/drivers/usb/ehci_debug.c: 561 in usbdebug_init_() 555 ctrl |= DBGP_CLAIM; 556 write32(&ehci_debug->control, ctrl); 557 ctrl = read32(&ehci_debug->control); 558 if ((ctrl & DBGP_CLAIM) != DBGP_CLAIM) { 559 dprintk(BIOS_INFO, "No device in EHCI debug port.\n"); 560 write32(&ehci_debug->control, ctrl & ~DBGP_CLAIM); >>> CID 1241836: Code maintainability issues (UNUSED_VALUE) >>> Assigning value "-4" to "ret" here, but that stored value is overwritten before it can be used. 561 ret = -4; 562 goto err; 563 } 564 dprintk(BIOS_INFO, "EHCI debug port enabled.\n"); 565 566 dbgp_mdelay(100); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

How to choose my ‘‘mainboard vendor’’ for Sony laptops?
by hd-scania＠users.sf.net 02 Aug '20

02 Aug '20

Laptop model: Sony VPCCB17FG Cores: Intel i7-2620M Coreboot release to be flashed: 4.12 RAM’s: 7.45GiB Graphics: AMD Radeon Old BIOS: By AMI, versioned R0242v2 (no longer receiving Sony’s BIOS upgrades since 2012) Mainboard vendor 1. 51NB (VENDOR_51NB) (NEW) 2. ADLINK (VENDOR_ADLINK) (NEW) 3. AMD (VENDOR_AMD) (NEW) 4. AOpen (VENDOR_AOPEN) (NEW) 5. Apple (VENDOR_APPLE) (NEW) 6. ASROCK (VENDOR_ASROCK) (NEW) 7. ASUS (VENDOR_ASUS) (NEW) 8. BAP (VENDOR_BAP) (NEW) 9. Biostar (VENDOR_BIOSTAR) (NEW) 10. Cavium (VENDOR_CAVIUM) (NEW) 11. CompuLab (VENDOR_COMPULAB) (NEW) 12. ELMEX (VENDOR_ELMEX) (NEW) > 13. Emulation (VENDOR_EMULATION) (NEW) 14. Facebook (VENDOR_FACEBOOK) (NEW) 15. Foxconn (VENDOR_FOXCONN) (NEW) 16. Getac (VENDOR_GETAC) (NEW) 17. GIGABYTE (VENDOR_GIGABYTE) (NEW) 18. GizmoSphere (VENDOR_GIZMOSPHERE) (NEW) 19. Google (VENDOR_GOOGLE) (NEW) 20. HP (VENDOR_HP) (NEW) 21. iBase (VENDOR_IBASE) (NEW) 22. Intel (VENDOR_INTEL) (NEW) 23. Jetway (VENDOR_JETWAY) (NEW) 24. Kontron (VENDOR_KONTRON) (NEW) 25. Lenovo (VENDOR_LENOVO) (NEW) 26. Libretrend (VENDOR_LIBRETREND) (NEW) 27. LiPPERT (VENDOR_LIPPERT) (NEW) 28. MSI (VENDOR_MSI) (NEW) 29. Open Compute Project (VENDOR_OCP) (NEW) 30. OpenCellular (VENDOR_OPENCELLULAR) (NEW) 31. Packard Bell (VENDOR_PACKARDBELL) (NEW) 32. PC Engines (VENDOR_PCENGINES) (NEW) 33. Portwell (VENDOR_PORTWELL) (NEW) 34. Protectli (VENDOR_PROTECTLI) (NEW) 35. Purism (VENDOR_PURISM) (NEW) 36. RAZER (VENDOR_RAZER) (NEW) 37. Roda (VENDOR_RODA) (NEW) 38. SAMSUNG (VENDOR_SAMSUNG) (NEW) 39. Sapphire (VENDOR_SAPPHIRE) (NEW) 40. Scaleway (VENDOR_SCALEWAY) (NEW) 41. Siemens (VENDOR_SIEMENS) (NEW) 42. SiFive (VENDOR_SIFIVE) (NEW) 43. Supermicro (VENDOR_SUPERMICRO) (NEW) 44. System76 (VENDOR_SYSTEM76) (NEW) 45. TI (VENDOR_TI) (NEW) 46. UP (VENDOR_UP) (NEW) choice[1-46]:

4 5

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot August 2020