coreboot March 2013

coreboot@coreboot.org

46 participants
782 discussions

New patch to review for coreboot: bd3d5db armv7/snow: Add S5P MSHC initialization in ROM stage.
by Hung-Te Lin 28 Feb '13

28 Feb '13

Hung-Te Lin (hungte(a)chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2561 -gerrit commit bd3d5dbbf9a3588436013eb04803507e94d767c7 Author: Hung-Te Lin <hungte(a)chromium.org> Date: Fri Mar 1 10:34:04 2013 +0800 armv7/snow: Add S5P MSHC initialization in ROM stage. The SD/MMC interface on Exynos 5250 must be first configured with, GPIO, and pinmux settings before it can be detected and used in ramstage / payload. Verified on armv7/snow and successfully boot into ramstage. Change-Id: I26669eaaa212ab51ca72e8b7712970639a24e5c5 Signed-off-by: Hung-Te Lin <hungte(a)chromium.org> --- src/mainboard/google/snow/romstage.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/src/mainboard/google/snow/romstage.c b/src/mainboard/google/snow/romstage.c index 9891011..7e1cd57 100644 --- a/src/mainboard/google/snow/romstage.c +++ b/src/mainboard/google/snow/romstage.c @@ -24,8 +24,10 @@ #include <cbfs.h> #include <common.h> +#include <arch/gpio.h> #include <cpu/samsung/exynos5250/clk.h> #include <cpu/samsung/exynos5250/dmc.h> +#include <cpu/samsung/exynos5250/gpio.h> #include <cpu/samsung/exynos5250/setup.h> #include <cpu/samsung/exynos5250/periph.h> #include <cpu/samsung/exynos5250/clock_init.h> @@ -35,6 +37,8 @@ #include "mainboard.h" +#define MMC0_GPIO_PIN (58) + #if 0 static int board_wakeup_permitted(void) { @@ -48,6 +52,24 @@ static int board_wakeup_permitted(void) } #endif +static void initialize_s5p_mshc(void) { + /* MMC0: Fixed, support 8 bit mode, connected with GPIO. */ + if (clock_set_mshci(PERIPH_ID_SDMMC0)) + printk(BIOS_CRIT, "Failed to set clock for SDMMC0.\n"); + if (gpio_direction_output(MMC0_GPIO_PIN, 1)) { + printk(BIOS_CRIT, "Unable to power on SDMMC0.\n"); + } + gpio_set_pull(MMC0_GPIO_PIN, EXYNOS_GPIO_PULL_NONE); + gpio_set_drv(MMC0_GPIO_PIN, EXYNOS_GPIO_DRV_4X); + /* TODO(hungte) Change 0 to PINMUX_FLAG_8BIT_MODE when the s5p_mshc + * driver is ready. */ + exynos_pinmux_config(PERIPH_ID_SDMMC0, 0); + + /* MMC2: Removable, 4 bit mode, no GPIO. */ + clock_set_mshci(PERIPH_ID_SDMMC2); + exynos_pinmux_config(PERIPH_ID_SDMMC2, 0); +} + void main(void) { struct mem_timings *mem; @@ -84,6 +106,8 @@ void main(void) mmu_setup(CONFIG_SYS_SDRAM_BASE, CONFIG_DRAM_SIZE_MB); + initialize_s5p_mshc(); + entry = cbfs_load_stage(CBFS_DEFAULT_MEDIA, "fallback/coreboot_ram"); printk(BIOS_INFO, "entry is 0x%p, leaving romstage.\n", entry);

1 0

Patch set updated for coreboot: 3d46566 ARM: Fix the ldscripts so that exit/enter stage work correctly.
by Paul Menzel 28 Feb '13

28 Feb '13

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2560 -gerrit commit 3d46566d55531cee167d7171adf41d0f21a9fb2b Author: Ronald G. Minnich <rminnich(a)gmail.com> Date: Thu Feb 28 15:21:41 2013 -0600 ARM: Fix the ldscripts so that exit/enter stage work correctly. Remove the spurious creation of a start symbol, and use the stage_entry symbol directly. Change-Id: Ia62d5c056ac8b20c8ffdb78bff3d306065b6c45f Signed-off-by: Ronald G. Minnich <rminnich(a)gmail.com> --- src/arch/armv7/coreboot_ram.ld | 2 +- src/arch/armv7/romstage.ld | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/arch/armv7/coreboot_ram.ld b/src/arch/armv7/coreboot_ram.ld index 2edf8e3..c2ead7a 100644 --- a/src/arch/armv7/coreboot_ram.ld +++ b/src/arch/armv7/coreboot_ram.ld @@ -22,7 +22,7 @@ /* We use ELF as output format. So that we can debug the code in some form. */ INCLUDE ldoptions -ENTRY(_start) +ENTRY(stage_entry) SECTIONS { diff --git a/src/arch/armv7/romstage.ld b/src/arch/armv7/romstage.ld index 6728fb1..568ac1a 100644 --- a/src/arch/armv7/romstage.ld +++ b/src/arch/armv7/romstage.ld @@ -28,7 +28,7 @@ OUTPUT_FORMAT("elf32-littlearm", "elf32-littlearm", "elf32-littlearm") OUTPUT_ARCH(arm) -ENTRY(_start) +ENTRY(stage_entry) SECTIONS {

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot March 2013