coreboot November 2012

coreboot@coreboot.org

35 participants
895 discussions

New patch to review for coreboot: 3f035bf libpayload: Implement correct interrupt-queue linking for UHCI
by Nico Huber 23 Nov '12

23 Nov '12

Nico Huber (nico.huber(a)secunet.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1897 -gerrit commit 3f035bfc1a2cbd74b9630a586c7819187a2260eb Author: Nico Huber <nico.huber(a)secunet.com> Date: Tue Nov 20 17:27:46 2012 +0100 libpayload: Implement correct interrupt-queue linking for UHCI The linking of interrupt queues into UHCI controller's framelist (in uhci_create_intr_queue()) was incomplete. The implementation of uhci_destroy_intr_queue() was even worse, looking like it wanted to clean up more than uhci_create_intr_queue() did. This patch follows the simple approach that we used for OHCI and EHCI: Each slot in the framelist holds only one interrupt queue. Therefore, we have to look for free slots each time we want to link an interrupt queue into the framelist. In return, we have a much simpler structured framelist. With this, USB devices using interrupt transfers (e.g. keyboards) can be detached cleanly from UHCI controllers. Also, more than one of such devices can be attached without further risk. Change-Id: I07b81a3b6f2cb3ff69515c973b3ae6321ad969aa Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- payloads/libpayload/drivers/usb/uhci.c | 49 +++++++++++++++++++++------------- 1 file changed, 30 insertions(+), 19 deletions(-) diff --git a/payloads/libpayload/drivers/usb/uhci.c b/payloads/libpayload/drivers/usb/uhci.c index 2eea375..bfa53f6 100644 --- a/payloads/libpayload/drivers/usb/uhci.c +++ b/payloads/libpayload/drivers/usb/uhci.c @@ -517,11 +517,27 @@ uhci_create_intr_queue (endpoint_t *ep, int reqsize, int reqcount, int reqtiming data += reqsize; } tds[reqcount - 1].ptr = 0 | TD_TERMINATE; - for (i = reqtiming; i < 1024; i += reqtiming) { - /* FIXME: wrap in another qh, one for each occurance of the qh in the framelist */ - qh->headlinkptr = UHCI_INST (ep->dev->controller)->framelistptr[i] & ~FLISTP_TERMINATE; - UHCI_INST (ep->dev->controller)->framelistptr[i] = virt_to_phys(qh) | FLISTP_QH; + + /* insert QH into framelist */ + uhci_t *const uhcic = UHCI_INST(ep->dev->controller); + const u32 def_ptr = virt_to_phys(uhcic->qh_prei) | FLISTP_QH; + int nothing_placed = 1; + qh->headlinkptr = def_ptr; + for (i = 0; i < 1024; i += reqtiming) { + /* advance to the next free position */ + while ((i < 1024) && (uhcic->framelistptr[i] != def_ptr)) ++i; + if (i < 1024) { + uhcic->framelistptr[i] = virt_to_phys(qh) | FLISTP_QH; + nothing_placed = 0; + } } + if (nothing_placed) { + printf("Error: Failed to place UHCI interrupt queue " + "head into framelist: no space left\n"); + uhci_destroy_intr_queue(ep, q); + return NULL; + } + return q; } @@ -529,23 +545,18 @@ uhci_create_intr_queue (endpoint_t *ep, int reqsize, int reqcount, int reqtiming static void uhci_destroy_intr_queue (endpoint_t *ep, void *q_) { - intr_q *q = (intr_q*)q_; - u32 val = virt_to_phys (q->qh); - u32 end = virt_to_phys (UHCI_INST (ep->dev->controller)->qh_intr); + intr_q *const q = (intr_q*)q_; + + /* remove QH from framelist */ + uhci_t *const uhcic = UHCI_INST(ep->dev->controller); + const u32 qh_ptr = virt_to_phys(q->qh) | FLISTP_QH; + const u32 def_ptr = virt_to_phys(uhcic->qh_prei) | FLISTP_QH; int i; - for (i=0; i<1024; i++) { - u32 oldptr = 0; - u32 ptr = UHCI_INST (ep->dev->controller)->framelistptr[i]; - while (ptr != end) { - if (((qh_t*)phys_to_virt(ptr))->elementlinkptr == val) { - ((qh_t*)phys_to_virt(oldptr))->headlinkptr = ((qh_t*)phys_to_virt(ptr))->headlinkptr; - free(phys_to_virt(ptr)); - break; - } - oldptr = ptr; - ptr = ((qh_t*)phys_to_virt(ptr))->headlinkptr; - } + for (i = 0; i < 1024; ++i) { + if (uhcic->framelistptr[i] == qh_ptr) + uhcic->framelistptr[i] = def_ptr; } + free(q->data); free(q->tds); free(q->qh);

1 0

New patch to review for coreboot: 0042f7a libpayload: ehci: Fix warnings about discarded volatile
by Nico Huber 23 Nov '12

23 Nov '12

Nico Huber (nico.huber(a)secunet.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1896 -gerrit commit 0042f7a8f3e757facdf2a9a5eaa0231ff062a4f6 Author: Nico Huber <nico.huber(a)secunet.com> Date: Fri Nov 23 11:58:57 2012 +0100 libpayload: ehci: Fix warnings about discarded volatile We can trust free() and memset() to work correctly on volatile references, so cast volatile pointers to (void *) when calling them. Change-Id: Ieff7f78133b72f303349cca0a0ca3bbf37ec52bb Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- payloads/libpayload/drivers/usb/ehci.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/payloads/libpayload/drivers/usb/ehci.c b/payloads/libpayload/drivers/usb/ehci.c index 5f65c53..5f70b64 100644 --- a/payloads/libpayload/drivers/usb/ehci.c +++ b/payloads/libpayload/drivers/usb/ehci.c @@ -102,7 +102,7 @@ static void ehci_shutdown (hci_t *controller) free(phys_to_virt(EHCI_INST(controller)->operation->periodiclistbase)); /* Free dummy QH */ - free(EHCI_INST(controller)->dummy_qh); + free((void *)EHCI_INST(controller)->dummy_qh); EHCI_INST(controller)->operation->configflag = 0; @@ -179,10 +179,10 @@ static void free_qh_and_tds(ehci_qh_t *qh, qtd_t *cur) qtd_t *next; while (cur) { next = (qtd_t*)phys_to_virt(cur->next_qtd & ~31); - free(cur); + free((void *)cur); cur = next; } - free(qh); + free((void *)qh); } static int wait_for_tds(qtd_t *head) @@ -288,7 +288,7 @@ static int ehci_bulk (endpoint_t *ep, int size, u8 *data, int finalize) qtd_t *head = memalign(32, sizeof(qtd_t)); qtd_t *cur = head; while (1) { - memset(cur, 0, sizeof(qtd_t)); + memset((void *)cur, 0, sizeof(qtd_t)); cur->token = QTD_ACTIVE | (pid << QTD_PID_SHIFT) | (0 << QTD_CERR_SHIFT); @@ -309,7 +309,7 @@ static int ehci_bulk (endpoint_t *ep, int size, u8 *data, int finalize) /* create QH */ ehci_qh_t *qh = memalign(32, sizeof(ehci_qh_t)); - memset(qh, 0, sizeof(ehci_qh_t)); + memset((void *)qh, 0, sizeof(ehci_qh_t)); qh->horiz_link_ptr = virt_to_phys(qh) | QH_QH; qh->epchar = ep->dev->address | (endp << QH_EP_SHIFT) | @@ -356,7 +356,7 @@ static int ehci_control (usbdev_t *dev, direction_t dir, int drlen, void *devreq /* create qTDs */ qtd_t *head = memalign(32, sizeof(qtd_t)); qtd_t *cur = head; - memset(cur, 0, sizeof(qtd_t)); + memset((void *)cur, 0, sizeof(qtd_t)); cur->token = QTD_ACTIVE | (toggle?QTD_TOGGLE_DATA1:0) | (EHCI_SETUP << QTD_PID_SHIFT) | @@ -373,7 +373,7 @@ static int ehci_control (usbdev_t *dev, direction_t dir, int drlen, void *devreq if (dalen > 0) { toggle ^= 1; cur = next; - memset(cur, 0, sizeof(qtd_t)); + memset((void *)cur, 0, sizeof(qtd_t)); cur->token = QTD_ACTIVE | (toggle?QTD_TOGGLE_DATA1:0) | (((dir == OUT)?EHCI_OUT:EHCI_IN) << QTD_PID_SHIFT) | @@ -388,7 +388,7 @@ static int ehci_control (usbdev_t *dev, direction_t dir, int drlen, void *devreq toggle = 1; cur = next; - memset(cur, 0, sizeof(qtd_t)); + memset((void *)cur, 0, sizeof(qtd_t)); cur->token = QTD_ACTIVE | (toggle?QTD_TOGGLE_DATA1:QTD_TOGGLE_DATA0) | ((dir == OUT)?EHCI_IN:EHCI_OUT) << QTD_PID_SHIFT | @@ -399,7 +399,7 @@ static int ehci_control (usbdev_t *dev, direction_t dir, int drlen, void *devreq /* create QH */ ehci_qh_t *qh = memalign(32, sizeof(ehci_qh_t)); - memset(qh, 0, sizeof(ehci_qh_t)); + memset((void *)qh, 0, sizeof(ehci_qh_t)); qh->horiz_link_ptr = virt_to_phys(qh) | QH_QH; qh->epchar = dev->address | (endp << QH_EP_SHIFT) | @@ -525,7 +525,7 @@ static void *ehci_create_intr_queue( /* initialize QH */ const int endp = ep->endpoint & 0xf; - memset(&intrq->qh, 0, sizeof(intrq->qh)); + memset((void *)&intrq->qh, 0, sizeof(intrq->qh)); intrq->qh.horiz_link_ptr = PS_TERMINATE; intrq->qh.epchar = ep->dev->address | (endp << QH_EP_SHIFT) | @@ -628,7 +628,7 @@ static u8 *ehci_poll_intr_queue(void *const queue) /* reset queue if we fully processed it after underrun */ else if (intrq->qh.td.next_qtd & QTD_TERMINATE) { usb_debug("resetting underrun ehci interrupt queue.\n"); - memset(&intrq->qh.td, 0, sizeof(intrq->qh.td)); + memset((void *)&intrq->qh.td, 0, sizeof(intrq->qh.td)); intrq->qh.td.next_qtd = virt_to_phys(&intrq->head->td); } return ret; @@ -699,7 +699,7 @@ ehci_init (pcidev_t addr) * and doesn't violate the standard. */ EHCI_INST(controller)->dummy_qh = (ehci_qh_t *)memalign(32, sizeof(ehci_qh_t)); - memset(EHCI_INST(controller)->dummy_qh, 0, + memset((void *)EHCI_INST(controller)->dummy_qh, 0, sizeof(*EHCI_INST(controller)->dummy_qh)); EHCI_INST(controller)->dummy_qh->horiz_link_ptr = QH_TERMINATE; for (i = 0; i < 1024; ++i)

1 0

New patch to review for coreboot: 80a0395 libpayload: Fix random warnings
by Nico Huber 23 Nov '12

23 Nov '12

Nico Huber (nico.huber(a)secunet.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1895 -gerrit commit 80a0395f340cd54811b342d0960ef8f956a0bb67 Author: Nico Huber <nico.huber(a)secunet.com> Date: Fri Nov 23 11:52:18 2012 +0100 libpayload: Fix random warnings dump_td() is orphaned but looks useful => commented out. The delay identifier shadowed the global one => renamed to total_delay. Change-Id: I4f3766a07db9194b2552ebf9302bd7ef8a66371f Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- payloads/libpayload/drivers/usb/ohci.c | 2 ++ payloads/libpayload/drivers/usb/ohci_rh.c | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/payloads/libpayload/drivers/usb/ohci.c b/payloads/libpayload/drivers/usb/ohci.c index b128029..ad5638c 100644 --- a/payloads/libpayload/drivers/usb/ohci.c +++ b/payloads/libpayload/drivers/usb/ohci.c @@ -205,6 +205,7 @@ ohci_stop (hci_t *controller) // TODO: turn off all operation of OHCI } +#if 0 static void dump_td(td_t *cur, int level) { @@ -216,6 +217,7 @@ dump_td(td_t *cur, int level) usb_debug("%s toggle: %x\n", spc, !!(cur->config & TD_TOGGLE_DATA1)); #endif } +#endif static int wait_for_ed(usbdev_t *dev, ed_t *head, int pages) diff --git a/payloads/libpayload/drivers/usb/ohci_rh.c b/payloads/libpayload/drivers/usb/ohci_rh.c index eb3e10b..9de2b98 100644 --- a/payloads/libpayload/drivers/usb/ohci_rh.c +++ b/payloads/libpayload/drivers/usb/ohci_rh.c @@ -48,8 +48,8 @@ ohci_rh_enable_port (usbdev_t *dev, int port) * After reset, the port will be enabled automatically (ohci spec * 7.4.4). */ - int delay = 100; /* 100 * 500us == 50ms */ - while (delay > 0) { + int total_delay = 100; /* 100 * 500us == 50ms */ + while (total_delay > 0) { if (!(OHCI_INST(dev->controller)->opreg->HcRhPortStatus[port] & CurrentConnectStatus)) return; @@ -61,7 +61,7 @@ ohci_rh_enable_port (usbdev_t *dev, int port) while ((OHCI_INST (dev->controller)->opreg->HcRhPortStatus[port] & PortResetStatus) && timeout--) { - udelay(500); delay--; + udelay(500); total_delay--; } if (OHCI_INST (dev->controller)->opreg->HcRhPortStatus[port] & PortResetStatus) {

1 0

New patch to review for coreboot: 844e497 libpayload: Fix some missing-prototype warnings
by Nico Huber 23 Nov '12

23 Nov '12

Nico Huber (nico.huber(a)secunet.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1894 -gerrit commit 844e49782d0831c3ea9ae2bfaa3cf28a4e72f5f0 Author: Nico Huber <nico.huber(a)secunet.com> Date: Fri Nov 23 11:34:20 2012 +0100 libpayload: Fix some missing-prototype warnings usb_controller_initialize() is not declared in any header file nor called from outside of usbinit.c, so make it static. set_configuration() looks like beeing non-static on purpose (like the other helpers around it in usb.c), so put a prototype into usb.h. Change-Id: I08d93b3769d8398bb43462d9afdfeec81fef93ec Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- payloads/libpayload/drivers/usb/usbinit.c | 2 +- payloads/libpayload/include/usb/usb.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/payloads/libpayload/drivers/usb/usbinit.c b/payloads/libpayload/drivers/usb/usbinit.c index 4419ce6..f95e9c1 100644 --- a/payloads/libpayload/drivers/usb/usbinit.c +++ b/payloads/libpayload/drivers/usb/usbinit.c @@ -42,7 +42,7 @@ * @param dev PCI device id at bus * @param func function id of the controller */ -int usb_controller_initialize(int bus, int dev, int func) +static int usb_controller_initialize(int bus, int dev, int func) { u32 class; u32 devclass; diff --git a/payloads/libpayload/include/usb/usb.h b/payloads/libpayload/include/usb/usb.h index 8e286b4..d862182 100644 --- a/payloads/libpayload/include/usb/usb.h +++ b/payloads/libpayload/include/usb/usb.h @@ -230,6 +230,7 @@ void init_device_entry (hci_t *controller, int num); void set_feature (usbdev_t *dev, int endp, int feature, int rtype); void get_status (usbdev_t *dev, int endp, int rtype, int len, void *data); +void set_configuration (usbdev_t *dev); int clear_feature (usbdev_t *dev, int endp, int feature, int rtype); int clear_stall (endpoint_t *ep);

1 0

Patch set updated for coreboot: 0a3f239 crossgcc: properly test for flex
by gerrit＠coreboot.org 23 Nov '12

23 Nov '12

just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1893 -gerrit commit 0a3f2393aefd8fceea075e3108d581aadec292ab Author: Patrick Georgi <patrick.georgi(a)secunet.com> Date: Tue Nov 20 12:04:32 2012 +0100 crossgcc: properly test for flex This is no GNU tool, so testing for "GNU" in the version string is bound to fail. We now accept everything that returns success on "flex --version" and then hope for the best. I tested both cases Change-Id: If325f613fde1648847b998b7e8e5782d0f22b484 Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> Reviewed-on: http://review.coreboot.org/1884 Tested-by: build bot (Jenkins) Reviewed-by: Zheng Bao <zheng.bao(a)amd.com> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- util/crossgcc/buildgcc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 91ec1cf..28e700b 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -119,7 +119,11 @@ MAKE=`searchgnu make` || exit $? searchgnu m4 > /dev/null searchgnu bison > /dev/null -searchgnu flex > /dev/null + +if ! flex --version > /dev/null 2> /dev/null; then + printf "${RED}ERROR:${red} Missing toolchain: flex${NC}\n" >&2 + exit 1 +fi cleanup() {

1 0

Patch set updated for coreboot: 0a3f239 crossgcc: properly test for flex
by gerrit＠coreboot.org 23 Nov '12

23 Nov '12

just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1892 -gerrit commit 0a3f2393aefd8fceea075e3108d581aadec292ab Author: Patrick Georgi <patrick.georgi(a)secunet.com> Date: Tue Nov 20 12:04:32 2012 +0100 crossgcc: properly test for flex This is no GNU tool, so testing for "GNU" in the version string is bound to fail. We now accept everything that returns success on "flex --version" and then hope for the best. I tested both cases Change-Id: If325f613fde1648847b998b7e8e5782d0f22b484 Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> Reviewed-on: http://review.coreboot.org/1884 Tested-by: build bot (Jenkins) Reviewed-by: Zheng Bao <zheng.bao(a)amd.com> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- util/crossgcc/buildgcc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 91ec1cf..28e700b 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -119,7 +119,11 @@ MAKE=`searchgnu make` || exit $? searchgnu m4 > /dev/null searchgnu bison > /dev/null -searchgnu flex > /dev/null + +if ! flex --version > /dev/null 2> /dev/null; then + printf "${RED}ERROR:${red} Missing toolchain: flex${NC}\n" >&2 + exit 1 +fi cleanup() {

1 0

Patch set updated for coreboot: 0a3f239 crossgcc: properly test for flex
by gerrit＠coreboot.org 23 Nov '12

23 Nov '12

just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1891 -gerrit commit 0a3f2393aefd8fceea075e3108d581aadec292ab Author: Patrick Georgi <patrick.georgi(a)secunet.com> Date: Tue Nov 20 12:04:32 2012 +0100 crossgcc: properly test for flex This is no GNU tool, so testing for "GNU" in the version string is bound to fail. We now accept everything that returns success on "flex --version" and then hope for the best. I tested both cases Change-Id: If325f613fde1648847b998b7e8e5782d0f22b484 Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> Reviewed-on: http://review.coreboot.org/1884 Tested-by: build bot (Jenkins) Reviewed-by: Zheng Bao <zheng.bao(a)amd.com> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- util/crossgcc/buildgcc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 91ec1cf..28e700b 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -119,7 +119,11 @@ MAKE=`searchgnu make` || exit $? searchgnu m4 > /dev/null searchgnu bison > /dev/null -searchgnu flex > /dev/null + +if ! flex --version > /dev/null 2> /dev/null; then + printf "${RED}ERROR:${red} Missing toolchain: flex${NC}\n" >&2 + exit 1 +fi cleanup() {

1 0

Patch set updated for coreboot: 0a3f239 crossgcc: properly test for flex
by gerrit＠coreboot.org 23 Nov '12

23 Nov '12

just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1890 -gerrit commit 0a3f2393aefd8fceea075e3108d581aadec292ab Author: Patrick Georgi <patrick.georgi(a)secunet.com> Date: Tue Nov 20 12:04:32 2012 +0100 crossgcc: properly test for flex This is no GNU tool, so testing for "GNU" in the version string is bound to fail. We now accept everything that returns success on "flex --version" and then hope for the best. I tested both cases Change-Id: If325f613fde1648847b998b7e8e5782d0f22b484 Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> Reviewed-on: http://review.coreboot.org/1884 Tested-by: build bot (Jenkins) Reviewed-by: Zheng Bao <zheng.bao(a)amd.com> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- util/crossgcc/buildgcc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 91ec1cf..28e700b 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -119,7 +119,11 @@ MAKE=`searchgnu make` || exit $? searchgnu m4 > /dev/null searchgnu bison > /dev/null -searchgnu flex > /dev/null + +if ! flex --version > /dev/null 2> /dev/null; then + printf "${RED}ERROR:${red} Missing toolchain: flex${NC}\n" >&2 + exit 1 +fi cleanup() {

1 0

Patch set updated for coreboot: 0a3f239 crossgcc: properly test for flex
by gerrit＠coreboot.org 23 Nov '12

23 Nov '12

just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1889 -gerrit commit 0a3f2393aefd8fceea075e3108d581aadec292ab Author: Patrick Georgi <patrick.georgi(a)secunet.com> Date: Tue Nov 20 12:04:32 2012 +0100 crossgcc: properly test for flex This is no GNU tool, so testing for "GNU" in the version string is bound to fail. We now accept everything that returns success on "flex --version" and then hope for the best. I tested both cases Change-Id: If325f613fde1648847b998b7e8e5782d0f22b484 Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> Reviewed-on: http://review.coreboot.org/1884 Tested-by: build bot (Jenkins) Reviewed-by: Zheng Bao <zheng.bao(a)amd.com> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- util/crossgcc/buildgcc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 91ec1cf..28e700b 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -119,7 +119,11 @@ MAKE=`searchgnu make` || exit $? searchgnu m4 > /dev/null searchgnu bison > /dev/null -searchgnu flex > /dev/null + +if ! flex --version > /dev/null 2> /dev/null; then + printf "${RED}ERROR:${red} Missing toolchain: flex${NC}\n" >&2 + exit 1 +fi cleanup() {

1 0

Re: [coreboot] HM67 mobile chipset coreboot support
by Peter Stuge 23 Nov '12

23 Nov '12

keeran k wrote: > Am in process of collecting the information to support intel 6 series > chipset (based on my laptop config). As mentioned the Coreboot/FAQ. > Just want to check, will coreboot work on my laptop? It will work fine once you've spent a year or so to develop the support. //Peter

2 1

← Newer
1
...
19
20
21
22
23
24
25
...
90
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot November 2012