coreboot September 2007

coreboot@coreboot.org

81 participants
367 discussions

[LinuxBIOS] problems with reboot on K8
by Rudolf Marek 04 Sep '07

04 Sep '07

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello all, I cant get the reboot working. I have set CPU reboot to INIT in my SB, so INIT is generated when booting via KBD/92, Linuxbios will jump to real_main, same way as it boots from cold, but got freeze on setup_default_resource_map(); I'm using default usermap from K8, sometimes it writes more entries to 0:18.1 sometimes just first (the code which takes the resource table and simply do the pci writes, with correct and and or mask) I dont know even if my code should reboot this way? But the devel guide from AMD suggest that this must be set up again. I dont know at all what is wrong? The soft_reset is called from init_cpus, maybe too early for the NB? Any help is kindly appreciated. Other stuff is working fine, I'm using LB on daily use. Once reboot work I will release my KT890/VT8237 on Asus A8V-E SE mb LB code to public testing and review. thanks, Rudolf -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFG0bkB3J9wPJqZRNURArXZAKC4hgRju24kgym7x5auicd49Re56ACdHHTu 7vvFeslx3Zx4s1GUgDY8sPk= =2ucY -----END PGP SIGNATURE-----

2 5

[LinuxBIOS] [PATCH] lar use run_address
by Alex Beregszaszi 04 Sep '07

04 Sep '07

Hi, minor patch: use run_address() instead duplicating in lib/lar.c -- Alex

2 1

[LinuxBIOS] r493 - LinuxBIOSv3/lib
by svn＠openbios.org 04 Sep '07

04 Sep '07

Author: stepan Date: 2007-09-05 04:10:45 +0200 (Wed, 05 Sep 2007) New Revision: 493 Modified: LinuxBIOSv3/lib/lar.c Log: minor patch: use run_address() instead duplicating in lib/lar.c Signed-off-by: Alex Beregszaszi <alex(a)rtfs.hu> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: LinuxBIOSv3/lib/lar.c =================================================================== --- LinuxBIOSv3/lib/lar.c 2007-09-05 02:05:55 UTC (rev 492) +++ LinuxBIOSv3/lib/lar.c 2007-09-05 02:10:45 UTC (rev 493) @@ -233,7 +233,6 @@ */ int run_file(struct mem_file *archive, const char *filename, void *where) { - int (*v) (void); struct mem_file result; int ret; @@ -261,8 +260,7 @@ where = result.start; } printk(BIOS_SPEW, "where is %p\n", where); - v = where; - ret = v(); + ret = run_address(where); printk(BIOS_SPEW, "run_file returns with %d\n", ret); return ret; }

1 0

[LinuxBIOS] r492 - LinuxBIOSv3/lib
by svn＠openbios.org 04 Sep '07

04 Sep '07

Author: stepan Date: 2007-09-05 04:05:55 +0200 (Wed, 05 Sep 2007) New Revision: 492 Modified: LinuxBIOSv3/lib/lar.c Log: this patch returns if someone tries to execute in place a compressed entry. Signed-off-by: Alex Beregszaszi <alex(a)rtfs.hu> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: LinuxBIOSv3/lib/lar.c =================================================================== --- LinuxBIOSv3/lib/lar.c 2007-09-05 01:59:27 UTC (rev 491) +++ LinuxBIOSv3/lib/lar.c 2007-09-05 02:05:55 UTC (rev 492) @@ -251,6 +251,13 @@ filename); return 1; } + if (result.compression != 0) { + printk(BIOS_INFO, + "LAR: Run file %s failed: Compressed file" + " not supported for in-place execution\n", + filename); + return 1; + } where = result.start; } printk(BIOS_SPEW, "where is %p\n", where);

1 0

[LinuxBIOS] r491 - LinuxBIOSv3/arch/x86
by svn＠openbios.org 04 Sep '07

04 Sep '07

Author: stepan Date: 2007-09-05 03:59:27 +0200 (Wed, 05 Sep 2007) New Revision: 491 Modified: LinuxBIOSv3/arch/x86/stage1.c Log: run_address gets called with entry=0. This patch fixes it. Signed-off-by: Alex Beregszaszi <alex(a)rtfs.hu> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: LinuxBIOSv3/arch/x86/stage1.c =================================================================== --- LinuxBIOSv3/arch/x86/stage1.c 2007-09-05 01:54:28 UTC (rev 490) +++ LinuxBIOSv3/arch/x86/stage1.c 2007-09-05 01:59:27 UTC (rev 491) @@ -189,7 +189,8 @@ entry = newentry; } printk(BIOS_SPEW, "all loaded, entry %p\n", entry); - run_address(entry); + if (entry) + run_address(entry); die("FATAL: No usable payload found.\n");

1 0

[LinuxBIOS] [PATCH] elfboot minor changes
by Alex Beregszaszi 04 Sep '07

04 Sep '07

Hi, cleanupmsg.diff changes the "(cleaned up) New segment.." message to be displayed only when the condition happens. properzero.diff changes the memset to only clean up the area which is not memcopied to. -- Alex

2 1

[LinuxBIOS] r490 - LinuxBIOSv3/lib
by svn＠openbios.org 04 Sep '07

04 Sep '07

Author: stepan Date: 2007-09-05 03:54:28 +0200 (Wed, 05 Sep 2007) New Revision: 490 Modified: LinuxBIOSv3/lib/elfboot.c Log: properzero.diff changes the memset to only clean up the area which is not memcopied to. Signed-off-by: Alex Beregszaszi <alex(a)rtfs.hu> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: LinuxBIOSv3/lib/elfboot.c =================================================================== --- LinuxBIOSv3/lib/elfboot.c 2007-09-05 01:53:37 UTC (rev 489) +++ LinuxBIOSv3/lib/elfboot.c 2007-09-05 01:54:28 UTC (rev 490) @@ -112,16 +112,13 @@ /* Verify the memory addresses in the segment are valid */ if (!valid_area(mem, phdr[i].p_paddr, size)) goto out; - /* let's just be stupid about this. Bzero the whole area we are copying to, - * then copy out the data, which may be a subset of the total area. - * the cache, after all, is your friend. - */ - printk(BIOS_INFO, "Set %p to 0 for %d bytes\n", (unsigned char *)phdr[i].p_paddr, phdr[i].p_memsz); - memset((unsigned char *)phdr[i].p_paddr, 0, phdr[i].p_memsz); /* ok, copy it out */ printk(BIOS_INFO, "Copy to %p from %p for %d bytes\n", (unsigned char *)phdr[i].p_paddr, &header[phdr[i].p_offset], size); memcpy((unsigned char *)phdr[i].p_paddr, &header[phdr[i].p_offset], size); - + if (size < phdr[i].p_memsz) { + printk(BIOS_INFO, "Set %p to 0 for %d bytes\n", (unsigned char *)phdr[i].p_paddr, phdr[i].p_memsz-size); + memset((unsigned char *)phdr[i].p_paddr+size, 0, phdr[i].p_memsz-size); + } } return 1; out:

1 0

[LinuxBIOS] r489 - LinuxBIOSv3/lib
by svn＠openbios.org 04 Sep '07

04 Sep '07

Author: stepan Date: 2007-09-05 03:53:37 +0200 (Wed, 05 Sep 2007) New Revision: 489 Modified: LinuxBIOSv3/lib/elfboot.c Log: cleanupmsg.diff changes the "(cleaned up) New segment.." message to be displayed only when the condition happens. Signed-off-by: Alex Beregszaszi <alex(a)rtfs.hu> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: LinuxBIOSv3/lib/elfboot.c =================================================================== --- LinuxBIOSv3/lib/elfboot.c 2007-09-05 01:47:21 UTC (rev 488) +++ LinuxBIOSv3/lib/elfboot.c 2007-09-05 01:53:37 UTC (rev 489) @@ -103,11 +103,11 @@ phdr[i].p_paddr, phdr[i].p_memsz, phdr[i].p_offset, phdr[i].p_filesz); /* Clean up the values */ size = phdr[i].p_filesz; - if (phdr[i].p_filesz > phdr[i].p_memsz) { + if (size > phdr[i].p_memsz) { size = phdr[i].p_memsz; + printk(BIOS_DEBUG, "(cleaned up) New segment addr 0x%x size 0x%x offset 0x%x\n", + phdr[i].p_paddr, size, phdr[i].p_offset); } - printk(BIOS_DEBUG, "(cleaned up) New segment addr 0x%x size 0x%x offset 0x%x\n", - phdr[i].p_paddr, size, phdr[i].p_offset); /* Verify the memory addresses in the segment are valid */ if (!valid_area(mem, phdr[i].p_paddr, size))

1 0

[LinuxBIOS] [PATCH] stage1 multi-segment lar bug
by Alex Beregszaszi 04 Sep '07

04 Sep '07

Hi, the new multi-segment lar handling has an off-by-one error in the printk. -- Alex

2 1

[LinuxBIOS] r488 - LinuxBIOSv3/arch/x86
by svn＠openbios.org 04 Sep '07

04 Sep '07

Author: stepan Date: 2007-09-05 03:47:21 +0200 (Wed, 05 Sep 2007) New Revision: 488 Modified: LinuxBIOSv3/arch/x86/stage1.c Log: the new multi-segment lar handling has an off-by-one error in the printk. Signed-off-by: Alex Beregszaszi <alex(a)rtfs.hu> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: LinuxBIOSv3/arch/x86/stage1.c =================================================================== --- LinuxBIOSv3/arch/x86/stage1.c 2007-09-05 01:41:52 UTC (rev 487) +++ LinuxBIOSv3/arch/x86/stage1.c 2007-09-05 01:47:21 UTC (rev 488) @@ -182,7 +182,7 @@ archive.len = *(u32 *)0xfffffff4; archive.start =(void *)(0UL-archive.len); newentry = load_file(&archive, filename); - printk("newentry is %p\n", newentry); + printk(BIOS_SPEW, "newentry is %p\n", newentry); if (newentry == (void *)-1) break; if (! entry)

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot September 2007